diff options
| author | Nick Thomas <nick@gitlab.com> | 2019-08-01 19:18:17 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-08-05 16:42:34 +0300 |
| commit | d3a3db4218e10c65c2e87c763ad02169f3736883 (patch) | |
| tree | 4fc682cc529520bef4e69d740c9fdea99d46c2c3 /app/models/deploy_keys_project.rb | |
| parent | ded3b7574dbd6e1b3249c9e5bbcc61090c733142 (diff) | |
Speed up loading and filtering deploy keys and their projects
This commit changes how we eager-load projects, routes, and namespaces
required by the deploy keys endpoint, getting a 10x improvement in my
local testing.
The endpoint still doesn't scale in-general, but going from ~13 seconds
to dump a 63K result to generating the same thing in ~1.6 seconds seems
like a good improvement to me.
Diffstat (limited to 'app/models/deploy_keys_project.rb')
| -rw-r--r-- | app/models/deploy_keys_project.rb | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/app/models/deploy_keys_project.rb b/app/models/deploy_keys_project.rb index 15906ed8e06..40c66d5bc4c 100644 --- a/app/models/deploy_keys_project.rb +++ b/app/models/deploy_keys_project.rb @@ -1,9 +1,8 @@ # frozen_string_literal: true class DeployKeysProject < ApplicationRecord - belongs_to :project + belongs_to :project, inverse_of: :deploy_keys_projects belongs_to :deploy_key, inverse_of: :deploy_keys_projects - scope :without_project_deleted, -> { joins(:project).where(projects: { pending_delete: false }) } scope :in_project, ->(project) { where(project: project) } scope :with_write_access, -> { where(can_push: true) } |