diff options
author | Jarka Kadlecová <jarka@gitlab.com> | 2017-12-28 14:17:31 +0300 |
---|---|---|
committer | Jarka Kadlecová <jarka@gitlab.com> | 2017-12-29 16:44:39 +0300 |
commit | c1ea4afad760af7bbb0a38a2519445e0717b7b2e (patch) | |
tree | 7ceb8b263a31d885ed4d3d1ed9a758c2e521004d /app/models/diff_discussion.rb | |
parent | 4e0b6bf714f6e009c5a3ded5c3250ac9e178412f (diff) |
Fix links to old commits in merge requests
Diffstat (limited to 'app/models/diff_discussion.rb')
-rw-r--r-- | app/models/diff_discussion.rb | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/app/models/diff_discussion.rb b/app/models/diff_discussion.rb index d67b16584a4..bd6af622bfb 100644 --- a/app/models/diff_discussion.rb +++ b/app/models/diff_discussion.rb @@ -23,8 +23,13 @@ class DiffDiscussion < Discussion def merge_request_version_params return unless for_merge_request? + version_params = get_params + + return version_params unless on_merge_request_commit? && commit_id + + version_params ||= {} version_params.tap do |params| - params[:commit_id] = commit_id if on_merge_request_commit? + params[:commit_id] = commit_id end end @@ -37,7 +42,7 @@ class DiffDiscussion < Discussion private - def version_params + def get_params return {} if active? noteable.version_params_for(position.diff_refs) |