diff options
author | catatsuy <catatsuy@catatsuy.org> | 2015-06-16 15:22:06 +0300 |
---|---|---|
committer | catatsuy <catatsuy@catatsuy.org> | 2015-07-02 15:28:31 +0300 |
commit | 87ac590078c6c219a8afb6feac6e41d75dca1287 (patch) | |
tree | b99fe75bf39f7d89387fd6711a102dc2231dcd9c /app/models/event.rb | |
parent | 7c42aaa5763e6028e6c004fa7f90a3c9b2d27ccc (diff) |
'created_at DESC' is performed twice
If you are already sorting in descending order in the created_at,
it is run twice when you run the .recent.
It has passed in the string 'created_at DESC'.
Ruby on Rails is directly given to the SQL.
It is a slow query in MySQL.
Diffstat (limited to 'app/models/event.rb')
-rw-r--r-- | app/models/event.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/models/event.rb b/app/models/event.rb index c9a88ffa8e0..78f16c6304e 100644 --- a/app/models/event.rb +++ b/app/models/event.rb @@ -44,7 +44,7 @@ class Event < ActiveRecord::Base after_create :reset_project_activity # Scopes - scope :recent, -> { order("created_at DESC") } + scope :recent, -> { order(created_at: :desc) } scope :code_push, -> { where(action: PUSHED) } scope :in_projects, ->(project_ids) { where(project_id: project_ids).recent } scope :with_associations, -> { includes(project: :namespace) } |