diff options
author | Douwe Maan <douwe@selenight.nl> | 2016-08-11 06:36:13 +0300 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2016-08-12 23:24:50 +0300 |
commit | cf4cbb018e229b80e8fd0ca427e63f337ef6bdff (patch) | |
tree | 4b58a284e763494bbd4eeeb370ba28de0cecf000 /app/models/merge_request.rb | |
parent | 7927484435a9dc814d3ffa6d9182beac4f672cbd (diff) |
Rename `can_resolve_conflicts_in_ui?` to `conflicts_can_be_resolved_in_ui?`
Diffstat (limited to 'app/models/merge_request.rb')
-rw-r--r-- | app/models/merge_request.rb | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb index 630d31a5d5c..b41d3b6891a 100644 --- a/app/models/merge_request.rb +++ b/app/models/merge_request.rb @@ -720,14 +720,16 @@ class MergeRequest < ActiveRecord::Base @conflicts ||= Gitlab::Conflict::FileCollection.new(self) end - def can_resolve_conflicts_in_ui? - return false unless cannot_be_merged? - return false unless has_complete_diff_refs? + def conflicts_can_be_resolved_in_ui? + return @conflicts_can_be_resolved_in_ui if defined?(@conflicts_can_be_resolved_in_ui) + + return @conflicts_can_be_resolved_in_ui = false unless cannot_be_merged? + return @conflicts_can_be_resolved_in_ui = false unless has_complete_diff_refs? begin - conflicts.files.each(&:lines) + @conflicts_can_be_resolved_in_ui = conflicts.files.each(&:lines) rescue Gitlab::Conflict::Parser::ParserError, Gitlab::Conflict::FileCollection::ConflictSideMissing - false + @conflicts_can_be_resolved_in_ui = false end end end |