diff options
author | Robert Speicher <rspeicher@gmail.com> | 2012-08-25 21:54:38 +0400 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2012-08-25 22:19:16 +0400 |
commit | 580ce4f2d85f89e81825c3b5993fd3ee68f4d93a (patch) | |
tree | 3dd334a9c5d401eceb88092fa18cc4fb272cf1ac /app/models/milestone.rb | |
parent | 232389f4e8ebaffd125985ce63439cea407e85d5 (diff) |
Minor cleanup to Milestone model and spec
Back-ported from my still-in-progress major cleanup.
Diffstat (limited to 'app/models/milestone.rb')
-rw-r--r-- | app/models/milestone.rb | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/app/models/milestone.rb b/app/models/milestone.rb index 592c57f948c..d416fb630c5 100644 --- a/app/models/milestone.rb +++ b/app/models/milestone.rb @@ -28,17 +28,9 @@ class Milestone < ActiveRecord::Base end def percent_complete - @percent_complete ||= begin - total_i = self.issues.count - closed_i = self.issues.closed.count - if total_i > 0 - (closed_i * 100) / total_i - else - 100 - end - rescue => ex - 0 - end + ((self.issues.closed.count * 100) / self.issues.count).abs + rescue ZeroDivisionError + 100 end def expires_at |