Fix dir_exists?

1 files changed, 8 insertions, 3 deletions

diff --git a/app/models/namespace.rb b/app/models/namespace.rb
index d9c45cb13e2..d34e5a99c79 100644
--- a/app/models/namespace.rb
+++ b/app/models/namespace.rb
@@ -51,12 +51,17 @@ class Namespace < ActiveRecord::Base
   end
 
   def ensure_dir_exist
-    dir_exists? || system("mkdir -m 770 #{namespace_dir_path}")
+    unless dir_exists?
+      system("mkdir -m 770 #{namespace_full_path}")
+    end
   end
 
   def dir_exists?
-    namespace_dir_path = File.join(Gitlab.config.gitolite.repos_path, path)
-    File.exists?(namespace_dir_path)
+    File.exists?(namespace_full_path)
+  end
+
+  def namespace_full_path
+    @namespace_full_path ||= File.join(Gitlab.config.gitolite.repos_path, path)
   end
 
   def move_dir