Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouwe Maan <douwe@selenight.nl>2017-05-18 23:49:38 +0300
committerDouwe Maan <douwe@selenight.nl>2017-05-18 23:49:38 +0300
commitb8ca5c784ca8c5eea886f04c0b03cdac729bae9c (patch)
treea089ad9ca85115f8a33b06ae79386e1c0eb72f08 /app/models
parent3114147b0e72c35abd48110bc17fe1c8be5ab396 (diff)
Stop MR conflict code from blowing up when branches are missing
Diffstat (limited to 'app/models')
-rw-r--r--app/models/merge_request.rb3
1 files changed, 3 insertions, 0 deletions
diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb
index 1b6904aa077..e88a86ea0f0 100644
--- a/app/models/merge_request.rb
+++ b/app/models/merge_request.rb
@@ -299,6 +299,8 @@ class MergeRequest < ActiveRecord::Base
attr_writer :target_branch_sha, :source_branch_sha
def source_branch_head
+ return unless source_project
+
source_branch_ref = @source_branch_sha || source_branch
source_project.repository.commit(source_branch_ref) if source_branch_ref
end
@@ -919,6 +921,7 @@ class MergeRequest < ActiveRecord::Base
return @conflicts_can_be_resolved_in_ui = false unless cannot_be_merged?
return @conflicts_can_be_resolved_in_ui = false unless has_complete_diff_refs?
+ return @conflicts_can_be_resolved_in_ui = false if branch_missing?
begin
# Try to parse each conflict. If the MR's mergeable status hasn't been updated,