diff options
author | Bob Van Landuyt <bob@vanlanduyt.co> | 2017-10-05 11:38:05 +0300 |
---|---|---|
committer | Bob Van Landuyt <bob@vanlanduyt.co> | 2017-10-05 14:12:40 +0300 |
commit | e013d39875bbf5f6e11fda627a8dab045023d59e (patch) | |
tree | 0d671d2a4c1e9600eea6f86fb046296bbb6dd218 /app/serializers/group_child_entity.rb | |
parent | 951abe2b2efc3a208ceea46d9c1c47d3d253ff63 (diff) |
Optimize finding a membership for a user to avoid extra queries
Diffstat (limited to 'app/serializers/group_child_entity.rb')
-rw-r--r-- | app/serializers/group_child_entity.rb | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/app/serializers/group_child_entity.rb b/app/serializers/group_child_entity.rb index 6cfdd93e9bb..b602a17156f 100644 --- a/app/serializers/group_child_entity.rb +++ b/app/serializers/group_child_entity.rb @@ -40,9 +40,7 @@ class GroupChildEntity < Grape::Entity end def permission - return unless request&.current_user - - request.current_user.members.find_by(source: object)&.human_access + membership&.human_access end # Project only attributes @@ -55,11 +53,11 @@ class GroupChildEntity < Grape::Entity unless: lambda { |_instance, _options| project? } def leave_path - leave_group_group_members_path(object) + leave_group_members_path(object) end def can_leave - if membership = object.members_and_requesters.find_by(user: request.current_user) + if membership can?(request.current_user, :destroy_group_member, membership) else false @@ -73,4 +71,12 @@ class GroupChildEntity < Grape::Entity def number_users_with_delimiter number_with_delimiter(object.member_count) end + + private + + def membership + return unless request.current_user + + @membership ||= request.current_user.membership_for_object(object) + end end |