diff options
| author | Bob Van Landuyt <bob@vanlanduyt.co> | 2018-06-18 11:31:41 +0300 |
|---|---|---|
| committer | Bob Van Landuyt <bob@vanlanduyt.co> | 2018-06-20 19:13:13 +0300 |
| commit | f3f1df1476ba7fe223e5d8d6707a7675dc9fa597 (patch) | |
| tree | b821f022ed4fd4201a3b86888f0d4a65b60d0411 /app/services/concerns | |
| parent | 03b88937757238c26a0bd2f3446dde03e7041b36 (diff) | |
Add a cop for `FinderMethods`
This notifies developers when calling `find(_by!)` chained on
`execute`. And suggests using the methods from `FinderMethods`. These
will perform the correct authorization checks on the resource when it
is found.
Diffstat (limited to 'app/services/concerns')
| -rw-r--r-- | app/services/concerns/issues/resolve_discussions.rb | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/app/services/concerns/issues/resolve_discussions.rb b/app/services/concerns/issues/resolve_discussions.rb index 26eb274f4d5..455f761ca9b 100644 --- a/app/services/concerns/issues/resolve_discussions.rb +++ b/app/services/concerns/issues/resolve_discussions.rb @@ -14,7 +14,6 @@ module Issues def merge_request_to_resolve_discussions_of strong_memoize(:merge_request_to_resolve_discussions_of) do MergeRequestsFinder.new(current_user, project_id: project.id) - .execute .find_by(iid: merge_request_to_resolve_discussions_of_iid) end end |