diff options
author | Timothy Andrew <mail@timothyandrew.net> | 2016-09-20 12:36:54 +0300 |
---|---|---|
committer | Timothy Andrew <mail@timothyandrew.net> | 2016-09-20 13:35:25 +0300 |
commit | 8957293d9bd0d711db3af26182205c2fe4125194 (patch) | |
tree | dcdd25393e2d6248971fddbd6c9eac30fe27ff6e /app/services/create_deployment_service.rb | |
parent | fa890604aaf15b9e4f0199e6a4cff24c29955a37 (diff) |
Implement review comments from @yorickpeterse
1. Change multiple updates to a single `update_all`
2. Use cascading deletes
3. Extract an average function for the database median.
4. Move database median to `lib/gitlab/database`
5. Use `delete_all` instead of `destroy_all`
6. Minor refactoring
Diffstat (limited to 'app/services/create_deployment_service.rb')
-rw-r--r-- | app/services/create_deployment_service.rb | 28 |
1 files changed, 1 insertions, 27 deletions
diff --git a/app/services/create_deployment_service.rb b/app/services/create_deployment_service.rb index aad5cc8a15b..e958e91d612 100644 --- a/app/services/create_deployment_service.rb +++ b/app/services/create_deployment_service.rb @@ -13,39 +13,13 @@ class CreateDeploymentService < BaseService deployable: deployable ) - update_merge_request_metrics(deployment, environment) + deployment.update_merge_request_metrics deployment end private - def update_merge_request_metrics(deployment, environment) - if environment.name == "production" - query = project.merge_requests.joins("LEFT OUTER JOIN merge_request_metrics ON merge_request_metrics.merge_request_id = merge_requests.id"). - where(target_branch: params[:ref], "merge_request_metrics.first_deployed_to_production_at" => nil) - - previous_deployment = previous_deployment_for_ref(deployment) - merge_requests_deployed_to_production_for_first_time = if previous_deployment - query.where("merge_request_metrics.merged_at < ? AND merge_request_metrics.merged_at > ?", deployment.created_at, previous_deployment.created_at) - else - query.where("merge_request_metrics.merged_at < ?", deployment.created_at) - end - - merge_requests_deployed_to_production_for_first_time.each { |merge_request| merge_request.metrics.record_production_deploy!(deployment.created_at) } - end - end - - def previous_deployment_for_ref(current_deployment) - @previous_deployment_for_ref ||= - project.deployments.joins(:environment). - where("environments.name": params[:environment], ref: params[:ref]). - where.not(id: current_deployment.id). - first - end - - private - def find_or_create_environment project.environments.find_or_create_by(name: expanded_name) do |environment| environment.external_url = expanded_url |