Improve design after review

1 files changed, 4 insertions, 16 deletions

diff --git a/app/services/create_deployment_service.rb b/app/services/create_deployment_service.rb
index eec1773073e..efeb9df9527 100644
--- a/app/services/create_deployment_service.rb
+++ b/app/services/create_deployment_service.rb
@@ -2,7 +2,9 @@ require_relative 'base_service'
 
 class CreateDeploymentService < BaseService
   def execute(deployable = nil)
-    environment = create_or_find_environment(params[:environment])
+    environment = project.environments.find_or_create_by(
+      name: params[:environment]
+    )
 
     project.deployments.create(
       environment: environment,
@@ -10,21 +12,7 @@ class CreateDeploymentService < BaseService
       tag: params[:tag],
       sha: params[:sha],
       user: current_user,
-      deployable: deployable,
+      deployable: deployable
     )
   end
-
-  private
-
-  def create_or_find_environment(environment)
-    find_environment(environment) || create_environment(environment)
-  end
-
-  def create_environment(environment)
-    project.environments.create(name: environment)
-  end
-
-  def find_environment(environment)
-    project.environments.find_by(name: environment)
-  end
 end