diff options
| author | James Edwards-Jones <jedwardsjones@gitlab.com> | 2017-04-03 19:10:58 +0300 |
|---|---|---|
| committer | James Edwards-Jones <jedwardsjones@gitlab.com> | 2017-04-03 19:19:53 +0300 |
| commit | b8c7bef5c092152ea85d1840e587cfc04293e1d7 (patch) | |
| tree | 51338a1599fa24d4e42c4eb7b6c02ac91555a73c /app/services/git_push_service.rb | |
| parent | 65f3d5062f081d8f8ebf727a3408650d90ec9711 (diff) | |
Extracted ProtectableDropdown to clean up Project#open_branches
Makes it clear this is only used in dropdowns, instead of cluttering up Project class. Since we only care about branch names, it is also possible to refactor out a lot of the set/reject logic.
A benchmark on Array/Set subtraction favoured using Arrays. This was with 5000 ‘branches’ and 2000 ‘protections’ to ensure a similar comparison to the commit which introduced using Set for intersection.
Comparison:
array subtraction: 485.8 i/s
set subtraction: 128.7 i/s - 3.78x slower
Diffstat (limited to 'app/services/git_push_service.rb')
0 files changed, 0 insertions, 0 deletions