diff options
author | Sean McGivern <sean@gitlab.com> | 2016-05-02 19:36:25 +0300 |
---|---|---|
committer | Alfredo Sumaran <alfredo@gitlab.com> | 2016-06-04 01:14:23 +0300 |
commit | 0fcf6e109454e3a3ac6b8179ca241bad58975136 (patch) | |
tree | 39b80faa1ee62f35b0e26018927235d422a01fa5 /app/services/issuable_base_service.rb | |
parent | ac40843c94f369cad07f98a2403cd06db041f986 (diff) |
Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
of an array, as that's how they're passed by the front-end. (The
deprecation warning is for passing a nested array, which is what
happens if an actual array is passed, as:
`[1, 2, 3].split(',') == [[1, 2, 3]]`
Diffstat (limited to 'app/services/issuable_base_service.rb')
0 files changed, 0 insertions, 0 deletions