diff options
| author | Toon Claes <toon@gitlab.com> | 2017-04-21 12:36:34 +0300 |
|---|---|---|
| committer | Toon Claes <toon@gitlab.com> | 2017-04-27 10:57:09 +0300 |
| commit | a204d14c672e08a825479511473ba3999ed08434 (patch) | |
| tree | 05018866869b1119b38c71a668503e91797a733b /app/services/issuable_base_service.rb | |
| parent | d031665a634e5d6fef980e837d6b227097850178 (diff) | |
Avoid plucking Todo ids and use sub-queries instead
TodoService should not call `.select(&:id)` on todos, because this is
bad performance. So instead use sub-queries, which will result in a
single SQL query to the database.
https://docs.gitlab.com/ee/development/sql.html#plucking-ids
Diffstat (limited to 'app/services/issuable_base_service.rb')
| -rw-r--r-- | app/services/issuable_base_service.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/issuable_base_service.rb b/app/services/issuable_base_service.rb index b071a398481..17cb71be5f6 100644 --- a/app/services/issuable_base_service.rb +++ b/app/services/issuable_base_service.rb @@ -260,7 +260,7 @@ class IssuableBaseService < BaseService todo_service.mark_todo(issuable, current_user) when 'done' todo = TodosFinder.new(current_user).execute.find_by(target: issuable) - todo_service.mark_todos_as_done([todo], current_user) if todo + todo_service.mark_todos_as_done_by_ids(todo, current_user) if todo end end |