diff options
| author | Rémy Coutable <remy@rymai.me> | 2017-11-21 20:13:07 +0300 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2017-11-24 15:08:25 +0300 |
| commit | ba62143ac34de6cf96da4a19b498b220f7e5154b (patch) | |
| tree | dd2aaad55176397c82c8fe9498cf9d98ae868092 /app/services/issues/base_service.rb | |
| parent | 7c1e54d58d7ee0308b865d9563f1dfeb54568e16 (diff) | |
Refactor the way we pass `old associations` to issuable's update services
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'app/services/issues/base_service.rb')
| -rw-r--r-- | app/services/issues/base_service.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/app/services/issues/base_service.rb b/app/services/issues/base_service.rb index 0f711bcc3cf..9f6cfc0f6d3 100644 --- a/app/services/issues/base_service.rb +++ b/app/services/issues/base_service.rb @@ -1,7 +1,7 @@ module Issues class BaseService < ::IssuableBaseService - def hook_data(issue, action, old_labels: [], old_assignees: [], old_total_time_spent: nil) - hook_data = issue.to_hook_data(current_user, old_labels: old_labels, old_assignees: old_assignees, old_total_time_spent: old_total_time_spent) + def hook_data(issue, action, old_associations: {}) + hook_data = issue.to_hook_data(current_user, old_associations: old_associations) hook_data[:object_attributes][:action] = action hook_data @@ -22,8 +22,8 @@ module Issues issue, issue.project, current_user, old_assignees) end - def execute_hooks(issue, action = 'open', old_labels: [], old_assignees: [], old_total_time_spent: nil) - issue_data = hook_data(issue, action, old_labels: old_labels, old_assignees: old_assignees, old_total_time_spent: old_total_time_spent) + def execute_hooks(issue, action = 'open', old_associations: {}) + issue_data = hook_data(issue, action, old_associations: old_associations) hooks_scope = issue.confidential? ? :confidential_issue_hooks : :issue_hooks issue.project.execute_hooks(issue_data, hooks_scope) issue.project.execute_services(issue_data, hooks_scope) |