diff options
author | Robert Speicher <robert@gitlab.com> | 2016-08-12 21:04:03 +0300 |
---|---|---|
committer | Robert Speicher <robert@gitlab.com> | 2016-08-12 21:04:03 +0300 |
commit | 11eefba891f214eefc1efa334adbcc9e979c0ce3 (patch) | |
tree | 69dc1a835658ba03d05264aee00207e67c178658 /app/services/issues | |
parent | 7b63f8289c5e9a811215a3b26ccd5e0e793a9653 (diff) | |
parent | cb8a425ba42e9be23b8712ed29b1db2dcc6bd139 (diff) |
Merge branch 'fix-namespace-deletion' into 'master'
Fix bug where destroying a namespace would not always destroy projects
There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
1. User attempts to delete group
2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
4. Projects::DestroyService runs later but the can?(current_user,
:remove_project) is `false` because the user no longer has permission to
destroy projects with no namespace.
5. This leaves the project in pending_delete state with no namespace/group.
Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since `container_registry_path_with_namespace` is the wrong value.
The fix is to destroy the group asynchronously and run `execute` directly on Projects::DestroyService.
Closes #17893
See merge request !4341
Diffstat (limited to 'app/services/issues')
0 files changed, 0 insertions, 0 deletions