Create a "destroyed Milestone" event and keep Milestone events around in the DB

for posterity.

Also fix issue where destroying a Milestone would cause odd, transient messages like
"created milestone" or "imported milestone".

Add "in" preposition when creating and destroying milestones

Closes #2382

1 files changed, 22 insertions, 0 deletions

diff --git a/app/services/milestones/destroy_service.rb b/app/services/milestones/destroy_service.rb
new file mode 100644
index 00000000000..7ce7d259d0b
--- /dev/null
+++ b/app/services/milestones/destroy_service.rb
@@ -0,0 +1,22 @@
+module Milestones
+  class DestroyService < Milestones::BaseService
+    def execute(milestone)
+
+      Milestone.transaction do
+        update_params = { milestone: nil }
+        milestone.issues.each do |issue|
+          Issues::UpdateService.new(project, current_user, update_params).execute(issue)
+        end
+
+        event_service.destroy_milestone(milestone, current_user)
+
+        Event.for_milestone_id(milestone.id).each do |event|
+          event.target_id = nil
+          event.save
+        end
+
+        milestone.destroy
+      end
+    end
+  end
+end