diff options
| author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-07-07 09:08:12 +0300 |
|---|---|---|
| committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-07-07 09:08:12 +0300 |
| commit | de073cf5ac7cea0ea0dc44c22f195dfad1581569 (patch) | |
| tree | b96e4141cc822c92bf5d1f74a423159bfa982100 /app/services/projects | |
| parent | 52a583c120686329d931e99035756996264a26c3 (diff) | |
| parent | 3baed8cb6ddf9d46b653f17135cbffc8e662cedd (diff) | |
Merge branch 'services_refactoring1' into 'master'
Services: code style fixes, minor refactoring
## What does this MR do?
It contains code style fixes, minor refactoring and also it removes some unnecessary comments. Every comment require a support just like a regular code line and this is why we should avoid using comments everywhere unless it's really helpful. Martin Fowler said "Find comment and refactor the code around it" :) our code is not that bad so let's not spoil it with comments.
## Why was this MR needed?
Because GitLab is a live example of awesome code. Let's keep up a good job :)
See merge request !5112
Diffstat (limited to 'app/services/projects')
| -rw-r--r-- | app/services/projects/update_service.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/app/services/projects/update_service.rb b/app/services/projects/update_service.rb index 941df08995c..f06311511cc 100644 --- a/app/services/projects/update_service.rb +++ b/app/services/projects/update_service.rb @@ -3,10 +3,11 @@ module Projects def execute # check that user is allowed to set specified visibility_level new_visibility = params[:visibility_level] + if new_visibility && new_visibility.to_i != project.visibility_level unless can?(current_user, :change_visibility_level, project) && Gitlab::VisibilityLevel.allowed_for?(current_user, new_visibility) - + deny_visibility_level(project, new_visibility) return project end |