diff options
| author | Stan Hu <stanhu@gmail.com> | 2017-04-01 02:59:46 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2017-04-02 15:37:04 +0300 |
| commit | 8a71d40e60c799f969af0ed255e931b6c9907634 (patch) | |
| tree | 2737ce98e11f3c8c612d5fa6266232757cc194c0 /app/services/users | |
| parent | 9fc17f6f4abdb04f3cf1b60b87bd67b894a19c39 (diff) | |
Fix race condition where a namespace would be deleted before a project was deleted
When deleting a user, the following sequence could happen:
1. Project `mygroup/myproject` is scheduled for deletion
2. The group `mygroup` is deleted
3. Sidekiq worker runs to delete `mygroup/myproject`, but the namespace and routes have
been destroyed.
Closes #30334
Diffstat (limited to 'app/services/users')
| -rw-r--r-- | app/services/users/destroy_service.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/app/services/users/destroy_service.rb b/app/services/users/destroy_service.rb index 833da5bc5d1..a3b32a71a64 100644 --- a/app/services/users/destroy_service.rb +++ b/app/services/users/destroy_service.rb @@ -20,10 +20,10 @@ module Users Groups::DestroyService.new(group, current_user).execute end - user.personal_projects.each do |project| + user.personal_projects.with_deleted.each do |project| # Skip repository removal because we remove directory with namespace # that contain all this repositories - ::Projects::DestroyService.new(project, current_user, skip_repo: true).async_execute + ::Projects::DestroyService.new(project, current_user, skip_repo: true).execute end move_issues_to_ghost_user(user) |