diff options
author | Kamil TrzciĆski <ayufan@ayufan.eu> | 2018-04-06 01:07:36 +0300 |
---|---|---|
committer | Mayra Cabrera <mcabrera@gitlab.com> | 2018-04-07 05:20:16 +0300 |
commit | 2c6c61815edada16c4477c938209c24c647e1798 (patch) | |
tree | 1d896b8ac1c5160b33116bc6d60e785df51cce79 /app/services | |
parent | 6b2954ec8a2e17c913872c32386cb2b08f2db1c2 (diff) |
Get rid of Redis when dealing with deploy tokens
We use controller actions to pass a newly created token and errors
Diffstat (limited to 'app/services')
-rw-r--r-- | app/services/deploy_tokens/create_service.rb | 31 |
1 files changed, 1 insertions, 30 deletions
diff --git a/app/services/deploy_tokens/create_service.rb b/app/services/deploy_tokens/create_service.rb index 0555d62540c..a5d31dd9fa5 100644 --- a/app/services/deploy_tokens/create_service.rb +++ b/app/services/deploy_tokens/create_service.rb @@ -1,36 +1,7 @@ module DeployTokens class CreateService < BaseService def execute - @project.deploy_tokens.build.tap do |deploy_token| - deploy_token.attributes = params - deploy_token.save - store_deploy_token_info_in_redis(deploy_token) - end - end - - private - - def store_deploy_token_info_in_redis(deploy_token) - deploy_token_key = DeployToken.redis_shared_state_key(current_user.id) - - if deploy_token.persisted? - store_in_redis(deploy_token_key, deploy_token.token) - else - store_deploy_attributes(deploy_token_key, deploy_token) - end - end - - def store_deploy_attributes(deploy_token_key, deploy_token) - attributes = deploy_token.attributes.slice("name", "expires_at") - deploy_token_attributes_key = deploy_token_key + ":attributes" - - store_in_redis(deploy_token_attributes_key, attributes.to_json) - end - - def store_in_redis(key, value) - Gitlab::Redis::SharedState.with do |redis| - redis.set(key, value, ex: 3.minutes) - end + @project.deploy_tokens.build(params).tap(&:save) end end end |