diff options
author | Robert Speicher <robert@gitlab.com> | 2017-08-16 21:34:55 +0300 |
---|---|---|
committer | Robert Speicher <robert@gitlab.com> | 2017-08-16 21:34:55 +0300 |
commit | ec34b2d051c16a351387fbaedb5542654810b8a5 (patch) | |
tree | e08e965390b86e187321d83957c99a45190a698a /app/services | |
parent | 72d5165bd57472692c77d6a9d159e65058513bf3 (diff) | |
parent | ba7251fefd92b0ecb6365cfe55510e24c5343ac6 (diff) |
Merge branch 'dm-gpg-signature-performance' into 'master'
Only create commit GPG signature when necessary
See merge request !13561
Diffstat (limited to 'app/services')
-rw-r--r-- | app/services/git_push_service.rb | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/app/services/git_push_service.rb b/app/services/git_push_service.rb index ada2b64a3a6..e81a56672e2 100644 --- a/app/services/git_push_service.rb +++ b/app/services/git_push_service.rb @@ -90,8 +90,19 @@ class GitPushService < BaseService end def update_signatures - @push_commits.each do |commit| - CreateGpgSignatureWorker.perform_async(commit.sha, @project.id) + commit_shas = @push_commits.last(PROCESS_COMMIT_LIMIT).map(&:sha) + + return if commit_shas.empty? + + shas_with_cached_signatures = GpgSignature.where(commit_sha: commit_shas).pluck(:commit_sha) + commit_shas -= shas_with_cached_signatures + + return if commit_shas.empty? + + commit_shas = Gitlab::Git::Commit.shas_with_signatures(project.repository, commit_shas) + + commit_shas.each do |sha| + CreateGpgSignatureWorker.perform_async(sha, project.id) end end |