diff options
| author | Heinrich Lee Yu <heinrich@gitlab.com> | 2019-08-15 09:27:55 +0300 |
|---|---|---|
| committer | Heinrich Lee Yu <heinrich@gitlab.com> | 2019-08-19 05:09:42 +0300 |
| commit | 5088e316d25fc2a7d61a253e467d551e4888628e (patch) | |
| tree | a05db53104d77c3f51d3d230f81a0dd66e63cfa1 /app/views/shared/members | |
| parent | 0a33c2fb557d97266809296fa82d4293cf46bebc (diff) | |
Replace inline scripts in links to prevent default
Use buttons instead of links with javascript:void(0)
Diffstat (limited to 'app/views/shared/members')
| -rw-r--r-- | app/views/shared/members/_group.html.haml | 2 | ||||
| -rw-r--r-- | app/views/shared/members/_member.html.haml | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/app/views/shared/members/_group.html.haml b/app/views/shared/members/_group.html.haml index e83ca5eaab8..42a823e3a8d 100644 --- a/app/views/shared/members/_group.html.haml +++ b/app/views/shared/members/_group.html.haml @@ -32,7 +32,7 @@ %ul - Gitlab::Access.options.each do |role, role_id| %li - = link_to role, "javascript:void(0)", + = link_to role, '#', class: ("is-active" if group_link.group_access == role_id), data: { id: role_id, el_id: dom_id } .clearable-input.member-form-control.d-sm-inline-block diff --git a/app/views/shared/members/_member.html.haml b/app/views/shared/members/_member.html.haml index 331283f7eec..6762f211a80 100644 --- a/app/views/shared/members/_member.html.haml +++ b/app/views/shared/members/_member.html.haml @@ -82,7 +82,7 @@ %ul - member.valid_level_roles.each do |role, role_id| %li - = link_to role, "javascript:void(0)", + = link_to role, '#', class: ("is-active" if member.access_level == role_id), data: { id: role_id, el_id: dom_id(member) } = render_if_exists 'shared/members/ee/revert_ldap_group_sync_option', |