diff options
| author | 🙈 jacopo beschi 🙉 <intrip@gmail.com> | 2018-04-18 12:19:40 +0300 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-04-18 12:19:40 +0300 |
| commit | c6b1043e9d1b7fe9912c330b6e7d4342f2a9694e (patch) | |
| tree | 45c3fd39c83122eb602f217501924bc8d6899987 /app/workers | |
| parent | 3529ccae9e3a484da5a4fba32bfdf0317f289363 (diff) | |
Resolve "Make a Rubocop that forbids returning from a block"
Diffstat (limited to 'app/workers')
| -rw-r--r-- | app/workers/post_receive.rb | 2 | ||||
| -rw-r--r-- | app/workers/stuck_ci_jobs_worker.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/app/workers/post_receive.rb b/app/workers/post_receive.rb index 3909dbf7d7f..f88b3fdbfb1 100644 --- a/app/workers/post_receive.rb +++ b/app/workers/post_receive.rb @@ -33,7 +33,7 @@ class PostReceive unless @user log("Triggered hook for non-existing user \"#{post_received.identifier}\"") - return false + return false # rubocop:disable Cop/AvoidReturnFromBlocks end if Gitlab::Git.tag_ref?(ref) diff --git a/app/workers/stuck_ci_jobs_worker.rb b/app/workers/stuck_ci_jobs_worker.rb index fb26fa4c515..7ebf69bdc39 100644 --- a/app/workers/stuck_ci_jobs_worker.rb +++ b/app/workers/stuck_ci_jobs_worker.rb @@ -38,7 +38,7 @@ class StuckCiJobsWorker def drop_stuck(status, timeout) search(status, timeout) do |build| - return unless build.stuck? + break unless build.stuck? drop_build :stuck, build, status, timeout end |