Add factory for parsers. Add required specification in json schema matcher. Improved test code.

1 files changed, 1 insertions, 6 deletions

diff --git a/app/models/ci/build.rb b/app/models/ci/build.rb
index 59d533bd4d5..faa27216f28 100644
--- a/app/models/ci/build.rb
+++ b/app/models/ci/build.rb
@@ -635,7 +635,7 @@ module Ci
     def collect_test_reports!(test_reports)
       test_reports.get_suite(group_name).tap do |test_suite|
         each_test_report do |file_type, blob|
-          parse_test_report!(test_suite, file_type, blob)
+          Gitlab::Ci::Parsers.fabricate!(file_type).parse!(blob, test_suite)
         end
       end
     end
@@ -650,11 +650,6 @@ module Ci
       end
     end
 
-    def parse_test_report!(test_suite, file_type, blob)
-      "Gitlab::Ci::Parsers::#{file_type.capitalize}Parser".constantize
-        .new(blob).parse!(test_suite)
-    end
-
     def update_artifacts_size
       self.artifacts_size = legacy_artifacts_file&.size
     end