diff options
| author | Arun Kumar Mohan <arunmohandm@gmail.com> | 2019-08-28 13:20:30 +0300 |
|---|---|---|
| committer | Arun Kumar Mohan <arunmohandm@gmail.com> | 2019-08-31 01:08:16 +0300 |
| commit | 9575288f6259e37726c61451478b9c7d5a73b843 (patch) | |
| tree | df4183f84bcafb9b1353865ceaeae0cf5a9ce845 /app | |
| parent | c0ff11820228acbc27369e99db9bbf9a80a8405b (diff) | |
Refactor showStagedIcon property's behavior to match its name
Previously, the `showStagedIcon` property was doing the opposite
of what its name suggested. It was rendering the staged icon when
`showStagedIcon` was `false` and rendering the regular icon when
it was `true`.
Diffstat (limited to 'app')
| -rw-r--r-- | app/assets/javascripts/ide/components/file_row_extra.vue | 2 | ||||
| -rw-r--r-- | app/assets/javascripts/vue_shared/components/changed_file_icon.vue | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/app/assets/javascripts/ide/components/file_row_extra.vue b/app/assets/javascripts/ide/components/file_row_extra.vue index 7254c50a568..48be97c8952 100644 --- a/app/assets/javascripts/ide/components/file_row_extra.vue +++ b/app/assets/javascripts/ide/components/file_row_extra.vue @@ -86,7 +86,7 @@ export default { v-else-if="showChangedFileIcon" :file="file" :show-tooltip="true" - :show-staged-icon="true" + :show-staged-icon="false" /> <new-dropdown :type="file.type" diff --git a/app/assets/javascripts/vue_shared/components/changed_file_icon.vue b/app/assets/javascripts/vue_shared/components/changed_file_icon.vue index beb2ac09992..a97538d813a 100644 --- a/app/assets/javascripts/vue_shared/components/changed_file_icon.vue +++ b/app/assets/javascripts/vue_shared/components/changed_file_icon.vue @@ -24,7 +24,7 @@ export default { showStagedIcon: { type: Boolean, required: false, - default: false, + default: true, }, size: { type: Number, @@ -41,7 +41,7 @@ export default { changedIcon() { // False positive i18n lint: https://gitlab.com/gitlab-org/frontend/eslint-plugin-i18n/issues/26 // eslint-disable-next-line @gitlab/i18n/no-non-i18n-strings - const suffix = !this.file.changed && this.file.staged && !this.showStagedIcon ? '-solid' : ''; + const suffix = !this.file.changed && this.file.staged && this.showStagedIcon ? '-solid' : ''; return `${getCommitIconMap(this.file).icon}${suffix}`; }, |