diff options
| author | Robert Speicher <rspeicher@gmail.com> | 2018-12-14 20:49:58 +0300 |
|---|---|---|
| committer | Robert Speicher <rspeicher@gmail.com> | 2018-12-14 23:02:51 +0300 |
| commit | fac5c0e7ddf487b620aa338f439a63931bddbfa2 (patch) | |
| tree | 02f4e76336e3ea20771b75c0556f2e724c2e1b87 /app | |
| parent | 04a3e48c2a0e31e31f8ba0e9036597428ee3a373 (diff) | |
Resolve transient failure in Help page spec
Sometimes due to a slow request to load the version check image, the
placeholder image data was still being seen, resulting in this failure:
expected "data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" to end with "/version-check-url"
Now we check the `data-src` attribute, which allows us to remove the
`:js` metadata.
This commit also removes a redundant test, which was just ensuring that
the selector we were already using in the other test is visible. If this
test were failing, the other one would always fail too, so it was
pointless.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55372
Diffstat (limited to 'app')
0 files changed, 0 insertions, 0 deletions