diff options
| author | Mark Fletcher <mark@gitlab.com> | 2016-09-12 22:14:26 +0300 |
|---|---|---|
| committer | Mark Fletcher <mark@gitlab.com> | 2016-09-19 11:29:12 +0300 |
| commit | 58d02520b037255f9948de4386ab6cd970586445 (patch) | |
| tree | c62987e9112f8ef40cb9772e72e73fd6b6a7f528 /app | |
| parent | 62516461d695c1e684529ab1fa807b86fb7f2ab2 (diff) | |
Ensure validation messages are shown within the milestone form
* Remove call to Milestone#save! instead just Milestone#save
* Add safety specs to stop a regression
Fixes #22033
Diffstat (limited to 'app')
| -rw-r--r-- | app/services/milestones/create_service.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/milestones/create_service.rb b/app/services/milestones/create_service.rb index 3b90399af64..b8e08c9f1eb 100644 --- a/app/services/milestones/create_service.rb +++ b/app/services/milestones/create_service.rb @@ -3,7 +3,7 @@ module Milestones def execute milestone = project.milestones.new(params) - if milestone.save! + if milestone.save event_service.open_milestone(milestone, current_user) end |