diff options
author | Fatih Acet <acetfatih@gmail.com> | 2016-09-02 23:30:22 +0300 |
---|---|---|
committer | Ruben Davila <rdavila84@gmail.com> | 2016-09-06 03:05:39 +0300 |
commit | 96342b8a382235571e0f2d5eee13d39be2ad0f82 (patch) | |
tree | e4f0581287674be73a621090c471498f0b4e89e8 /app | |
parent | 1c01dbda14ef94595f02681137cc9544d3be8496 (diff) |
Merge branch 'icon-button-alignment' into 'master'
Fix alignment of icon buttons
## What does this MR do?
Fix misalignment of buttons with only an icon which was introduced by !5451.
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5451#note_14066627
## Screenshots
### Before
![with-text](/uploads/aa7f7a98e2015070689e762e0cf99844/witht-text.png)
![without-text](/uploads/72db7c54e3961fd0df34b0ea79455fd0/without-text.png)
### After
![with-text](/uploads/3f19e55773083bcb22f3909f6dc0d147/witht-text.png)
![without-text](/uploads/b6647d4d71eb5cd9d1712908d2b93665/without-text.png)
See merge request !5887
Diffstat (limited to 'app')
-rw-r--r-- | app/assets/stylesheets/framework/buttons.scss | 4 | ||||
-rw-r--r-- | app/views/projects/buttons/_fork.html.haml | 4 | ||||
-rw-r--r-- | app/views/projects/forks/index.html.haml | 4 |
3 files changed, 7 insertions, 5 deletions
diff --git a/app/assets/stylesheets/framework/buttons.scss b/app/assets/stylesheets/framework/buttons.scss index cd3ddf5fee9..4618687a4be 100644 --- a/app/assets/stylesheets/framework/buttons.scss +++ b/app/assets/stylesheets/framework/buttons.scss @@ -206,7 +206,9 @@ } svg, .fa { - margin-right: 3px; + &:not(:last-child) { + margin-right: 3px; + } } } diff --git a/app/views/projects/buttons/_fork.html.haml b/app/views/projects/buttons/_fork.html.haml index d78888e9fe4..22db33498f1 100644 --- a/app/views/projects/buttons/_fork.html.haml +++ b/app/views/projects/buttons/_fork.html.haml @@ -3,11 +3,11 @@ - if current_user.already_forked?(@project) && current_user.manageable_namespaces.size < 2 = link_to namespace_project_path(current_user, current_user.fork_of(@project)), title: 'Go to your fork', class: 'btn has-tooltip' do = custom_icon('icon_fork') - Fork + %span Fork - else = link_to new_namespace_project_fork_path(@project.namespace, @project), title: "Fork project", class: 'btn has-tooltip' do = custom_icon('icon_fork') - Fork + %span Fork %div.count-with-arrow %span.arrow = link_to namespace_project_forks_path(@project.namespace, @project), class: "count" do diff --git a/app/views/projects/forks/index.html.haml b/app/views/projects/forks/index.html.haml index a1d79bdabda..bacc5708e4b 100644 --- a/app/views/projects/forks/index.html.haml +++ b/app/views/projects/forks/index.html.haml @@ -32,11 +32,11 @@ - if current_user.already_forked?(@project) && current_user.manageable_namespaces.size < 2 = link_to namespace_project_path(current_user, current_user.fork_of(@project)), title: 'Go to your fork', class: 'btn btn-new' do = custom_icon('icon_fork') - Fork + %span Fork - else = link_to new_namespace_project_fork_path(@project.namespace, @project), title: "Fork project", class: 'btn btn-new' do = custom_icon('icon_fork') - Fork + %span Fork = render 'projects', projects: @forks |