diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-07-06 10:58:13 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-07-06 11:07:49 +0300 |
| commit | a28844ea5683d6ae7ae7e37065feee9baa59aeaf (patch) | |
| tree | 3adeaf09fbef16a1296bd522ced0b0a467844ba2 /app | |
| parent | 6e9f882007a18d594b4a53e417a87fdeec3bc29f (diff) | |
Prevent amplification of ReactiveCachingWorker jobs upon failures
When `ReactiveCachingWorker` hits an SSL or other exception that occurs
quickly and reliably, automatically rescheduling a new worker could lead
to excessive number of jobs being scheduled. This happens because not
only does the failed job get rescheduled in a minute, but each Sidekiq
retry will also add even more rescheduled jobs.
In busy instances, this can become an issue because large numbers of
`ReactiveCachingWorker` running can cause high rates of `ExclusiveLease`
reads to occur and possibly saturate the Redis server with queries.
We now disable this automatic retry and rely on Sidekiq to perform its 3
retries with a backoff period.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64176
Diffstat (limited to 'app')
| -rw-r--r-- | app/models/concerns/reactive_caching.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/models/concerns/reactive_caching.rb b/app/models/concerns/reactive_caching.rb index 6c3962b4c4f..5b3880f94ba 100644 --- a/app/models/concerns/reactive_caching.rb +++ b/app/models/concerns/reactive_caching.rb @@ -178,7 +178,7 @@ module ReactiveCaching def enqueuing_update(*args) yield - ensure + ReactiveCachingWorker.perform_in(self.class.reactive_cache_refresh_interval, self.class, id, *args) end end |