Some code improvements

- Use strong_memoize for prometheus_adapter since it can be nil in some
cases.
- Do not phrase spec descriptions with 'should'.

1 files changed, 4 insertions, 1 deletions

diff --git a/app/services/prometheus/proxy_service.rb b/app/services/prometheus/proxy_service.rb
index cadfe59b900..c5d2b84878b 100644
--- a/app/services/prometheus/proxy_service.rb
+++ b/app/services/prometheus/proxy_service.rb
@@ -3,6 +3,7 @@
 module Prometheus
   class ProxyService < BaseService
     include ReactiveCaching
+    include Gitlab::Utils::StrongMemoize
 
     self.reactive_cache_key = ->(service) { service.cache_key }
     self.reactive_cache_lease_timeout = 30.seconds
@@ -91,7 +92,9 @@ module Prometheus
     end
 
     def prometheus_adapter
-      @prometheus_adapter ||= @proxyable.prometheus_adapter
+      strong_memoize(:prometheus_adapter) do
+        @proxyable.prometheus_adapter
+      end
     end
 
     def prometheus_client_wrapper