diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-04-30 03:07:42 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-04-30 07:29:25 +0300 |
| commit | 25818bd7ae765422c934d0a32efb4ba353d11183 (patch) | |
| tree | bbef891f40c54ee59e79fa04f538562bc11c1afb /changelogs/unreleased | |
| parent | 7ae2107d9ebca0adecc8a21cacd1bfb6e89ee3ab (diff) | |
Disable method replacement in avatar loading
We've seen a significant performance penalty when using
`BatchLoader#__replace_with!`. This defines methods on the batch loader
that proxy to the 'real' object using send. The alternative is
`method_missing`, which is slower. However, we've noticed that
`method_missing` can be faster if:
1. The objects being loaded have a large interface.
2. We don't call too many methods on the loaded object.
Avatar uploads meet both criteria above, so let's use the newly-released
feature in https://github.com/exAspArk/batch-loader/pull/45.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60903
Diffstat (limited to 'changelogs/unreleased')
| -rw-r--r-- | changelogs/unreleased/sh-disable-batch-load-replace-methods.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-disable-batch-load-replace-methods.yml b/changelogs/unreleased/sh-disable-batch-load-replace-methods.yml new file mode 100644 index 00000000000..00f897ac4b1 --- /dev/null +++ b/changelogs/unreleased/sh-disable-batch-load-replace-methods.yml @@ -0,0 +1,5 @@ +--- +title: Disable method replacement in avatar loading +merge_request: 27866 +author: +type: performance |