diff options
| author | Andreas Brandl <abrandl@gitlab.com> | 2018-03-02 11:29:12 +0300 |
|---|---|---|
| committer | Andreas Brandl <abrandl@gitlab.com> | 2018-03-02 11:35:21 +0300 |
| commit | 82a32e2763db3196421412a537e9fd344b12c831 (patch) | |
| tree | b041575fb982deb3870cbfa4c440039191f224e7 /changelogs | |
| parent | 82ec8eafab2aa66eaf6fe7c9bc6a25bfbb291596 (diff) | |
Apply query changes to snippets only.
This applies the changes introduced in `Project.public_or_visible_to_user`
to the snippets finder only.
We know that for `SnippetsFinder`, this change improves SQL timing from
5/23/25s to 0.7/2/4s (mean/p95/p99). At the same time, the scope was too
broad, (negatively) affecting SQL timings in various other places:
https://gitlab.com/gitlab-com/infrastructure/issues/3772
With this commit, the snippets dashboard stays usuable as we generally
don't run into statement timeouts. In contrast to the earlier change in
!17088, the scope of the change is limited to `SnippetsFinder` only,
thus not affecting other places.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/revert-project-visibility-changes.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/changelogs/unreleased/revert-project-visibility-changes.yml b/changelogs/unreleased/revert-project-visibility-changes.yml index 86bab00b9b1..df44fdb79b1 100644 --- a/changelogs/unreleased/revert-project-visibility-changes.yml +++ b/changelogs/unreleased/revert-project-visibility-changes.yml @@ -1,5 +1,5 @@ --- -title: Revert Project.public_or_visible_to_user changes +title: Revert Project.public_or_visible_to_user changes and only apply to snippets merge_request: author: type: fixed |