diff options
| author | Sean McGivern <sean@gitlab.com> | 2018-01-15 17:49:27 +0300 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2018-01-16 14:56:07 +0300 |
| commit | 82f4564fb7dc57a9a7bb6a052926ee219bb29b13 (patch) | |
| tree | 47ba9aacaa5ca1be77a97800021d2c3821dd0799 /changelogs | |
| parent | 1df5c74fc94a0fbeb7b89b7e10655626b58a5bc6 (diff) | |
Fix project search results for digits surrounded by colons
A file containing /:\d+:/ in its contents would break the search results if
those contents were part of the results, because we were splitting on colons,
which can't work with untrusted input.
Changing to use the null byte as a separator is much safer.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/41666-cannot-search-with-keyword-merge.yml | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/changelogs/unreleased/41666-cannot-search-with-keyword-merge.yml b/changelogs/unreleased/41666-cannot-search-with-keyword-merge.yml new file mode 100644 index 00000000000..3a6fa425c9c --- /dev/null +++ b/changelogs/unreleased/41666-cannot-search-with-keyword-merge.yml @@ -0,0 +1,6 @@ +--- +title: Fix file search results when they match file contents with a number between + two colons +merge_request: 16462 +author: +type: fixed |