diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-02-23 22:00:38 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-02-24 08:27:53 +0300 |
| commit | ec5bbd27f5b334a6e338574ebafe6b0cd39461bc (patch) | |
| tree | 011d9e65d6d2c26a5538f6d1f1be73eac20ef5bd /changelogs | |
| parent | 7e37b4e4ef2041f5c1818fdbf7de7fee91608595 (diff) | |
Remove duplicate XHR request when requesting new pipeline page
When a user clicked on another page in the pipeline page, the following
would happen:
1. PipelinesService.getPipelines() would be called to fetch the new page
2. In the success handler, Poll.restart() would be called
3. This would invoke Poll.makeRequest(), which would fire off a new
request.
To fix this, we introduce a enable(), which will:
1. Update the request data accordingly
2. Clear the old timeout if necessary and start a new timer
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58095
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-fix-double-xhr-pipelines.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-fix-double-xhr-pipelines.yml b/changelogs/unreleased/sh-fix-double-xhr-pipelines.yml new file mode 100644 index 00000000000..e6c762f1d47 --- /dev/null +++ b/changelogs/unreleased/sh-fix-double-xhr-pipelines.yml @@ -0,0 +1,5 @@ +--- +title: Remove duplicate XHR request when requesting new pipeline page +merge_request: 25506 +author: +type: fixed |