diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-08-25 17:20:17 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-08-26 23:37:42 +0300 |
| commit | 6fa5f510e83a91e19a1601bf6c01a9cffe6fd5c9 (patch) | |
| tree | 8317880ef28f90f0d0688dcc7f925826eca541cd /changelogs | |
| parent | fc08d48cf0a596dc151cb7bc7ab0f7d2721f3333 (diff) | |
Guard against deleted project feature entry
In https://gitlab.com/gitlab-org/gitlab-ce/issues/66482, we see that a
project's `project_feature` association may be lazily loaded and hence
return `nil` if the entry is deleted if the `Project` is already loaded
in memory. To ensure we don't fail hard when this happens, assume all
features are disabled.
We can fix this issue by eager loading the `project_feature` in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32169, but we
shouldn't have to depend on that.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-guard-against-orphaned-project-feature.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-guard-against-orphaned-project-feature.yml b/changelogs/unreleased/sh-guard-against-orphaned-project-feature.yml new file mode 100644 index 00000000000..99c8732c5b0 --- /dev/null +++ b/changelogs/unreleased/sh-guard-against-orphaned-project-feature.yml @@ -0,0 +1,5 @@ +--- +title: Guard against deleted project feature entry in project permissions +merge_request: 32187 +author: +type: fixed |