diff options
| author | Markus Koller <mkoller@gitlab.com> | 2019-08-15 12:56:54 +0300 |
|---|---|---|
| committer | Mayra Cabrera <mcabrera@gitlab.com> | 2019-08-16 21:57:25 +0300 |
| commit | a3e716104a3d1189de8a22a8a3ea9a67d66baea2 (patch) | |
| tree | c42729435a8dfe3cab4cb1dbbbf0d24dd1e4475a /changelogs | |
| parent | b7f191c5d025f95f5f343f43b24878c68b5c72b3 (diff) | |
Optimize DB indexes for ES indexing of notes
To index notes, we exclude system notes and use `find_in_batches` to
load them in batches for submission to the ES bulk import API.
These queries often result in DB timeouts because the usage of
`ORDER BY id` results in the `notes_pkey` index being used.
This adds an optimized partial index, and removes the unused index
`index_notes_on_noteable_type` which is already covered for our
usage by the existing `index_notes_on_noteable_id_and_noteable_type`.
Newer versions of PostgreSQL (at least 11) are smarter about this and
use `index_notes_on_project_id_and_noteable_type` instead, so we might
be able to remove the partial index again in the future.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/optimize-note-indexes.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/optimize-note-indexes.yml b/changelogs/unreleased/optimize-note-indexes.yml new file mode 100644 index 00000000000..bfb84779abf --- /dev/null +++ b/changelogs/unreleased/optimize-note-indexes.yml @@ -0,0 +1,5 @@ +--- +title: Optimize DB indexes for ES indexing of notes +merge_request: 31846 +author: +type: performance |