diff options
author | Fatih Acet <acetfatih@gmail.com> | 2016-12-09 19:45:33 +0300 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2016-12-09 19:45:33 +0300 |
commit | ad4c2a08104cba0557d824fac6a70eedd45921b7 (patch) | |
tree | feee2d87b110f979ba8140d31564af500dd9188d /changelogs | |
parent | e17758c25af4c335ed7bc5c8a8422ebc458909ae (diff) | |
parent | 2bc6f88430ba9bc3d5c03a8afc56f4be46a97dd6 (diff) |
Merge branch '25374-svg-as-prop' into 'master'
Resolve "Provide SVG as a prop instead of hiding and copy them in environments table"
## What does this MR do?
- Provides SVG as a prop instead of manually manipulate the DOM to show it
- Uniforms all props names in environments related components, 3 formats were being used and it was error prone
- Adds tests for the new SVG props.
## Why was this MR needed?
Technical debt.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #25374
See merge request !7992
Diffstat (limited to 'changelogs')
-rw-r--r-- | changelogs/unreleased/25374-svg-as-prop.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changelogs/unreleased/25374-svg-as-prop.yml b/changelogs/unreleased/25374-svg-as-prop.yml new file mode 100644 index 00000000000..45a71b55b3b --- /dev/null +++ b/changelogs/unreleased/25374-svg-as-prop.yml @@ -0,0 +1,4 @@ +--- +title: Resolve "Provide SVG as a prop instead of hiding and copy them in environments table" +merge_request: 7992 +author: |