diff options
author | Stan Hu <stanhu@gmail.com> | 2018-12-07 22:16:45 +0300 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2018-12-09 09:06:07 +0300 |
commit | cde78f7f4eaec2740c6e91c7d225d701d0097ec0 (patch) | |
tree | e62f795f3a92d77c2ac2991e3b95f6c6ded8c6a9 /changelogs | |
parent | 7cb0dd98590e8fdd7483b9f61643a0daa23c2b67 (diff) |
Avoid caching BroadcastMessage as an ActiveRecord object
When a Rails 4 host serializes a BroadcastMessage, it will serialize
`ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Integer`, which does
not exist in Rails 5. This will cause Error 500s on a Rails 5 reading
from this cache.
To make Rails 4 and 5 play well together, store the data as JSON and
construct the ActiveRecord objects from JSON.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55034
Diffstat (limited to 'changelogs')
-rw-r--r-- | changelogs/unreleased/sh-json-serialize-broadcast-messages.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-json-serialize-broadcast-messages.yml b/changelogs/unreleased/sh-json-serialize-broadcast-messages.yml new file mode 100644 index 00000000000..e8bee64f780 --- /dev/null +++ b/changelogs/unreleased/sh-json-serialize-broadcast-messages.yml @@ -0,0 +1,5 @@ +--- +title: Avoid caching BroadcastMessage as an ActiveRecord object +merge_request: 23662 +author: +type: fixed |