diff options
| author | Rydkin Maxim <maks.rydkin@gmail.com> | 2017-01-05 18:25:45 +0300 |
|---|---|---|
| committer | Rydkin Maxim <maks.rydkin@gmail.com> | 2017-01-31 10:06:00 +0300 |
| commit | 14326c88f7710bd0ffc7b148a87c6dc2188e2683 (patch) | |
| tree | 5a75055d6b4774b5cafd31bb9fcc93e3fd4e4201 /changelogs | |
| parent | adc0e41f2b0e2a8fa15877246738029666716dc2 (diff) | |
refactor merge request build service
add changelog entry
replace local variables `merge_request` with instance ones
modify `MergeRequests::BuildService` to fix failed tests
extract `assign_target_project` method
remove unnecessary instance variables
remove exclamation marks and rewrite conditionals to improve readability
extract `params_does_not_contain_branches?` method, rename `unprepared_merge_request` method to `uncreatable_merge_request`
replace instance variables `merge_request` and `error_messages` with getters and setters; divide `set_title_and_description` method on two separate ones
refactor `execute` method
return `set_title_and_description` method
rename `branches_selected?` method to `branches_present?` to make it more different from `branches_specified?`
fixes after discussion
renamed method branches_valid?
fix space
return assigning methods into `execute` method
simplify `find_target_branch` and `find_source_project` methods
fix spec `merge request issuable record that supports slash commands in its description and notes`
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/24795_refactor_merge_request_build_service.yml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changelogs/unreleased/24795_refactor_merge_request_build_service.yml b/changelogs/unreleased/24795_refactor_merge_request_build_service.yml new file mode 100644 index 00000000000..b735fb57649 --- /dev/null +++ b/changelogs/unreleased/24795_refactor_merge_request_build_service.yml @@ -0,0 +1,4 @@ +--- +title: Refactor MergeRequests::BuildService +merge_request: 8462 +author: Rydkin Maxim |