diff options
| author | Rémy Coutable <remy@rymai.me> | 2018-07-10 13:10:54 +0300 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-07-11 12:52:03 +0300 |
| commit | ab87e7bab1d5cc20c7b69644843bfcb1f3f16918 (patch) | |
| tree | 2f908718378fbe6984d65781ea76c623ace57eb6 /danger/changes_size | |
| parent | dc629bb6b8146477fdbf9fcd11d10ebedc785029 (diff) | |
Improve Danger files after first review
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'danger/changes_size')
| -rw-r--r-- | danger/changes_size/Dangerfile | 20 |
1 files changed, 15 insertions, 5 deletions
diff --git a/danger/changes_size/Dangerfile b/danger/changes_size/Dangerfile index 4471e1926c9..597073e6029 100644 --- a/danger/changes_size/Dangerfile +++ b/danger/changes_size/Dangerfile @@ -1,9 +1,19 @@ # rubocop:disable Style/SignalException -if git.lines_of_code > 500 - warn "This merge request is quite big, please consider splitting it into multiple merge requests." -end +# FIXME: git.info_for_file raises the following error +# /usr/local/bundle/gems/git-1.4.0/lib/git/lib.rb:956:in `command': (Danger::DSLError) +# [!] Invalid `Dangerfile` file: +# [!] Invalid `Dangerfile` file: git '--git-dir=/builds/gitlab-org/gitlab-ce/.git' '--work-tree=/builds/gitlab-org/gitlab-ce' cat-file '-t' '' 2>&1:fatal: Not a valid object name +# This seems to be the same as https://github.com/danger/danger/issues/535. + +# locale_files_updated = git.modified_files.select { |path| path.start_with?('locale') } +# locale_files_updated.each do |locale_file_updated| +# git_stats = git.info_for_file(locale_file_updated) +# message "Git stats for #{locale_file_updated}: #{git_stats[:insertions]} insertions, #{git_stats[:deletions]} insertions" +# end -if git.lines_of_code > 5_000 - fail "This merge request is definitely too big, please split it into multiple merge requests." +if git.lines_of_code > 2_000 + warn "This merge request is definitely too big (more than #{git.lines_of_code} lines changed), please split it into multiple merge requests." +elsif git.lines_of_code > 500 + warn "This merge request is quite big (more than #{git.lines_of_code} lines changed), please consider splitting it into multiple merge requests." end |