diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-06-16 21:25:58 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-06-16 21:25:58 +0300 |
| commit | a5f4bba440d7f9ea47046a0a561d49adf0a1e6d4 (patch) | |
| tree | fb69158581673816a8cd895f9d352dcb3c678b1e /danger/feature_flag/Dangerfile | |
| parent | d16b2e8639e99961de6ddc93909f3bb5c1445ba1 (diff) | |
Add latest changes from gitlab-org/gitlab@14-0-stable-eev14.0.0-rc42
Diffstat (limited to 'danger/feature_flag/Dangerfile')
| -rw-r--r-- | danger/feature_flag/Dangerfile | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/danger/feature_flag/Dangerfile b/danger/feature_flag/Dangerfile index 88ce6393b64..bf2194724fc 100644 --- a/danger/feature_flag/Dangerfile +++ b/danger/feature_flag/Dangerfile @@ -53,14 +53,22 @@ def message_for_feature_flag_with_group!(feature_flag:, mr_group_label:) end end +def feature_flag_file_added? + feature_flag.feature_flag_files(change_type: :added).any? +end + def feature_flag_file_added_or_removed? - feature_flag.feature_flag_files(change_type: :added).any? || feature_flag.feature_flag_files(change_type: :deleted).any? + feature_flag_file_added? || feature_flag.feature_flag_files(change_type: :deleted).any? end feature_flag.feature_flag_files(change_type: :added).each do |feature_flag| check_feature_flag_yaml(feature_flag) end +if helper.security_mr? && feature_flag_file_added? + fail "Feature flags are discouraged from security merge requests. Read the [security documentation](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/security/utilities/feature_flags.md) for details." +end + if feature_flag_file_added_or_removed? new_mr_title = helper.mr_title.dup new_mr_title << ' [RUN ALL RSPEC]' unless helper.run_all_rspec_mr? |