diff options
| author | Jacopo <beschi.jacopo@gmail.com> | 2019-05-30 13:50:40 +0300 |
|---|---|---|
| committer | Jacopo <beschi.jacopo@gmail.com> | 2019-06-12 22:32:35 +0300 |
| commit | cef127e10778a21756c00c4226592f32f15a6c1f (patch) | |
| tree | a3d1500d26ec126dd5c6921475727e2972bb8eb4 /danger/single_codebase | |
| parent | 8ade1f8758efa687e67c0c29e8d67217c31c9e0f (diff) | |
Excludes MR author from Review roulette
Excludes MR author from gitlab_ui and single_codebase Review roulette
results.
Diffstat (limited to 'danger/single_codebase')
| -rw-r--r-- | danger/single_codebase/Dangerfile | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/danger/single_codebase/Dangerfile b/danger/single_codebase/Dangerfile index d1f538bec7f..f371a42e9b1 100644 --- a/danger/single_codebase/Dangerfile +++ b/danger/single_codebase/Dangerfile @@ -1,6 +1,6 @@ -def new_teammates(usernames) - usernames.map { |u| ::Gitlab::Danger::Teammate.new('username' => u) } -end +FRONTEND_MAINTAINERS = %w[filipa iamphill].freeze +BACKEND_MAINTAINERS = %w[rspeicher rymai yorickpeterse godfat].freeze +NO_REVIEWER = 'No reviewer available'.freeze def mention_single_codebase_approvers canonical_branch_name = @@ -8,8 +8,8 @@ def mention_single_codebase_approvers random = roulette.new_random(canonical_branch_name) - frontend_maintainers = new_teammates(%w[filipa iamphill]) - backend_maintainers = new_teammates(%w[rspeicher rymai yorickpeterse godfat]) + frontend_maintainers = helper.new_teammates(FRONTEND_MAINTAINERS) + backend_maintainers = helper.new_teammates(BACKEND_MAINTAINERS) rows = [] @@ -17,14 +17,14 @@ def mention_single_codebase_approvers frontend_maintainer = roulette.spin_for_person(frontend_maintainers, random: random) - rows << "| ~frontend | #{frontend_maintainer.markdown_name}" + rows << "| ~frontend | #{frontend_maintainer&.markdown_name || NO_REVIEWER}" end if gitlab.mr_labels.include?('backend') backend_maintainer = roulette.spin_for_person(backend_maintainers, random: random) - rows << "| ~backend | #{backend_maintainer.markdown_name}" + rows << "| ~backend | #{backend_maintainer&.markdown_name || NO_REVIEWER}" end if rows.empty? |