diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-06-18 14:18:50 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-06-18 14:18:50 +0300 |
| commit | 8c7f4e9d5f36cff46365a7f8c4b9c21578c1e781 (patch) | |
| tree | a77e7fe7a93de11213032ed4ab1f33a3db51b738 /danger/telemetry | |
| parent | 00b35af3db1abfe813a778f643dad221aad51fca (diff) | |
Add latest changes from gitlab-org/gitlab@13-1-stable-ee
Diffstat (limited to 'danger/telemetry')
| -rw-r--r-- | danger/telemetry/Dangerfile | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/danger/telemetry/Dangerfile b/danger/telemetry/Dangerfile index c18a15fcb03..b749bd3b80b 100644 --- a/danger/telemetry/Dangerfile +++ b/danger/telemetry/Dangerfile @@ -1,12 +1,11 @@ # frozen_string_literal: true TELEMETRY_CHANGED_FILES_MESSAGE = <<~MSG -This merge request includes changes for which a review from the Data team and Telemetry team is recommended. -Please reach out to @gitlab-org/growth/telemetry/engineers group for a review. -MSG +For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended +Please check the ~telemetry [guide](https://docs.gitlab.com/ee/development/telemetry/usage_ping.html) and reach out to @gitlab-org/growth/telemetry/engineers group for a review. + +%<changed_files>s -USAGE_DATA_FILES_MESSAGE = <<~MSG -For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended: MSG tracking_files = [ @@ -16,7 +15,7 @@ tracking_files = [ 'spec/helpers/tracking_helper_spec.rb', 'app/assets/javascripts/tracking.js', 'spec/frontend/tracking_spec.js' - ] +] usage_data_changed_files = git.modified_files.grep(%r{usage_data}) snowplow_events_changed_files = git.modified_files & tracking_files @@ -24,9 +23,7 @@ snowplow_events_changed_files = git.modified_files & tracking_files changed_files = (usage_data_changed_files + snowplow_events_changed_files) if changed_files.any? - warn format(TELEMETRY_CHANGED_FILES_MESSAGE) - - markdown(USAGE_DATA_FILES_MESSAGE + helper.markdown_list(changed_files)) + warn format(TELEMETRY_CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(changed_files)) telemetry_labels = ['telemetry'] telemetry_labels << 'telemetry::review pending' unless helper.mr_has_labels?('telemetry::reviewed') |