diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-07-25 12:12:52 +0300 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-07-29 12:50:39 +0300 |
| commit | 7b2ad2d5b99d84fc2d2c11a654085afc02a05bb1 (patch) | |
| tree | 3ee132c1ad1187e0905f08b6f360a18bd8a1519f /db/migrate/20160705054952_add_protected_branches_merge_access.rb | |
| parent | b3a29b3180c4edda33d82fc3564bd4991831e06c (diff) | |
Implement review comments from @dbalexandre.
1. Remove `master_or_greater?` and `developer_or_greater?` in favor of
`max_member_access`, which is a lot nicer.
2. Remove a number of instances of `include Gitlab::Database::MigrationHelpers`
in migrations that don't need this module. Also remove comments where
not necessary.
3. Remove duplicate entry in CHANGELOG.
4. Move `ProtectedBranchAccessSelect` from Coffeescript to ES6.
5. Split the `set_access_levels!` method in two - one each for `merge` and
`push` access levels.
Diffstat (limited to 'db/migrate/20160705054952_add_protected_branches_merge_access.rb')
| -rw-r--r-- | db/migrate/20160705054952_add_protected_branches_merge_access.rb | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/db/migrate/20160705054952_add_protected_branches_merge_access.rb b/db/migrate/20160705054952_add_protected_branches_merge_access.rb index 9f82c0a8aa3..cf1cdb8b3b6 100644 --- a/db/migrate/20160705054952_add_protected_branches_merge_access.rb +++ b/db/migrate/20160705054952_add_protected_branches_merge_access.rb @@ -2,8 +2,6 @@ # for more information on how to write migrations for GitLab. class AddProtectedBranchesMergeAccess < ActiveRecord::Migration - include Gitlab::Database::MigrationHelpers - def change create_table :protected_branch_merge_access_levels do |t| t.references :protected_branch, index: { name: "index_protected_branch_merge_access" }, foreign_key: true, null: false |