diff options
author | Bob Van Landuyt <bob@vanlanduyt.co> | 2018-03-06 20:02:28 +0300 |
---|---|---|
committer | Bob Van Landuyt <bob@vanlanduyt.co> | 2018-03-28 15:12:08 +0300 |
commit | dbb1b5dbf4ca9305b6e32181c64c6307fe15fc18 (patch) | |
tree | 036d0dc59c827d0ca8982b4dc9fd921ca4f27b3a /db | |
parent | cf213e789862233d187bd649813ed4d064ce0205 (diff) |
Add index on lower path to redirect routes
This will speed up the LIKE query in
RedirectRoute.matching_path_and_descendants
Diffstat (limited to 'db')
-rw-r--r-- | db/post_migrate/20180306164012_add_path_index_to_redirect_routes.rb | 38 |
1 files changed, 38 insertions, 0 deletions
diff --git a/db/post_migrate/20180306164012_add_path_index_to_redirect_routes.rb b/db/post_migrate/20180306164012_add_path_index_to_redirect_routes.rb new file mode 100644 index 00000000000..9ea4d11bb20 --- /dev/null +++ b/db/post_migrate/20180306164012_add_path_index_to_redirect_routes.rb @@ -0,0 +1,38 @@ +# See http://doc.gitlab.com/ce/development/migration_style_guide.html +# for more information on how to write migrations for GitLab. + +class AddPathIndexToRedirectRoutes < ActiveRecord::Migration + include Gitlab::Database::MigrationHelpers + + # Set this constant to true if this migration requires downtime. + DOWNTIME = false + disable_ddl_transaction! + + INDEX_NAME = 'index_redirect_routes_on_path_unique_text_pattern_ops' + + # Indexing on LOWER(path) varchar_pattern_ops speeds up the LIKE query in + # RedirectRoute.matching_path_and_descendants + # + # This same index is also added in the `ReworkRedirectRoutesIndexes` so this + # is a no-op in most cases. But this migration is also called from the + # `setup_postgresql.rake` task when setting up a new database, in which case + # we want to create the index. + def up + return unless Gitlab::Database.postgresql? + + disable_statement_timeout + + if_not_exists = Gitlab::Database.version.to_f >= 9.5 ? "IF NOT EXISTS" : "" + + # Unique index on lower(path) across both types of redirect_routes: + execute("CREATE UNIQUE INDEX CONCURRENTLY #{if_not_exists} #{INDEX_NAME} ON redirect_routes (lower(path) varchar_pattern_ops);") + end + + def down + return unless Gitlab::Database.postgresql? + + disable_statement_timeout + + execute("DROP INDEX IF EXISTS #{INDEX_NAME};") + end +end |