Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/db
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2020-04-21 18:21:10 +0300
committerGitLab Bot <gitlab-bot@gitlab.com>2020-04-21 18:21:10 +0300
commite33f87ac0fabaab468ce4b457996cc0f1b1bb648 (patch)
tree8bf0de72a9acac014cfdaddab7d463b208294af2 /db
parent5baf990db20a75078684702782c24399ef9eb0fa (diff)
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'db')
-rw-r--r--db/migrate/20171230123729_init_schema.rb6
-rw-r--r--db/migrate/20180101160629_create_prometheus_metrics.rb4
-rw-r--r--db/migrate/20180116193854_create_lfs_file_locks.rb2
-rw-r--r--db/migrate/20180122162010_add_auto_devops_domain_to_application_settings.rb4
-rw-r--r--db/migrate/20180129193323_add_uploads_builder_context.rb4
-rw-r--r--db/migrate/20180209115333_create_chatops_tables.rb2
-rw-r--r--db/migrate/20180212030105_add_external_ip_to_clusters_applications_ingress.rb4
-rw-r--r--db/migrate/20180214093516_create_badges.rb5
-rw-r--r--db/migrate/20180214155405_create_clusters_applications_runners.rb4
-rw-r--r--db/migrate/20180216120000_add_pages_domain_verification.rb2
-rw-r--r--db/migrate/20180222043024_add_ip_address_to_runner.rb2
-rw-r--r--db/migrate/20180308125206_add_user_internal_regex_to_application_setting.rb4
-rw-r--r--db/migrate/20180314145917_add_header_and_footer_banners_to_appearances_table.rb2
-rw-r--r--db/migrate/20180315160435_add_external_auth_mutual_tls_fields_to_project_settings.rb6
-rw-r--r--db/migrate/20180319190020_create_deploy_tokens.rb4
-rw-r--r--db/migrate/20180423204600_add_pages_access_level_to_project_feature.rb4
-rw-r--r--db/migrate/20180424134533_create_application_setting_terms.rb2
-rw-r--r--db/migrate/20180502122856_create_project_mirror_data.rb6
-rw-r--r--db/migrate/20180503131624_create_remote_mirrors.rb6
-rw-r--r--db/migrate/20180503175053_ensure_missing_columns_to_project_mirror_data.rb8
-rw-r--r--db/migrate/20180511131058_create_clusters_applications_jupyter.rb10
-rw-r--r--db/migrate/20180515121227_create_notes_diff_files.rb7
-rw-r--r--db/migrate/20180529093006_ensure_remote_mirror_columns.rb7
-rw-r--r--db/migrate/20180531185349_add_repository_languages.rb4
-rw-r--r--db/migrate/20180607071808_add_push_events_branch_filter_to_web_hooks.rb2
-rw-r--r--db/migrate/20180612103626_add_columns_for_helm_tiller_certificates.rb2
-rw-r--r--db/migrate/20180613081317_create_ci_builds_runner_session.rb4
-rw-r--r--db/migrate/20180625113853_create_import_export_uploads.rb2
-rw-r--r--db/migrate/20180713092803_create_user_statuses.rb4
-rw-r--r--db/migrate/20180814153625_add_commit_email_to_users.rb4
-rw-r--r--db/migrate/20180824202952_add_outbound_requests_whitelist_to_application_settings.rb2
-rw-r--r--db/migrate/20180831164908_add_identifier_to_prometheus_metric.rb2
-rw-r--r--db/migrate/20180901200537_add_resource_label_event_reference_fields.rb2
-rw-r--r--db/migrate/20180910115836_add_attr_encrypted_columns_to_web_hook.rb4
-rw-r--r--db/migrate/20180910153412_add_token_digest_to_personal_access_tokens.rb2
-rw-r--r--db/migrate/20180912111628_add_knative_application.rb6
-rw-r--r--db/migrate/20181009190428_create_clusters_kubernetes_namespaces.rb6
-rw-r--r--db/migrate/20181019032400_add_shards_table.rb2
-rw-r--r--db/migrate/20181019032408_add_repositories_table.rb2
-rw-r--r--db/migrate/20181025115728_add_private_commit_email_hostname_to_application_settings.rb4
-rw-r--r--db/migrate/20181031190559_drop_gcp_clusters_table.rb2
-rw-r--r--db/migrate/20181101191341_create_clusters_applications_cert_manager.rb6
-rw-r--r--db/migrate/20181115140140_add_encrypted_runners_token_to_settings.rb4
-rw-r--r--db/migrate/20181116050532_knative_external_ip.rb4
-rw-r--r--db/migrate/20181116141415_add_encrypted_runners_token_to_namespaces.rb4
-rw-r--r--db/migrate/20181116141504_add_encrypted_runners_token_to_projects.rb4
-rw-r--r--db/migrate/20181120151656_add_token_encrypted_to_ci_runners.rb2
-rw-r--r--db/migrate/20181122160027_create_project_repositories.rb2
-rw-r--r--db/migrate/20181123144235_create_suggestions.rb6
-rw-r--r--db/migrate/20181128123704_add_state_to_pool_repository.rb10
-rw-r--r--db/migrate/20181129104854_add_token_encrypted_to_ci_builds.rb4
-rw-r--r--db/migrate/20181203002526_add_project_bfg_object_map_column.rb4
-rw-r--r--db/migrate/20181211092510_add_name_author_id_and_sha_to_releases.rb6
-rw-r--r--db/migrate/20181212171634_create_error_tracking_settings.rb4
-rw-r--r--db/migrate/20181228175414_create_releases_link_table.rb4
-rw-r--r--db/migrate/20190109153125_add_merge_request_external_diffs.rb2
-rw-r--r--db/migrate/20190114172110_add_domain_to_cluster.rb2
-rw-r--r--db/migrate/20190115092821_add_columns_project_error_tracking_settings.rb6
-rw-r--r--db/migrate/20190116234221_add_sorting_fields_to_user_preference.rb6
-rw-r--r--db/migrate/20190219201635_add_asset_proxy_settings.rb8
-rw-r--r--db/migrate/20190301182457_add_external_hostname_to_ingress_and_knative.rb6
-rw-r--r--db/migrate/20190320174702_add_lets_encrypt_notification_email_to_application_settings.rb4
-rw-r--r--db/migrate/20190325105715_add_fields_to_user_preferences.rb2
-rw-r--r--db/migrate/20190327163904_add_notification_email_to_notification_settings.rb4
-rw-r--r--db/migrate/20190402150158_backport_enterprise_schema.rb6
-rw-r--r--db/migrate/20190409224933_add_name_to_geo_nodes.rb2
-rw-r--r--db/migrate/20190414185432_add_comment_to_vulnerability_feedback.rb2
-rw-r--r--db/migrate/20190422082247_create_project_metrics_settings.rb2
-rw-r--r--db/migrate/20190429082448_create_pages_domain_acme_orders.rb6
-rw-r--r--db/migrate/20190430131225_create_issue_tracker_data.rb4
-rw-r--r--db/migrate/20190430142025_create_jira_tracker_data.rb4
-rw-r--r--db/migrate/20190514105711_create_ip_restriction.rb2
-rw-r--r--db/migrate/20190516151857_add_lets_encrypt_private_key_to_application_settings.rb2
-rw-r--r--db/migrate/20190527011309_add_required_template_name_to_application_settings.rb4
-rw-r--r--db/migrate/20190606054742_add_token_encrypted_to_operations_feature_flags_clients.rb4
-rw-r--r--db/migrate/20190606202100_add_name_to_badges.rb2
-rw-r--r--db/migrate/20190611161641_add_target_project_id_to_merge_trains.rb8
-rw-r--r--db/migrate/20190613044655_add_username_to_deploy_tokens.rb2
-rw-r--r--db/migrate/20190613073003_create_project_aliases.rb2
-rw-r--r--db/migrate/20190621151636_add_merge_request_rebase_jid.rb2
-rw-r--r--db/migrate/20190624123615_add_grafana_url_to_settings.rb4
-rw-r--r--db/migrate/20190625115224_add_description_to_services.rb2
-rw-r--r--db/migrate/20190711124721_create_job_variables.rb6
-rw-r--r--db/migrate/20190711200508_add_token_encrypted_to_deploy_tokens.rb2
-rw-r--r--db/migrate/20190716144222_create_analytics_cycle_analytics_project_stages.rb2
-rw-r--r--db/migrate/20190722104947_add_static_object_token_to_users.rb6
-rw-r--r--db/migrate/20190722132830_add_static_objects_external_storage_columns_to_application_settings.rb2
-rw-r--r--db/migrate/20190723153247_create_allowed_email_domains_for_groups.rb2
-rw-r--r--db/migrate/20190729062536_create_analytics_cycle_analytics_group_stages.rb2
-rw-r--r--db/migrate/20190731084415_add_build_need.rb2
-rw-r--r--db/migrate/20190801142441_add_throttle_protected_path_columns.rb2
-rw-r--r--db/migrate/20190808152507_add_projects_sorting_field_to_user_preferences.rb2
-rw-r--r--db/migrate/20190820163320_add_first_last_name_to_user.rb2
-rw-r--r--db/migrate/20190821040941_create_cluster_providers_aws.rb4
-rw-r--r--db/migrate/20190827222124_add_sourcegraph_configuration_to_application_settings.rb2
-rw-r--r--db/migrate/20190828172831_create_package_tag.rb2
-rw-r--r--db/migrate/20190829131130_create_external_pull_requests.rb2
-rw-r--r--db/migrate/20190903150358_create_analytics_repository_files_table.rb2
-rw-r--r--db/migrate/20190906104555_create_alerts_service_data.rb2
-rw-r--r--db/migrate/20190910211526_create_packages_conan_file_metadata.rb2
-rw-r--r--db/migrate/20190913174707_add_spdx_id_to_software_licenses.rb2
-rw-r--r--db/migrate/20190918102042_create_grafana_integrations.rb2
-rw-r--r--db/migrate/20190918121135_add_cleanup_status_reason_to_cluster.rb2
-rw-r--r--db/migrate/20190920224341_create_merge_request_context_commits_and_diffs.rb4
-rw-r--r--db/migrate/20190924124627_add_pull_mirror_branch_prefix_to_projects.rb6
-rw-r--r--db/migrate/20190926225633_create_x509_signatures.rb2
-rw-r--r--db/migrate/20190927055500_create_description_versions.rb2
-rw-r--r--db/migrate/20190929180751_create_vulnerabilities.rb4
-rw-r--r--db/migrate/20190930153535_create_zoom_meetings.rb2
-rw-r--r--db/migrate/20191001170300_create_ci_ref.rb2
-rw-r--r--db/migrate/20191002123516_create_clusters_applications_elastic_stack.rb4
-rw-r--r--db/migrate/20191003015155_add_self_managed_prometheus_alerts.rb2
-rw-r--r--db/migrate/20191003064615_create_aws_roles.rb2
-rw-r--r--db/migrate/20191003195620_add_pendo_url_to_application_settings.rb2
-rw-r--r--db/migrate/20191009222222_add_custom_http_clone_url_root_to_application_settings.rb2
-rw-r--r--db/migrate/20191010174846_add_snowplow_iglu_registry_url_to_application_settings.rb2
-rw-r--r--db/migrate/20191017191341_create_clusters_applications_crossplane.rb4
-rw-r--r--db/migrate/20191025092748_add_secret_token_to_snippet.rb2
-rw-r--r--db/migrate/20191029125305_create_packages_conan_metadata.rb2
-rw-r--r--db/migrate/20191103202505_add_eks_credentials_to_application_settings.rb4
-rw-r--r--db/migrate/20191105134413_create_service_desk_settings.rb2
-rw-r--r--db/migrate/20191111121500_default_ci_config_path.rb2
-rw-r--r--db/migrate/20191119231621_create_container_expiration_policies.rb2
-rw-r--r--db/migrate/20191120084627_add_encrypted_fields_to_application_settings.rb4
-rw-r--r--db/migrate/20191121111621_create_packages_dependencies.rb2
-rw-r--r--db/migrate/20191125133353_add_target_path_to_broadcast_message.rb2
-rw-r--r--db/migrate/20191125140458_create_import_failures.rb2
-rw-r--r--db/migrate/20191127030005_create_serverless_domain_cluster.rb2
-rw-r--r--db/migrate/20191128145231_add_ci_resource_groups.rb2
-rw-r--r--db/migrate/20191202181924_add_environment_auto_stop_in_to_ci_builds_metadata.rb2
-rw-r--r--db/migrate/20191204192726_add_design_disk_path_to_geo_hashed_storage_migrated_events.rb2
-rw-r--r--db/migrate/20191206014412_add_image_to_design_management_designs_versions.rb2
-rw-r--r--db/migrate/20191208110214_add_suggestion_commit_message_to_projects.rb6
-rw-r--r--db/migrate/20191212140117_change_commit_user_mentions_commit_id_column_type.rb2
-rw-r--r--db/migrate/20191213104838_add_service_desk_username.rb2
-rw-r--r--db/migrate/20191213143656_create_ci_pipelines_config.rb2
-rw-r--r--db/migrate/20191218124915_add_repository_storage_to_snippets.rb2
-rw-r--r--db/migrate/20200102140148_add_expanded_environment_name_to_ci_build_metadata.rb2
-rw-r--r--db/migrate/20200121192942_create_geo_events.rb2
-rw-r--r--db/migrate/20200124053531_add_source_to_import_failures.rb2
-rw-r--r--db/migrate/20200129133716_add_resource_milestone_events_table.rb2
-rw-r--r--db/migrate/20200130134335_add_cert_and_key_to_serverless_domain_cluster.rb4
-rw-r--r--db/migrate/20200202100932_add_service_desk_project_key.rb2
-rw-r--r--db/migrate/20200204131831_create_daily_report_results.rb6
-rw-r--r--db/migrate/20200206112850_create_snippet_repository_table.rb2
-rw-r--r--db/migrate/20200207151640_create_deployment_clusters.rb2
-rw-r--r--db/migrate/20200210184410_create_operations_strategies_table.rb2
-rw-r--r--db/migrate/20200210184420_create_operations_scopes_table.rb2
-rw-r--r--db/migrate/20200213093702_add_email_restrictions_to_application_settings.rb2
-rw-r--r--db/migrate/20200213100530_add_verification_columns_to_packages.rb2
-rw-r--r--db/migrate/20200214025454_add_canonical_emails.rb2
-rw-r--r--db/migrate/20200219105209_add_filepath_to_release_links.rb2
-rw-r--r--db/migrate/20200219135440_add_limit_metric_type_to_list.rb2
-rw-r--r--db/migrate/20200224020219_add_status_page_settings.rb2
-rw-r--r--db/migrate/20200226100614_create_requirements.rb4
-rw-r--r--db/migrate/20200227164113_create_scim_identities.rb2
-rw-r--r--db/migrate/20200227165129_create_user_details.rb2
-rw-r--r--db/migrate/20200302152516_add_wiki_slug.rb2
-rw-r--r--db/migrate/20200305200641_create_terraform_states.rb2
-rw-r--r--db/migrate/20200309162244_add_open_project_tracker_data.rb2
-rw-r--r--db/migrate/20200311154110_create_vulnerability_exports.rb2
-rw-r--r--db/migrate/20200311165635_create_project_export_jobs.rb2
-rw-r--r--db/migrate/20200318162148_add_external_key_to_issues_table.rb2
-rw-r--r--db/migrate/20200318164448_add_external_key_to_epics_table.rb2
-rw-r--r--db/migrate/20200318183553_create_pypi_package_metadata.rb2
-rw-r--r--db/migrate/20200319124127_create_metrics_dashboard_annotations.rb4
-rw-r--r--db/migrate/20200323071918_add_bio_to_user_details.rb2
-rw-r--r--db/migrate/20200326114443_create_jira_imports_table.rb2
-rw-r--r--db/migrate/20200326122700_create_diff_note_positions.rb4
-rw-r--r--db/migrate/20200401211005_create_operations_user_lists.rb4
-rw-r--r--db/migrate/20200402124802_add_correlation_id_to_project_import_state.rb2
-rw-r--r--db/migrate/20200402185044_create_clusters_applications_fluentd.rb4
-rw-r--r--db/migrate/20200407120000_add_push_rule_id_to_groups.rb19
-rw-r--r--db/migrate/20200407121321_add_push_rule_foreign_key_to_groups.rb18
-rw-r--r--db/migrate/20200407171133_add_protected_tag_create_access_levels_user_id_foreign_key.rb3
-rw-r--r--db/migrate/20200407182205_create_partitioned_foreign_keys.rb31
-rw-r--r--db/migrate/20200408154331_add_protected_branch_merge_access_levels_user_id_foreign_key.rb3
-rw-r--r--db/migrate/20200408154411_add_path_locks_user_id_foreign_key.rb3
-rw-r--r--db/migrate/20200408154455_add_protected_branch_push_access_levels_user_id_foreign_key.rb3
-rw-r--r--db/migrate/20200408154604_add_u2f_registrations_user_id_foreign_key.rb3
-rw-r--r--db/migrate/20200408212219_add_status_page_url_to_status_page_settings.rb18
-rw-r--r--db/migrate/20200409085956_add_partial_index_on_import_failures_retry_count.rb17
-rw-r--r--db/migrate/20200410104828_add_comment_detail_to_services.rb13
-rw-r--r--db/migrate/20200410232012_add_metrics_dashboard_access_level_to_project_feature.rb19
-rw-r--r--db/migrate/20200413072059_add_group_owners_can_manage_default_branch_protection_to_application_settings.rb19
-rw-r--r--db/migrate/20200413230056_add_waf_and_cilium_logs_to_applications_fluentd.rb29
-rw-r--r--db/migrate/20200414144547_remove_index_projects_on_creator_id_and_created_at_from_projects.rb18
-rw-r--r--db/migrate/20200415192656_add_name_regex_keep_to_container_expiration_policies.rb21
-rw-r--r--db/migrate/20200416120128_add_columns_to_terraform_state.rb19
-rw-r--r--db/migrate/20200416120354_add_locked_by_user_id_foreign_key_to_terraform_state.rb19
-rw-r--r--db/post_migrate/20181013005024_remove_koding_from_application_settings.rb2
-rw-r--r--db/post_migrate/20190404231137_remove_alternate_url_from_geo_nodes.rb2
-rw-r--r--db/post_migrate/20190625184066_remove_sentry_from_application_settings.rb2
-rw-r--r--db/post_migrate/20191202031812_drop_operations_feature_flags_clients_token.rb2
-rw-r--r--db/post_migrate/20200128210353_cleanup_optimistic_locking_nulls.rb2
-rw-r--r--db/post_migrate/20200217210353_cleanup_optimistic_locking_nulls_pt2.rb47
-rw-r--r--db/post_migrate/20200219193058_remove_state_from_issues.rb2
-rw-r--r--db/post_migrate/20200219193117_remove_state_from_merge_requests.rb2
-rw-r--r--db/post_migrate/20200325162730_schedule_backfill_push_rules_id_in_projects.rb5
-rw-r--r--db/structure.sql98
200 files changed, 819 insertions, 171 deletions
diff --git a/db/migrate/20171230123729_init_schema.rb b/db/migrate/20171230123729_init_schema.rb
index 79c9ebbb691..99ff85ff01f 100644
--- a/db/migrate/20171230123729_init_schema.rb
+++ b/db/migrate/20171230123729_init_schema.rb
@@ -5,7 +5,8 @@
# rubocop:disable Metrics/AbcSize
# rubocop:disable Migration/AddConcurrentForeignKey
# rubocop:disable Style/WordArray
-# rubocop:disable Migration/AddLimitToStringColumns
+# rubocop:disable Migration/PreventStrings
+# rubocop:disable Migration/AddLimitToTextColumns
# rubocop:disable Migration/Datetime
class InitSchema < ActiveRecord::Migration[4.2]
@@ -1854,4 +1855,5 @@ class InitSchema < ActiveRecord::Migration[4.2]
raise ActiveRecord::IrreversibleMigration, "The initial migration is not revertable"
end
end
-# rubocop:enable Migration/AddLimitToStringColumns
+# rubocop:enable Migration/AddLimitToTextColumns
+# rubocop:enable Migration/PreventStrings
diff --git a/db/migrate/20180101160629_create_prometheus_metrics.rb b/db/migrate/20180101160629_create_prometheus_metrics.rb
index a098b999a0a..f94abd0e76e 100644
--- a/db/migrate/20180101160629_create_prometheus_metrics.rb
+++ b/db/migrate/20180101160629_create_prometheus_metrics.rb
@@ -3,8 +3,8 @@
class CreatePrometheusMetrics < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :prometheus_metrics do |t|
t.references :project, index: true, foreign_key: { on_delete: :cascade }, null: false
t.string :title, null: false
@@ -15,6 +15,6 @@ class CreatePrometheusMetrics < ActiveRecord::Migration[4.2]
t.integer :group, null: false, index: true
t.timestamps_with_timezone null: false
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180116193854_create_lfs_file_locks.rb b/db/migrate/20180116193854_create_lfs_file_locks.rb
index b94f69ad42e..6d49281dca2 100644
--- a/db/migrate/20180116193854_create_lfs_file_locks.rb
+++ b/db/migrate/20180116193854_create_lfs_file_locks.rb
@@ -10,7 +10,7 @@ class CreateLfsFileLocks < ActiveRecord::Migration[4.2]
t.references :project, null: false, foreign_key: { on_delete: :cascade }
t.references :user, null: false, index: true, foreign_key: { on_delete: :cascade }
t.datetime :created_at, null: false # rubocop:disable Migration/Datetime
- t.string :path, limit: 511
+ t.string :path, limit: 511 # rubocop:disable Migration/PreventStrings
end
add_index :lfs_file_locks, [:project_id, :path], unique: true
diff --git a/db/migrate/20180122162010_add_auto_devops_domain_to_application_settings.rb b/db/migrate/20180122162010_add_auto_devops_domain_to_application_settings.rb
index eb446ad0d72..603f4eb13db 100644
--- a/db/migrate/20180122162010_add_auto_devops_domain_to_application_settings.rb
+++ b/db/migrate/20180122162010_add_auto_devops_domain_to_application_settings.rb
@@ -7,7 +7,9 @@ class AddAutoDevopsDomainToApplicationSettings < ActiveRecord::Migration[4.2]
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :application_settings, :auto_devops_domain, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :application_settings, :auto_devops_domain, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180129193323_add_uploads_builder_context.rb b/db/migrate/20180129193323_add_uploads_builder_context.rb
index 710fa7b3ba8..308b732dca4 100644
--- a/db/migrate/20180129193323_add_uploads_builder_context.rb
+++ b/db/migrate/20180129193323_add_uploads_builder_context.rb
@@ -7,10 +7,10 @@ class AddUploadsBuilderContext < ActiveRecord::Migration[4.2]
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
add_column :uploads, :mount_point, :string
add_column :uploads, :secret, :string
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180209115333_create_chatops_tables.rb b/db/migrate/20180209115333_create_chatops_tables.rb
index 2cfb71e1007..9e11dfde7a3 100644
--- a/db/migrate/20180209115333_create_chatops_tables.rb
+++ b/db/migrate/20180209115333_create_chatops_tables.rb
@@ -9,7 +9,7 @@ class CreateChatopsTables < ActiveRecord::Migration[4.2]
create_table :ci_pipeline_chat_data, id: :bigserial do |t|
t.integer :pipeline_id, null: false
t.references :chat_name, foreign_key: { on_delete: :cascade }, null: false
- t.text :response_url, null: false
+ t.text :response_url, null: false # rubocop:disable Migration/AddLimitToTextColumns
# A pipeline can only contain one row in this table, hence this index is
# unique.
diff --git a/db/migrate/20180212030105_add_external_ip_to_clusters_applications_ingress.rb b/db/migrate/20180212030105_add_external_ip_to_clusters_applications_ingress.rb
index 78aa2014601..78bb49b8b84 100644
--- a/db/migrate/20180212030105_add_external_ip_to_clusters_applications_ingress.rb
+++ b/db/migrate/20180212030105_add_external_ip_to_clusters_applications_ingress.rb
@@ -3,7 +3,9 @@ class AddExternalIpToClustersApplicationsIngress < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :clusters_applications_ingress, :external_ip, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :clusters_applications_ingress, :external_ip, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180214093516_create_badges.rb b/db/migrate/20180214093516_create_badges.rb
index fe27d465571..7a0d82d2d81 100644
--- a/db/migrate/20180214093516_create_badges.rb
+++ b/db/migrate/20180214093516_create_badges.rb
@@ -1,8 +1,8 @@
class CreateBadges < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :badges do |t|
t.string :link_url, null: false
t.string :image_url, null: false
@@ -12,9 +12,10 @@ class CreateBadges < ActiveRecord::Migration[4.2]
t.timestamps_with_timezone null: false
end
- # rubocop:enable Migration/AddLimitToStringColumns
# rubocop:disable Migration/AddConcurrentForeignKey
add_foreign_key :badges, :namespaces, column: :group_id, on_delete: :cascade
+ # rubocop:enable Migration/AddConcurrentForeignKey
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180214155405_create_clusters_applications_runners.rb b/db/migrate/20180214155405_create_clusters_applications_runners.rb
index f611fefbb0d..e6025007507 100644
--- a/db/migrate/20180214155405_create_clusters_applications_runners.rb
+++ b/db/migrate/20180214155405_create_clusters_applications_runners.rb
@@ -13,8 +13,8 @@ class CreateClustersApplicationsRunners < ActiveRecord::Migration[4.2]
t.index :cluster_id, unique: true
t.integer :status, null: false
t.timestamps_with_timezone null: false
- t.string :version, null: false # rubocop:disable Migration/AddLimitToStringColumns
- t.text :status_reason
+ t.string :version, null: false # rubocop:disable Migration/PreventStrings
+ t.text :status_reason # rubocop:disable Migration/AddLimitToTextColumns
end
add_concurrent_foreign_key :clusters_applications_runners, :ci_runners,
diff --git a/db/migrate/20180216120000_add_pages_domain_verification.rb b/db/migrate/20180216120000_add_pages_domain_verification.rb
index b2f19f2e1a9..0600fe633a7 100644
--- a/db/migrate/20180216120000_add_pages_domain_verification.rb
+++ b/db/migrate/20180216120000_add_pages_domain_verification.rb
@@ -3,6 +3,6 @@ class AddPagesDomainVerification < ActiveRecord::Migration[4.2]
def change
add_column :pages_domains, :verified_at, :datetime_with_timezone
- add_column :pages_domains, :verification_code, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :pages_domains, :verification_code, :string # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20180222043024_add_ip_address_to_runner.rb b/db/migrate/20180222043024_add_ip_address_to_runner.rb
index 08fb0bd900c..cc183112f6f 100644
--- a/db/migrate/20180222043024_add_ip_address_to_runner.rb
+++ b/db/migrate/20180222043024_add_ip_address_to_runner.rb
@@ -4,6 +4,6 @@ class AddIpAddressToRunner < ActiveRecord::Migration[4.2]
DOWNTIME = false
def change
- add_column :ci_runners, :ip_address, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :ci_runners, :ip_address, :string # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20180308125206_add_user_internal_regex_to_application_setting.rb b/db/migrate/20180308125206_add_user_internal_regex_to_application_setting.rb
index 9bdd44baf58..d97d2953677 100644
--- a/db/migrate/20180308125206_add_user_internal_regex_to_application_setting.rb
+++ b/db/migrate/20180308125206_add_user_internal_regex_to_application_setting.rb
@@ -3,9 +3,11 @@ class AddUserInternalRegexToApplicationSetting < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
- add_column :application_settings, :user_default_internal_regex, :string, null: true # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :application_settings, :user_default_internal_regex, :string, null: true
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column :application_settings, :user_default_internal_regex
diff --git a/db/migrate/20180314145917_add_header_and_footer_banners_to_appearances_table.rb b/db/migrate/20180314145917_add_header_and_footer_banners_to_appearances_table.rb
index 8aba3448035..a6f2605c906 100644
--- a/db/migrate/20180314145917_add_header_and_footer_banners_to_appearances_table.rb
+++ b/db/migrate/20180314145917_add_header_and_footer_banners_to_appearances_table.rb
@@ -6,6 +6,7 @@ class AddHeaderAndFooterBannersToAppearancesTable < ActiveRecord::Migration[4.2]
DOWNTIME = false
def change
+ # rubocop:disable Migration/AddLimitToTextColumns
add_column :appearances, :header_message, :text
add_column :appearances, :header_message_html, :text
@@ -14,5 +15,6 @@ class AddHeaderAndFooterBannersToAppearancesTable < ActiveRecord::Migration[4.2]
add_column :appearances, :message_background_color, :text
add_column :appearances, :message_font_color, :text
+ # rubocop:enable Migration/AddLimitToTextColumns
end
end
diff --git a/db/migrate/20180315160435_add_external_auth_mutual_tls_fields_to_project_settings.rb b/db/migrate/20180315160435_add_external_auth_mutual_tls_fields_to_project_settings.rb
index c379d207ff0..dd40c5fdf4d 100644
--- a/db/migrate/20180315160435_add_external_auth_mutual_tls_fields_to_project_settings.rb
+++ b/db/migrate/20180315160435_add_external_auth_mutual_tls_fields_to_project_settings.rb
@@ -1,8 +1,9 @@
class AddExternalAuthMutualTlsFieldsToProjectSettings < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
- # rubocop:disable Migration/AddLimitToStringColumns
add_column :application_settings,
:external_auth_client_cert, :text
add_column :application_settings,
@@ -13,6 +14,7 @@ class AddExternalAuthMutualTlsFieldsToProjectSettings < ActiveRecord::Migration[
:encrypted_external_auth_client_key_pass, :string
add_column :application_settings,
:encrypted_external_auth_client_key_pass_iv, :string
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180319190020_create_deploy_tokens.rb b/db/migrate/20180319190020_create_deploy_tokens.rb
index f444521b3ae..019543cb2f1 100644
--- a/db/migrate/20180319190020_create_deploy_tokens.rb
+++ b/db/migrate/20180319190020_create_deploy_tokens.rb
@@ -1,8 +1,8 @@
class CreateDeployTokens < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :deploy_tokens do |t|
t.boolean :revoked, default: false
t.boolean :read_repository, null: false, default: false
@@ -16,6 +16,6 @@ class CreateDeployTokens < ActiveRecord::Migration[4.2]
t.index [:token, :expires_at, :id], where: "(revoked IS FALSE)"
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180423204600_add_pages_access_level_to_project_feature.rb b/db/migrate/20180423204600_add_pages_access_level_to_project_feature.rb
index 0c536f917ce..acb6d04126e 100644
--- a/db/migrate/20180423204600_add_pages_access_level_to_project_feature.rb
+++ b/db/migrate/20180423204600_add_pages_access_level_to_project_feature.rb
@@ -4,11 +4,15 @@ class AddPagesAccessLevelToProjectFeature < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop: disable Migration/UpdateLargeTable
+ # rubocop: disable Migration/AddColumnWithDefault
def up
add_column_with_default(:project_features, :pages_access_level, :integer, default: ProjectFeature::PUBLIC, allow_null: false)
change_column_default(:project_features, :pages_access_level, ProjectFeature::ENABLED)
end
+ # rubocop: enable Migration/UpdateLargeTable
+ # rubocop: enable Migration/AddColumnWithDefault
def down
remove_column :project_features, :pages_access_level
diff --git a/db/migrate/20180424134533_create_application_setting_terms.rb b/db/migrate/20180424134533_create_application_setting_terms.rb
index 8741f20daeb..41edb8a9559 100644
--- a/db/migrate/20180424134533_create_application_setting_terms.rb
+++ b/db/migrate/20180424134533_create_application_setting_terms.rb
@@ -3,6 +3,7 @@ class CreateApplicationSettingTerms < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
create_table :application_setting_terms do |t|
t.integer :cached_markdown_version
@@ -10,4 +11,5 @@ class CreateApplicationSettingTerms < ActiveRecord::Migration[4.2]
t.text :terms_html
end
end
+ # rubocop:enable Migration/AddLimitToTextColumns
end
diff --git a/db/migrate/20180502122856_create_project_mirror_data.rb b/db/migrate/20180502122856_create_project_mirror_data.rb
index 04367e1c98b..1ecfd8926fb 100644
--- a/db/migrate/20180502122856_create_project_mirror_data.rb
+++ b/db/migrate/20180502122856_create_project_mirror_data.rb
@@ -3,7 +3,8 @@ class CreateProjectMirrorData < ActiveRecord::Migration[4.2]
DOWNTIME = false
- # rubocop:disable Migration/AddLimitToStringColumns
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def up
if table_exists?(:project_mirror_data)
add_column :project_mirror_data, :status, :string unless column_exists?(:project_mirror_data, :status)
@@ -18,7 +19,8 @@ class CreateProjectMirrorData < ActiveRecord::Migration[4.2]
end
end
end
- # rubocop:enable Migration/AddLimitToStringColumns
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
def down
remove_column :project_mirror_data, :status
diff --git a/db/migrate/20180503131624_create_remote_mirrors.rb b/db/migrate/20180503131624_create_remote_mirrors.rb
index 80090c14314..330a0d8f62d 100644
--- a/db/migrate/20180503131624_create_remote_mirrors.rb
+++ b/db/migrate/20180503131624_create_remote_mirrors.rb
@@ -5,7 +5,7 @@ class CreateRemoteMirrors < ActiveRecord::Migration[4.2]
disable_ddl_transaction!
- # rubocop:disable Migration/AddLimitToStringColumns
+ # rubocop:disable Migration/PreventStrings
def up
return if table_exists?(:remote_mirrors)
@@ -20,7 +20,7 @@ class CreateRemoteMirrors < ActiveRecord::Migration[4.2]
t.string :last_error
t.boolean :only_protected_branches, default: false, null: false
t.string :remote_name
- t.text :encrypted_credentials
+ t.text :encrypted_credentials # rubocop:disable Migration/AddLimitToTextColumns
t.string :encrypted_credentials_iv
t.string :encrypted_credentials_salt
@@ -28,7 +28,7 @@ class CreateRemoteMirrors < ActiveRecord::Migration[4.2]
t.timestamps null: false
end
end
- # rubocop:enable Migration/AddLimitToStringColumns
+ # rubocop:enable Migration/PreventStrings
def down
# ee/db/migrate/20160321161032_create_remote_mirrors_ee.rb will remove the table
diff --git a/db/migrate/20180503175053_ensure_missing_columns_to_project_mirror_data.rb b/db/migrate/20180503175053_ensure_missing_columns_to_project_mirror_data.rb
index f00493ed515..12ebac47850 100644
--- a/db/migrate/20180503175053_ensure_missing_columns_to_project_mirror_data.rb
+++ b/db/migrate/20180503175053_ensure_missing_columns_to_project_mirror_data.rb
@@ -3,11 +3,15 @@ class EnsureMissingColumnsToProjectMirrorData < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
+ # rubocop:disable Migration/PreventStrings
def up
- add_column :project_mirror_data, :status, :string unless column_exists?(:project_mirror_data, :status) # rubocop:disable Migration/AddLimitToStringColumns
- add_column :project_mirror_data, :jid, :string unless column_exists?(:project_mirror_data, :jid) # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :project_mirror_data, :status, :string unless column_exists?(:project_mirror_data, :status)
+ add_column :project_mirror_data, :jid, :string unless column_exists?(:project_mirror_data, :jid)
add_column :project_mirror_data, :last_error, :text unless column_exists?(:project_mirror_data, :last_error)
end
+ # rubocop:enable Migration/PreventStrings
+ # rubocop:enable Migration/AddLimitToTextColumns
def down
# db/migrate/20180502122856_create_project_mirror_data.rb will remove the table
diff --git a/db/migrate/20180511131058_create_clusters_applications_jupyter.rb b/db/migrate/20180511131058_create_clusters_applications_jupyter.rb
index 4633d930e2d..908a6113f98 100644
--- a/db/migrate/20180511131058_create_clusters_applications_jupyter.rb
+++ b/db/migrate/20180511131058_create_clusters_applications_jupyter.rb
@@ -6,20 +6,20 @@ class CreateClustersApplicationsJupyter < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :clusters_applications_jupyter do |t|
t.references :cluster, null: false, unique: true, foreign_key: { on_delete: :cascade }
t.references :oauth_application, foreign_key: { on_delete: :nullify }
t.integer :status, null: false
- t.string :version, null: false # rubocop:disable Migration/AddLimitToStringColumns
- t.string :hostname # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :version, null: false
+ t.string :hostname
t.timestamps_with_timezone null: false
- t.text :status_reason
+ t.text :status_reason # rubocop:disable Migration/AddLimitToTextColumns
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180515121227_create_notes_diff_files.rb b/db/migrate/20180515121227_create_notes_diff_files.rb
index 5f6dba11ff9..1797a86c679 100644
--- a/db/migrate/20180515121227_create_notes_diff_files.rb
+++ b/db/migrate/20180515121227_create_notes_diff_files.rb
@@ -3,8 +3,9 @@ class CreateNotesDiffFiles < ActiveRecord::Migration[4.2]
disable_ddl_transaction!
+ # rubocop:disable Migration/AddLimitToTextColumns
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :note_diff_files do |t|
t.references :diff_note, references: :notes, null: false, index: { unique: true }
t.text :diff, null: false
@@ -19,6 +20,8 @@ class CreateNotesDiffFiles < ActiveRecord::Migration[4.2]
# rubocop:disable Migration/AddConcurrentForeignKey
add_foreign_key :note_diff_files, :notes, column: :diff_note_id, on_delete: :cascade
- # rubocop:enable Migration/AddLimitToStringColumns
+ # rubocop:enable Migration/AddConcurrentForeignKey
end
+ # rubocop:enable Migration/PreventStrings
+ # rubocop:enable Migration/AddLimitToTextColumns
end
diff --git a/db/migrate/20180529093006_ensure_remote_mirror_columns.rb b/db/migrate/20180529093006_ensure_remote_mirror_columns.rb
index a0a1150f022..3878ded3351 100644
--- a/db/migrate/20180529093006_ensure_remote_mirror_columns.rb
+++ b/db/migrate/20180529093006_ensure_remote_mirror_columns.rb
@@ -5,10 +5,11 @@ class EnsureRemoteMirrorColumns < ActiveRecord::Migration[4.2]
disable_ddl_transaction!
+ # rubocop:disable Migration/Datetime
+ # rubocop:disable Migration/PreventStrings
def up
- # rubocop:disable Migration/Datetime
add_column :remote_mirrors, :last_update_started_at, :datetime unless column_exists?(:remote_mirrors, :last_update_started_at)
- add_column :remote_mirrors, :remote_name, :string unless column_exists?(:remote_mirrors, :remote_name) # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :remote_mirrors, :remote_name, :string unless column_exists?(:remote_mirrors, :remote_name)
unless column_exists?(:remote_mirrors, :only_protected_branches)
add_column_with_default(:remote_mirrors,
@@ -18,6 +19,8 @@ class EnsureRemoteMirrorColumns < ActiveRecord::Migration[4.2]
allow_null: false)
end
end
+ # rubocop:enable Migration/PreventStrings
+ # rubocop:enable Migration/Datetime
def down
# db/migrate/20180503131624_create_remote_mirrors.rb will remove the table
diff --git a/db/migrate/20180531185349_add_repository_languages.rb b/db/migrate/20180531185349_add_repository_languages.rb
index d517c21c26c..08871e8b6f0 100644
--- a/db/migrate/20180531185349_add_repository_languages.rb
+++ b/db/migrate/20180531185349_add_repository_languages.rb
@@ -3,8 +3,8 @@ class AddRepositoryLanguages < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
- # rubocop:disable Migration/AddLimitToStringColumns
create_table(:programming_languages) do |t|
t.string :name, null: false
t.string :color, null: false
@@ -20,8 +20,8 @@ class AddRepositoryLanguages < ActiveRecord::Migration[4.2]
add_index :programming_languages, :name, unique: true
add_index :repository_languages, [:project_id, :programming_language_id],
unique: true, name: "index_repository_languages_on_project_and_languages_id"
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
def down
drop_table :repository_languages
diff --git a/db/migrate/20180607071808_add_push_events_branch_filter_to_web_hooks.rb b/db/migrate/20180607071808_add_push_events_branch_filter_to_web_hooks.rb
index e6a1daaffc2..42bb0a784bb 100644
--- a/db/migrate/20180607071808_add_push_events_branch_filter_to_web_hooks.rb
+++ b/db/migrate/20180607071808_add_push_events_branch_filter_to_web_hooks.rb
@@ -7,6 +7,6 @@ class AddPushEventsBranchFilterToWebHooks < ActiveRecord::Migration[4.2]
DOWNTIME = false
def change
- add_column :web_hooks, :push_events_branch_filter, :text
+ add_column :web_hooks, :push_events_branch_filter, :text # rubocop:disable Migration/AddLimitToTextColumns
end
end
diff --git a/db/migrate/20180612103626_add_columns_for_helm_tiller_certificates.rb b/db/migrate/20180612103626_add_columns_for_helm_tiller_certificates.rb
index d7273dff48e..515aab45145 100644
--- a/db/migrate/20180612103626_add_columns_for_helm_tiller_certificates.rb
+++ b/db/migrate/20180612103626_add_columns_for_helm_tiller_certificates.rb
@@ -4,9 +4,11 @@ class AddColumnsForHelmTillerCertificates < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
add_column :clusters_applications_helm, :encrypted_ca_key, :text
add_column :clusters_applications_helm, :encrypted_ca_key_iv, :text
add_column :clusters_applications_helm, :ca_cert, :text
end
+ # rubocop:enable Migration/AddLimitToTextColumns
end
diff --git a/db/migrate/20180613081317_create_ci_builds_runner_session.rb b/db/migrate/20180613081317_create_ci_builds_runner_session.rb
index 68af38834d2..29e133de1b7 100644
--- a/db/migrate/20180613081317_create_ci_builds_runner_session.rb
+++ b/db/migrate/20180613081317_create_ci_builds_runner_session.rb
@@ -7,8 +7,8 @@ class CreateCiBuildsRunnerSession < ActiveRecord::Migration[4.2]
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :ci_builds_runner_session, id: :bigserial do |t|
t.integer :build_id, null: false
t.string :url, null: false
@@ -18,6 +18,6 @@ class CreateCiBuildsRunnerSession < ActiveRecord::Migration[4.2]
t.foreign_key :ci_builds, column: :build_id, on_delete: :cascade
t.index :build_id, unique: true
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180625113853_create_import_export_uploads.rb b/db/migrate/20180625113853_create_import_export_uploads.rb
index d76b3e8cc15..2fe5a1e7f6b 100644
--- a/db/migrate/20180625113853_create_import_export_uploads.rb
+++ b/db/migrate/20180625113853_create_import_export_uploads.rb
@@ -1,6 +1,7 @@
class CreateImportExportUploads < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
create_table :import_export_uploads do |t|
t.datetime_with_timezone :updated_at, null: false
@@ -13,4 +14,5 @@ class CreateImportExportUploads < ActiveRecord::Migration[4.2]
add_index :import_export_uploads, :updated_at
end
+ # rubocop:enable Migration/AddLimitToTextColumns
end
diff --git a/db/migrate/20180713092803_create_user_statuses.rb b/db/migrate/20180713092803_create_user_statuses.rb
index 3abab4e45a9..79a12c9b8ee 100644
--- a/db/migrate/20180713092803_create_user_statuses.rb
+++ b/db/migrate/20180713092803_create_user_statuses.rb
@@ -5,8 +5,8 @@ class CreateUserStatuses < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :user_statuses, id: false, primary_key: :user_id do |t|
t.references :user,
foreign_key: { on_delete: :cascade },
@@ -17,6 +17,6 @@ class CreateUserStatuses < ActiveRecord::Migration[4.2]
t.string :message, limit: 100
t.string :message_html
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180814153625_add_commit_email_to_users.rb b/db/migrate/20180814153625_add_commit_email_to_users.rb
index 303be9b2312..c94ee9512de 100644
--- a/db/migrate/20180814153625_add_commit_email_to_users.rb
+++ b/db/migrate/20180814153625_add_commit_email_to_users.rb
@@ -27,11 +27,11 @@ class AddCommitEmailToUsers < ActiveRecord::Migration[4.2]
# comments:
# disable_ddl_transaction!
- # rubocop:disable Migration/AddLimitToStringColumns
+ # rubocop:disable Migration/PreventStrings
# rubocop:disable Migration/AddColumnsToWideTables
def change
add_column :users, :commit_email, :string
end
- # rubocop:enable Migration/AddLimitToStringColumns
# rubocop:enable Migration/AddColumnsToWideTables
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180824202952_add_outbound_requests_whitelist_to_application_settings.rb b/db/migrate/20180824202952_add_outbound_requests_whitelist_to_application_settings.rb
index 4ee654ce873..7b87b04bc9d 100644
--- a/db/migrate/20180824202952_add_outbound_requests_whitelist_to_application_settings.rb
+++ b/db/migrate/20180824202952_add_outbound_requests_whitelist_to_application_settings.rb
@@ -3,7 +3,9 @@
class AddOutboundRequestsWhitelistToApplicationSettings < ActiveRecord::Migration[5.1]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :application_settings, :outbound_local_requests_whitelist, :string, array: true, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180831164908_add_identifier_to_prometheus_metric.rb b/db/migrate/20180831164908_add_identifier_to_prometheus_metric.rb
index 8f30363c310..efdcab53920 100644
--- a/db/migrate/20180831164908_add_identifier_to_prometheus_metric.rb
+++ b/db/migrate/20180831164908_add_identifier_to_prometheus_metric.rb
@@ -6,6 +6,6 @@ class AddIdentifierToPrometheusMetric < ActiveRecord::Migration[4.2]
DOWNTIME = false
def change
- add_column :prometheus_metrics, :identifier, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :prometheus_metrics, :identifier, :string # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20180901200537_add_resource_label_event_reference_fields.rb b/db/migrate/20180901200537_add_resource_label_event_reference_fields.rb
index c8875e16914..2dc86e1ac9a 100644
--- a/db/migrate/20180901200537_add_resource_label_event_reference_fields.rb
+++ b/db/migrate/20180901200537_add_resource_label_event_reference_fields.rb
@@ -3,9 +3,11 @@
class AddResourceLabelEventReferenceFields < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
add_column :resource_label_events, :cached_markdown_version, :integer
add_column :resource_label_events, :reference, :text
add_column :resource_label_events, :reference_html, :text
end
+ # rubocop:enable Migration/AddLimitToTextColumns
end
diff --git a/db/migrate/20180910115836_add_attr_encrypted_columns_to_web_hook.rb b/db/migrate/20180910115836_add_attr_encrypted_columns_to_web_hook.rb
index 9757f7fdc79..3341fd5c593 100644
--- a/db/migrate/20180910115836_add_attr_encrypted_columns_to_web_hook.rb
+++ b/db/migrate/20180910115836_add_attr_encrypted_columns_to_web_hook.rb
@@ -5,13 +5,13 @@ class AddAttrEncryptedColumnsToWebHook < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
add_column :web_hooks, :encrypted_token, :string
add_column :web_hooks, :encrypted_token_iv, :string
add_column :web_hooks, :encrypted_url, :string
add_column :web_hooks, :encrypted_url_iv, :string
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20180910153412_add_token_digest_to_personal_access_tokens.rb b/db/migrate/20180910153412_add_token_digest_to_personal_access_tokens.rb
index 52923f52499..4ed31bf7f39 100644
--- a/db/migrate/20180910153412_add_token_digest_to_personal_access_tokens.rb
+++ b/db/migrate/20180910153412_add_token_digest_to_personal_access_tokens.rb
@@ -8,7 +8,7 @@ class AddTokenDigestToPersonalAccessTokens < ActiveRecord::Migration[4.2]
def up
change_column :personal_access_tokens, :token, :string, null: true
- add_column :personal_access_tokens, :token_digest, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :personal_access_tokens, :token_digest, :string # rubocop:disable Migration/PreventStrings
end
def down
diff --git a/db/migrate/20180912111628_add_knative_application.rb b/db/migrate/20180912111628_add_knative_application.rb
index 7c55de02d1c..cd2512cc17a 100644
--- a/db/migrate/20180912111628_add_knative_application.rb
+++ b/db/migrate/20180912111628_add_knative_application.rb
@@ -5,8 +5,8 @@ class AddKnativeApplication < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table "clusters_applications_knative" do |t|
t.references :cluster, null: false, unique: true, foreign_key: { on_delete: :cascade }
@@ -15,8 +15,8 @@ class AddKnativeApplication < ActiveRecord::Migration[4.2]
t.integer "status", null: false
t.string "version", null: false
t.string "hostname"
- t.text "status_reason"
+ t.text "status_reason" # rubocop:disable Migration/AddLimitToTextColumns
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181009190428_create_clusters_kubernetes_namespaces.rb b/db/migrate/20181009190428_create_clusters_kubernetes_namespaces.rb
index b6ffb2866aa..42d0899fe31 100644
--- a/db/migrate/20181009190428_create_clusters_kubernetes_namespaces.rb
+++ b/db/migrate/20181009190428_create_clusters_kubernetes_namespaces.rb
@@ -4,8 +4,8 @@ class CreateClustersKubernetesNamespaces < ActiveRecord::Migration[4.2]
DOWNTIME = false
INDEX_NAME = 'kubernetes_namespaces_cluster_and_namespace'
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :clusters_kubernetes_namespaces, id: :bigserial do |t|
t.references :cluster, null: false, index: true, foreign_key: { on_delete: :cascade }
t.references :project, index: true, foreign_key: { on_delete: :nullify }
@@ -17,10 +17,10 @@ class CreateClustersKubernetesNamespaces < ActiveRecord::Migration[4.2]
t.string :namespace, null: false
t.string :service_account_name
- t.text :encrypted_service_account_token
+ t.text :encrypted_service_account_token # rubocop:disable Migration/AddLimitToTextColumns
t.index [:cluster_id, :namespace], name: INDEX_NAME, unique: true
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181019032400_add_shards_table.rb b/db/migrate/20181019032400_add_shards_table.rb
index 82287e5c3b5..713039c1a15 100644
--- a/db/migrate/20181019032400_add_shards_table.rb
+++ b/db/migrate/20181019032400_add_shards_table.rb
@@ -5,7 +5,7 @@ class AddShardsTable < ActiveRecord::Migration[4.2]
def change
create_table :shards do |t|
- t.string :name, null: false, index: { unique: true } # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :name, null: false, index: { unique: true } # rubocop:disable Migration/PreventStrings
end
end
end
diff --git a/db/migrate/20181019032408_add_repositories_table.rb b/db/migrate/20181019032408_add_repositories_table.rb
index 5ee31b37b66..d4d3acf7029 100644
--- a/db/migrate/20181019032408_add_repositories_table.rb
+++ b/db/migrate/20181019032408_add_repositories_table.rb
@@ -6,7 +6,7 @@ class AddRepositoriesTable < ActiveRecord::Migration[4.2]
def change
create_table :repositories, id: :bigserial do |t|
t.references :shard, null: false, index: true, foreign_key: { on_delete: :restrict }
- t.string :disk_path, null: false, index: { unique: true } # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :disk_path, null: false, index: { unique: true } # rubocop:disable Migration/PreventStrings
end
add_column :projects, :pool_repository_id, :bigint # rubocop:disable Migration/AddColumnsToWideTables
diff --git a/db/migrate/20181025115728_add_private_commit_email_hostname_to_application_settings.rb b/db/migrate/20181025115728_add_private_commit_email_hostname_to_application_settings.rb
index c0e4897b8d7..0923975f43a 100644
--- a/db/migrate/20181025115728_add_private_commit_email_hostname_to_application_settings.rb
+++ b/db/migrate/20181025115728_add_private_commit_email_hostname_to_application_settings.rb
@@ -5,7 +5,9 @@ class AddPrivateCommitEmailHostnameToApplicationSettings < ActiveRecord::Migrati
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column(:application_settings, :commit_email_hostname, :string, null: true) # rubocop:disable Migration/AddLimitToStringColumns
+ add_column(:application_settings, :commit_email_hostname, :string, null: true)
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181031190559_drop_gcp_clusters_table.rb b/db/migrate/20181031190559_drop_gcp_clusters_table.rb
index 850fa93c75a..597fe49f4c8 100644
--- a/db/migrate/20181031190559_drop_gcp_clusters_table.rb
+++ b/db/migrate/20181031190559_drop_gcp_clusters_table.rb
@@ -10,7 +10,6 @@ class DropGcpClustersTable < ActiveRecord::Migration[4.2]
end
def down
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :gcp_clusters do |t|
# Order columns by best align scheme
t.references :project, null: false, index: { unique: true }, foreign_key: { on_delete: :cascade }
@@ -50,6 +49,5 @@ class DropGcpClustersTable < ActiveRecord::Migration[4.2]
t.text :encrypted_gcp_token
t.string :encrypted_gcp_token_iv
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
end
diff --git a/db/migrate/20181101191341_create_clusters_applications_cert_manager.rb b/db/migrate/20181101191341_create_clusters_applications_cert_manager.rb
index 3bc20046311..95996531669 100644
--- a/db/migrate/20181101191341_create_clusters_applications_cert_manager.rb
+++ b/db/migrate/20181101191341_create_clusters_applications_cert_manager.rb
@@ -5,17 +5,17 @@ class CreateClustersApplicationsCertManager < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :clusters_applications_cert_managers do |t|
t.references :cluster, null: false, index: false, foreign_key: { on_delete: :cascade }
t.integer :status, null: false
t.string :version, null: false
t.string :email, null: false
t.timestamps_with_timezone null: false
- t.text :status_reason
+ t.text :status_reason # rubocop:disable Migration/AddLimitToTextColumns
t.index :cluster_id, unique: true
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181115140140_add_encrypted_runners_token_to_settings.rb b/db/migrate/20181115140140_add_encrypted_runners_token_to_settings.rb
index 124eedf7933..abb720dafb2 100644
--- a/db/migrate/20181115140140_add_encrypted_runners_token_to_settings.rb
+++ b/db/migrate/20181115140140_add_encrypted_runners_token_to_settings.rb
@@ -5,7 +5,9 @@ class AddEncryptedRunnersTokenToSettings < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :application_settings, :runners_registration_token_encrypted, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :application_settings, :runners_registration_token_encrypted, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181116050532_knative_external_ip.rb b/db/migrate/20181116050532_knative_external_ip.rb
index 4634b411108..4179e13c1b8 100644
--- a/db/migrate/20181116050532_knative_external_ip.rb
+++ b/db/migrate/20181116050532_knative_external_ip.rb
@@ -8,7 +8,9 @@ class KnativeExternalIp < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :clusters_applications_knative, :external_ip, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :clusters_applications_knative, :external_ip, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181116141415_add_encrypted_runners_token_to_namespaces.rb b/db/migrate/20181116141415_add_encrypted_runners_token_to_namespaces.rb
index 0a8ed912891..00c88140b52 100644
--- a/db/migrate/20181116141415_add_encrypted_runners_token_to_namespaces.rb
+++ b/db/migrate/20181116141415_add_encrypted_runners_token_to_namespaces.rb
@@ -5,7 +5,9 @@ class AddEncryptedRunnersTokenToNamespaces < ActiveRecord::Migration[4.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :namespaces, :runners_token_encrypted, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :namespaces, :runners_token_encrypted, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181116141504_add_encrypted_runners_token_to_projects.rb b/db/migrate/20181116141504_add_encrypted_runners_token_to_projects.rb
index f6986fcdfeb..f42239475f7 100644
--- a/db/migrate/20181116141504_add_encrypted_runners_token_to_projects.rb
+++ b/db/migrate/20181116141504_add_encrypted_runners_token_to_projects.rb
@@ -6,10 +6,10 @@ class AddEncryptedRunnersTokenToProjects < ActiveRecord::Migration[4.2]
DOWNTIME = false
# rubocop:disable Migration/AddColumnsToWideTables
- # rubocop:disable Migration/AddLimitToStringColumns
+ # rubocop:disable Migration/PreventStrings
def change
add_column :projects, :runners_token_encrypted, :string
end
+ # rubocop:enable Migration/PreventStrings
# rubocop:enable Migration/AddColumnsToWideTables
- # rubocop:enable Migration/AddLimitToStringColumns
end
diff --git a/db/migrate/20181120151656_add_token_encrypted_to_ci_runners.rb b/db/migrate/20181120151656_add_token_encrypted_to_ci_runners.rb
index 2270246dfb4..2b78d390907 100644
--- a/db/migrate/20181120151656_add_token_encrypted_to_ci_runners.rb
+++ b/db/migrate/20181120151656_add_token_encrypted_to_ci_runners.rb
@@ -6,6 +6,6 @@ class AddTokenEncryptedToCiRunners < ActiveRecord::Migration[4.2]
DOWNTIME = false
def change
- add_column :ci_runners, :token_encrypted, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :ci_runners, :token_encrypted, :string # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20181122160027_create_project_repositories.rb b/db/migrate/20181122160027_create_project_repositories.rb
index 3f123daa150..9148cde2fb4 100644
--- a/db/migrate/20181122160027_create_project_repositories.rb
+++ b/db/migrate/20181122160027_create_project_repositories.rb
@@ -11,7 +11,7 @@ class CreateProjectRepositories < ActiveRecord::Migration[5.0]
def change
create_table :project_repositories, id: :bigserial do |t|
t.references :shard, null: false, index: true, foreign_key: { on_delete: :restrict }
- t.string :disk_path, null: false, index: { unique: true } # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :disk_path, null: false, index: { unique: true } # rubocop:disable Migration/PreventStrings
t.references :project, null: false, index: { unique: true }, foreign_key: { on_delete: :cascade }
end
end
diff --git a/db/migrate/20181123144235_create_suggestions.rb b/db/migrate/20181123144235_create_suggestions.rb
index 78888517db5..b92e8ac8027 100644
--- a/db/migrate/20181123144235_create_suggestions.rb
+++ b/db/migrate/20181123144235_create_suggestions.rb
@@ -3,12 +3,14 @@
class CreateSuggestions < ActiveRecord::Migration[5.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
create_table :suggestions, id: :bigserial do |t|
t.references :note, foreign_key: { on_delete: :cascade }, null: false
t.integer :relative_order, null: false, limit: 2
t.boolean :applied, null: false, default: false
- t.string :commit_id # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :commit_id
t.text :from_content, null: false
t.text :to_content, null: false
@@ -17,4 +19,6 @@ class CreateSuggestions < ActiveRecord::Migration[5.0]
unique: true
end
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181128123704_add_state_to_pool_repository.rb b/db/migrate/20181128123704_add_state_to_pool_repository.rb
index 04bbcf24f62..4d4e56390df 100644
--- a/db/migrate/20181128123704_add_state_to_pool_repository.rb
+++ b/db/migrate/20181128123704_add_state_to_pool_repository.rb
@@ -7,13 +7,17 @@ class AddStateToPoolRepository < ActiveRecord::Migration[5.0]
# Given the table is empty, and the non concurrent methods are chosen so
# the transactions don't have to be disabled
- # rubocop: disable Migration/AddConcurrentForeignKey, Migration/AddIndex
+ # rubocop:disable Migration/AddConcurrentForeignKey
+ # rubocop:disable Migration/AddIndex
+ # rubocop:disable Migration/PreventStrings
def change
- add_column(:pool_repositories, :state, :string, null: true) # rubocop:disable Migration/AddLimitToStringColumns
+ add_column(:pool_repositories, :state, :string, null: true)
add_column :pool_repositories, :source_project_id, :integer
add_index :pool_repositories, :source_project_id, unique: true
add_foreign_key :pool_repositories, :projects, column: :source_project_id, on_delete: :nullify
end
- # rubocop: enable Migration/AddConcurrentForeignKey, Migration/AddIndex
+ # rubocop:enable Migration/PreventStrings
+ # rubocop:enable Migration/AddIndex
+ # rubocop:enable Migration/AddConcurrentForeignKey
end
diff --git a/db/migrate/20181129104854_add_token_encrypted_to_ci_builds.rb b/db/migrate/20181129104854_add_token_encrypted_to_ci_builds.rb
index 097cc59bcdc..b83cabd6b75 100644
--- a/db/migrate/20181129104854_add_token_encrypted_to_ci_builds.rb
+++ b/db/migrate/20181129104854_add_token_encrypted_to_ci_builds.rb
@@ -6,10 +6,10 @@ class AddTokenEncryptedToCiBuilds < ActiveRecord::Migration[5.0]
DOWNTIME = false
# rubocop:disable Migration/AddColumnsToWideTables
- # rubocop:disable Migration/AddLimitToStringColumns
+ # rubocop:disable Migration/PreventStrings
def change
add_column :ci_builds, :token_encrypted, :string
end
+ # rubocop:enable Migration/PreventStrings
# rubocop:enable Migration/AddColumnsToWideTables
- # rubocop:enable Migration/AddLimitToStringColumns
end
diff --git a/db/migrate/20181203002526_add_project_bfg_object_map_column.rb b/db/migrate/20181203002526_add_project_bfg_object_map_column.rb
index d8c4fe1ecf6..7850f314ca8 100644
--- a/db/migrate/20181203002526_add_project_bfg_object_map_column.rb
+++ b/db/migrate/20181203002526_add_project_bfg_object_map_column.rb
@@ -4,10 +4,10 @@ class AddProjectBfgObjectMapColumn < ActiveRecord::Migration[5.0]
DOWNTIME = false
# rubocop:disable Migration/AddColumnsToWideTables
- # rubocop:disable Migration/AddLimitToStringColumns
+ # rubocop:disable Migration/PreventStrings
def change
add_column :projects, :bfg_object_map, :string
end
+ # rubocop:enable Migration/PreventStrings
# rubocop:enable Migration/AddColumnsToWideTables
- # rubocop:enable Migration/AddLimitToStringColumns
end
diff --git a/db/migrate/20181211092510_add_name_author_id_and_sha_to_releases.rb b/db/migrate/20181211092510_add_name_author_id_and_sha_to_releases.rb
index 3ab808ba667..79711d13cfe 100644
--- a/db/migrate/20181211092510_add_name_author_id_and_sha_to_releases.rb
+++ b/db/migrate/20181211092510_add_name_author_id_and_sha_to_releases.rb
@@ -5,9 +5,11 @@ class AddNameAuthorIdAndShaToReleases < ActiveRecord::Migration[5.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :releases, :author_id, :integer
- add_column :releases, :name, :string # rubocop:disable Migration/AddLimitToStringColumns
- add_column :releases, :sha, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :releases, :name, :string
+ add_column :releases, :sha, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181212171634_create_error_tracking_settings.rb b/db/migrate/20181212171634_create_error_tracking_settings.rb
index 950b9a88005..567abe6f45f 100644
--- a/db/migrate/20181212171634_create_error_tracking_settings.rb
+++ b/db/migrate/20181212171634_create_error_tracking_settings.rb
@@ -5,8 +5,8 @@ class CreateErrorTrackingSettings < ActiveRecord::Migration[5.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :project_error_tracking_settings, id: :int, primary_key: :project_id, default: nil do |t|
t.boolean :enabled, null: false, default: true
t.string :api_url, null: false
@@ -14,6 +14,6 @@ class CreateErrorTrackingSettings < ActiveRecord::Migration[5.0]
t.string :encrypted_token_iv
t.foreign_key :projects, column: :project_id, on_delete: :cascade
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20181228175414_create_releases_link_table.rb b/db/migrate/20181228175414_create_releases_link_table.rb
index 168c4722cc1..9d770d0dc2f 100644
--- a/db/migrate/20181228175414_create_releases_link_table.rb
+++ b/db/migrate/20181228175414_create_releases_link_table.rb
@@ -5,8 +5,8 @@ class CreateReleasesLinkTable < ActiveRecord::Migration[5.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :release_links, id: :bigserial do |t|
t.references :release, null: false, index: false, foreign_key: { on_delete: :cascade }
t.string :url, null: false
@@ -16,6 +16,6 @@ class CreateReleasesLinkTable < ActiveRecord::Migration[5.0]
t.index [:release_id, :url], unique: true
t.index [:release_id, :name], unique: true
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190109153125_add_merge_request_external_diffs.rb b/db/migrate/20190109153125_add_merge_request_external_diffs.rb
index a680856a3d8..d787e78142a 100644
--- a/db/migrate/20190109153125_add_merge_request_external_diffs.rb
+++ b/db/migrate/20190109153125_add_merge_request_external_diffs.rb
@@ -11,7 +11,7 @@ class AddMergeRequestExternalDiffs < ActiveRecord::Migration[5.0]
def change
# Allow the merge request diff to store details about an external file
- add_column :merge_request_diffs, :external_diff, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :merge_request_diffs, :external_diff, :string # rubocop:disable Migration/PreventStrings
add_column :merge_request_diffs, :external_diff_store, :integer
add_column :merge_request_diffs, :stored_externally, :boolean
diff --git a/db/migrate/20190114172110_add_domain_to_cluster.rb b/db/migrate/20190114172110_add_domain_to_cluster.rb
index d8f10af9cad..ebe588d8b77 100644
--- a/db/migrate/20190114172110_add_domain_to_cluster.rb
+++ b/db/migrate/20190114172110_add_domain_to_cluster.rb
@@ -4,6 +4,6 @@ class AddDomainToCluster < ActiveRecord::Migration[5.0]
DOWNTIME = false
def change
- add_column :clusters, :domain, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :clusters, :domain, :string # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20190115092821_add_columns_project_error_tracking_settings.rb b/db/migrate/20190115092821_add_columns_project_error_tracking_settings.rb
index afed929cce4..ee6d63b558f 100644
--- a/db/migrate/20190115092821_add_columns_project_error_tracking_settings.rb
+++ b/db/migrate/20190115092821_add_columns_project_error_tracking_settings.rb
@@ -5,12 +5,14 @@ class AddColumnsProjectErrorTrackingSettings < ActiveRecord::Migration[5.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :project_error_tracking_settings, :project_name, :string # rubocop:disable Migration/AddLimitToStringColumns
- add_column :project_error_tracking_settings, :organization_name, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :project_error_tracking_settings, :project_name, :string
+ add_column :project_error_tracking_settings, :organization_name, :string
change_column_default :project_error_tracking_settings, :enabled, from: true, to: false
change_column_null :project_error_tracking_settings, :api_url, true
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190116234221_add_sorting_fields_to_user_preference.rb b/db/migrate/20190116234221_add_sorting_fields_to_user_preference.rb
index 39aab600546..5d33f6f4339 100644
--- a/db/migrate/20190116234221_add_sorting_fields_to_user_preference.rb
+++ b/db/migrate/20190116234221_add_sorting_fields_to_user_preference.rb
@@ -9,10 +9,12 @@ class AddSortingFieldsToUserPreference < ActiveRecord::Migration[5.0]
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
- add_column :user_preferences, :issues_sort, :string # rubocop:disable Migration/AddLimitToStringColumns
- add_column :user_preferences, :merge_requests_sort, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :user_preferences, :issues_sort, :string
+ add_column :user_preferences, :merge_requests_sort, :string
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column :user_preferences, :issues_sort
diff --git a/db/migrate/20190219201635_add_asset_proxy_settings.rb b/db/migrate/20190219201635_add_asset_proxy_settings.rb
index 9de38cf8a89..173b2916c4d 100644
--- a/db/migrate/20190219201635_add_asset_proxy_settings.rb
+++ b/db/migrate/20190219201635_add_asset_proxy_settings.rb
@@ -6,11 +6,15 @@ class AddAssetProxySettings < ActiveRecord::Migration[5.0]
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
add_column :application_settings, :asset_proxy_enabled, :boolean, default: false, null: false
- add_column :application_settings, :asset_proxy_url, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :application_settings, :asset_proxy_url, :string
add_column :application_settings, :asset_proxy_whitelist, :text
add_column :application_settings, :encrypted_asset_proxy_secret_key, :text
- add_column :application_settings, :encrypted_asset_proxy_secret_key_iv, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :application_settings, :encrypted_asset_proxy_secret_key_iv, :string
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190301182457_add_external_hostname_to_ingress_and_knative.rb b/db/migrate/20190301182457_add_external_hostname_to_ingress_and_knative.rb
index 37ba1090cf0..4cb6053fbe1 100644
--- a/db/migrate/20190301182457_add_external_hostname_to_ingress_and_knative.rb
+++ b/db/migrate/20190301182457_add_external_hostname_to_ingress_and_knative.rb
@@ -3,8 +3,10 @@
class AddExternalHostnameToIngressAndKnative < ActiveRecord::Migration[5.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :clusters_applications_ingress, :external_hostname, :string # rubocop:disable Migration/AddLimitToStringColumns
- add_column :clusters_applications_knative, :external_hostname, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :clusters_applications_ingress, :external_hostname, :string
+ add_column :clusters_applications_knative, :external_hostname, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190320174702_add_lets_encrypt_notification_email_to_application_settings.rb b/db/migrate/20190320174702_add_lets_encrypt_notification_email_to_application_settings.rb
index aeabf4e3cb4..e0ec10ca204 100644
--- a/db/migrate/20190320174702_add_lets_encrypt_notification_email_to_application_settings.rb
+++ b/db/migrate/20190320174702_add_lets_encrypt_notification_email_to_application_settings.rb
@@ -9,7 +9,9 @@ class AddLetsEncryptNotificationEmailToApplicationSettings < ActiveRecord::Migra
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :application_settings, :lets_encrypt_notification_email, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :application_settings, :lets_encrypt_notification_email, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190325105715_add_fields_to_user_preferences.rb b/db/migrate/20190325105715_add_fields_to_user_preferences.rb
index 4da5c496147..78ccbd65c84 100644
--- a/db/migrate/20190325105715_add_fields_to_user_preferences.rb
+++ b/db/migrate/20190325105715_add_fields_to_user_preferences.rb
@@ -11,7 +11,7 @@ class AddFieldsToUserPreferences < ActiveRecord::Migration[5.0]
DOWNTIME = false
def up
- add_column(:user_preferences, :timezone, :string) # rubocop:disable Migration/AddLimitToStringColumns
+ add_column(:user_preferences, :timezone, :string) # rubocop:disable Migration/PreventStrings
add_column(:user_preferences, :time_display_relative, :boolean)
add_column(:user_preferences, :time_format_in_24h, :boolean)
end
diff --git a/db/migrate/20190327163904_add_notification_email_to_notification_settings.rb b/db/migrate/20190327163904_add_notification_email_to_notification_settings.rb
index d912f922510..d8a7e96f902 100644
--- a/db/migrate/20190327163904_add_notification_email_to_notification_settings.rb
+++ b/db/migrate/20190327163904_add_notification_email_to_notification_settings.rb
@@ -5,7 +5,9 @@ class AddNotificationEmailToNotificationSettings < ActiveRecord::Migration[5.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :notification_settings, :notification_email, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :notification_settings, :notification_email, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190402150158_backport_enterprise_schema.rb b/db/migrate/20190402150158_backport_enterprise_schema.rb
index d1e911a04e6..a9be1dfbadc 100644
--- a/db/migrate/20190402150158_backport_enterprise_schema.rb
+++ b/db/migrate/20190402150158_backport_enterprise_schema.rb
@@ -2,7 +2,8 @@
# rubocop: disable Metrics/AbcSize
# rubocop: disable Migration/Datetime
-# rubocop: disable Migration/AddLimitToStringColumns
+# rubocop: disable Migration/PreventStrings
+# rubocop: disable Migration/AddLimitToTextColumns
class BackportEnterpriseSchema < ActiveRecord::Migration[5.0]
include Gitlab::Database::MigrationHelpers
@@ -2188,4 +2189,5 @@ class BackportEnterpriseSchema < ActiveRecord::Migration[5.0]
end
# rubocop: enable Metrics/AbcSize
# rubocop: enable Migration/Datetime
-# rubocop: enable Migration/AddLimitToStringColumns
+# rubocop: enable Migration/PreventStrings
+# rubocop: enable Migration/AddLimitToTextColumns
diff --git a/db/migrate/20190409224933_add_name_to_geo_nodes.rb b/db/migrate/20190409224933_add_name_to_geo_nodes.rb
index 65c01683995..ac3eda701d1 100644
--- a/db/migrate/20190409224933_add_name_to_geo_nodes.rb
+++ b/db/migrate/20190409224933_add_name_to_geo_nodes.rb
@@ -10,7 +10,7 @@ class AddNameToGeoNodes < ActiveRecord::Migration[5.0]
DOWNTIME = false
def up
- add_column :geo_nodes, :name, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :geo_nodes, :name, :string # rubocop:disable Migration/PreventStrings
# url is also unique, and its type and size is identical to the name column,
# so this is safe.
diff --git a/db/migrate/20190414185432_add_comment_to_vulnerability_feedback.rb b/db/migrate/20190414185432_add_comment_to_vulnerability_feedback.rb
index 63644a2f8fd..f2047e21d1e 100644
--- a/db/migrate/20190414185432_add_comment_to_vulnerability_feedback.rb
+++ b/db/migrate/20190414185432_add_comment_to_vulnerability_feedback.rb
@@ -5,7 +5,7 @@ class AddCommentToVulnerabilityFeedback < ActiveRecord::Migration[5.1]
def up
add_column :vulnerability_feedback, :comment_author_id, :integer
- add_column :vulnerability_feedback, :comment, :text
+ add_column :vulnerability_feedback, :comment, :text # rubocop:disable Migration/AddLimitToTextColumns
add_column :vulnerability_feedback, :comment_timestamp, :datetime_with_timezone
end
diff --git a/db/migrate/20190422082247_create_project_metrics_settings.rb b/db/migrate/20190422082247_create_project_metrics_settings.rb
index a0a2ed64820..177c4820a0c 100644
--- a/db/migrate/20190422082247_create_project_metrics_settings.rb
+++ b/db/migrate/20190422082247_create_project_metrics_settings.rb
@@ -7,7 +7,7 @@ class CreateProjectMetricsSettings < ActiveRecord::Migration[5.0]
def change
create_table :project_metrics_settings, id: :int, primary_key: :project_id, default: nil do |t|
- t.string :external_dashboard_url, null: false # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :external_dashboard_url, null: false # rubocop:disable Migration/PreventStrings
t.foreign_key :projects, column: :project_id, on_delete: :cascade
end
end
diff --git a/db/migrate/20190429082448_create_pages_domain_acme_orders.rb b/db/migrate/20190429082448_create_pages_domain_acme_orders.rb
index ca1796d054c..75636031193 100644
--- a/db/migrate/20190429082448_create_pages_domain_acme_orders.rb
+++ b/db/migrate/20190429082448_create_pages_domain_acme_orders.rb
@@ -9,8 +9,9 @@ class CreatePagesDomainAcmeOrders < ActiveRecord::Migration[5.1]
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :pages_domain_acme_orders do |t|
t.references :pages_domain, null: false, index: true, foreign_key: { on_delete: :cascade }, type: :integer
@@ -25,6 +26,7 @@ class CreatePagesDomainAcmeOrders < ActiveRecord::Migration[5.1]
t.text :encrypted_private_key, null: false
t.text :encrypted_private_key_iv, null: false
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190430131225_create_issue_tracker_data.rb b/db/migrate/20190430131225_create_issue_tracker_data.rb
index d2134ad82c7..2ec9802dbcd 100644
--- a/db/migrate/20190430131225_create_issue_tracker_data.rb
+++ b/db/migrate/20190430131225_create_issue_tracker_data.rb
@@ -8,8 +8,8 @@ class CreateIssueTrackerData < ActiveRecord::Migration[5.1]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :issue_tracker_data do |t|
t.references :service, foreign_key: { on_delete: :cascade }, type: :integer, index: true, null: false
t.timestamps_with_timezone
@@ -20,6 +20,6 @@ class CreateIssueTrackerData < ActiveRecord::Migration[5.1]
t.string :encrypted_new_issue_url
t.string :encrypted_new_issue_url_iv
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190430142025_create_jira_tracker_data.rb b/db/migrate/20190430142025_create_jira_tracker_data.rb
index 5e53e5a701a..2144c60a267 100644
--- a/db/migrate/20190430142025_create_jira_tracker_data.rb
+++ b/db/migrate/20190430142025_create_jira_tracker_data.rb
@@ -8,8 +8,8 @@ class CreateJiraTrackerData < ActiveRecord::Migration[5.1]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :jira_tracker_data do |t|
t.references :service, foreign_key: { on_delete: :cascade }, type: :integer, index: true, null: false
t.timestamps_with_timezone
@@ -23,6 +23,6 @@ class CreateJiraTrackerData < ActiveRecord::Migration[5.1]
t.string :encrypted_password_iv
t.string :jira_issue_transition_id
end
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190514105711_create_ip_restriction.rb b/db/migrate/20190514105711_create_ip_restriction.rb
index 69f8c1b8c4e..51e711ca32b 100644
--- a/db/migrate/20190514105711_create_ip_restriction.rb
+++ b/db/migrate/20190514105711_create_ip_restriction.rb
@@ -12,7 +12,7 @@ class CreateIpRestriction < ActiveRecord::Migration[5.1]
type: :integer,
null: false,
index: true
- t.string :range, null: false # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :range, null: false # rubocop:disable Migration/PreventStrings
end
add_foreign_key(:ip_restrictions, :namespaces, column: :group_id, on_delete: :cascade) # rubocop: disable Migration/AddConcurrentForeignKey
diff --git a/db/migrate/20190516151857_add_lets_encrypt_private_key_to_application_settings.rb b/db/migrate/20190516151857_add_lets_encrypt_private_key_to_application_settings.rb
index e1d3cca48d6..a2692ad32e9 100644
--- a/db/migrate/20190516151857_add_lets_encrypt_private_key_to_application_settings.rb
+++ b/db/migrate/20190516151857_add_lets_encrypt_private_key_to_application_settings.rb
@@ -9,8 +9,10 @@ class AddLetsEncryptPrivateKeyToApplicationSettings < ActiveRecord::Migration[5.
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
add_column :application_settings, :encrypted_lets_encrypt_private_key, :text
add_column :application_settings, :encrypted_lets_encrypt_private_key_iv, :text
end
+ # rubocop:enable Migration/AddLimitToTextColumns
end
diff --git a/db/migrate/20190527011309_add_required_template_name_to_application_settings.rb b/db/migrate/20190527011309_add_required_template_name_to_application_settings.rb
index 5c47e6f33c2..9e0f5c5b1e7 100644
--- a/db/migrate/20190527011309_add_required_template_name_to_application_settings.rb
+++ b/db/migrate/20190527011309_add_required_template_name_to_application_settings.rb
@@ -9,7 +9,9 @@ class AddRequiredTemplateNameToApplicationSettings < ActiveRecord::Migration[5.1
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :application_settings, :required_instance_ci_template, :string, null: true # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :application_settings, :required_instance_ci_template, :string, null: true
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190606054742_add_token_encrypted_to_operations_feature_flags_clients.rb b/db/migrate/20190606054742_add_token_encrypted_to_operations_feature_flags_clients.rb
index 2db4dc85750..01cd49ac219 100644
--- a/db/migrate/20190606054742_add_token_encrypted_to_operations_feature_flags_clients.rb
+++ b/db/migrate/20190606054742_add_token_encrypted_to_operations_feature_flags_clients.rb
@@ -5,7 +5,9 @@ class AddTokenEncryptedToOperationsFeatureFlagsClients < ActiveRecord::Migration
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :operations_feature_flags_clients, :token_encrypted, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :operations_feature_flags_clients, :token_encrypted, :string
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190606202100_add_name_to_badges.rb b/db/migrate/20190606202100_add_name_to_badges.rb
index 472e1202ad8..7b386a6e690 100644
--- a/db/migrate/20190606202100_add_name_to_badges.rb
+++ b/db/migrate/20190606202100_add_name_to_badges.rb
@@ -6,6 +6,6 @@ class AddNameToBadges < ActiveRecord::Migration[5.0]
DOWNTIME = false
def change
- add_column :badges, :name, :string, null: true, limit: 255
+ add_column :badges, :name, :string, null: true, limit: 255 # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20190611161641_add_target_project_id_to_merge_trains.rb b/db/migrate/20190611161641_add_target_project_id_to_merge_trains.rb
index 553e9371ab3..7b73202ab8d 100644
--- a/db/migrate/20190611161641_add_target_project_id_to_merge_trains.rb
+++ b/db/migrate/20190611161641_add_target_project_id_to_merge_trains.rb
@@ -5,10 +5,14 @@ class AddTargetProjectIdToMergeTrains < ActiveRecord::Migration[5.1]
DOWNTIME = false
+ # rubocop:disable Rails/NotNullColumn
+ # rubocop:disable Migration/AddReference
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
- # rubocop:disable Rails/NotNullColumn, Migration/AddReference
add_reference :merge_trains, :target_project, null: false, index: true, foreign_key: { on_delete: :cascade, to_table: :projects }, type: :integer
add_column :merge_trains, :target_branch, :text, null: false
- # rubocop:enable Rails/NotNullColumn, Migration/AddReference
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/AddReference
+ # rubocop:enable Rails/NotNullColumn
end
diff --git a/db/migrate/20190613044655_add_username_to_deploy_tokens.rb b/db/migrate/20190613044655_add_username_to_deploy_tokens.rb
index a0acb02013b..ac5a6589f07 100644
--- a/db/migrate/20190613044655_add_username_to_deploy_tokens.rb
+++ b/db/migrate/20190613044655_add_username_to_deploy_tokens.rb
@@ -4,6 +4,6 @@ class AddUsernameToDeployTokens < ActiveRecord::Migration[5.1]
DOWNTIME = false
def change
- add_column :deploy_tokens, :username, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :deploy_tokens, :username, :string # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20190613073003_create_project_aliases.rb b/db/migrate/20190613073003_create_project_aliases.rb
index 896d3ca5813..ee111d437e9 100644
--- a/db/migrate/20190613073003_create_project_aliases.rb
+++ b/db/migrate/20190613073003_create_project_aliases.rb
@@ -8,7 +8,7 @@ class CreateProjectAliases < ActiveRecord::Migration[5.1]
def change
create_table :project_aliases do |t|
t.references :project, null: false, index: true, foreign_key: { on_delete: :cascade }, type: :integer
- t.string :name, null: false, index: { unique: true } # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :name, null: false, index: { unique: true } # rubocop:disable Migration/PreventStrings
t.timestamps_with_timezone null: false
end
diff --git a/db/migrate/20190621151636_add_merge_request_rebase_jid.rb b/db/migrate/20190621151636_add_merge_request_rebase_jid.rb
index 6c1081732e8..df1b1c79375 100644
--- a/db/migrate/20190621151636_add_merge_request_rebase_jid.rb
+++ b/db/migrate/20190621151636_add_merge_request_rebase_jid.rb
@@ -4,6 +4,6 @@ class AddMergeRequestRebaseJid < ActiveRecord::Migration[5.1]
DOWNTIME = false
def change
- add_column :merge_requests, :rebase_jid, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :merge_requests, :rebase_jid, :string # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20190624123615_add_grafana_url_to_settings.rb b/db/migrate/20190624123615_add_grafana_url_to_settings.rb
index 835ec4e9094..0b25c053d57 100644
--- a/db/migrate/20190624123615_add_grafana_url_to_settings.rb
+++ b/db/migrate/20190624123615_add_grafana_url_to_settings.rb
@@ -7,12 +7,12 @@ class AddGrafanaUrlToSettings < ActiveRecord::Migration[5.1]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
- # rubocop:disable Migration/AddLimitToStringColumns
add_column_with_default(:application_settings, :grafana_url, :string,
default: '/-/grafana', allow_null: false)
- # rubocop:enable Migration/AddLimitToStringColumns
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column(:application_settings, :grafana_url)
diff --git a/db/migrate/20190625115224_add_description_to_services.rb b/db/migrate/20190625115224_add_description_to_services.rb
index d5ef3900462..bdd6d70cb0f 100644
--- a/db/migrate/20190625115224_add_description_to_services.rb
+++ b/db/migrate/20190625115224_add_description_to_services.rb
@@ -9,6 +9,6 @@ class AddDescriptionToServices < ActiveRecord::Migration[5.1]
DOWNTIME = false
def change
- add_column :services, :description, :string, limit: 500
+ add_column :services, :description, :string, limit: 500 # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20190711124721_create_job_variables.rb b/db/migrate/20190711124721_create_job_variables.rb
index 4ff4b031d8f..6174afc236c 100644
--- a/db/migrate/20190711124721_create_job_variables.rb
+++ b/db/migrate/20190711124721_create_job_variables.rb
@@ -9,8 +9,9 @@ class CreateJobVariables < ActiveRecord::Migration[5.1]
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
- # rubocop:disable Migration/AddLimitToStringColumns
create_table :ci_job_variables do |t|
t.string :key, null: false
t.text :encrypted_value
@@ -18,8 +19,9 @@ class CreateJobVariables < ActiveRecord::Migration[5.1]
t.references :job, null: false, index: true, foreign_key: { to_table: :ci_builds, on_delete: :cascade }
t.integer :variable_type, null: false, limit: 2, default: 1
end
- # rubocop:enable Migration/AddLimitToStringColumns
add_index :ci_job_variables, [:key, :job_id], unique: true
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190711200508_add_token_encrypted_to_deploy_tokens.rb b/db/migrate/20190711200508_add_token_encrypted_to_deploy_tokens.rb
index ea0956fdf7f..dff682e8ce7 100644
--- a/db/migrate/20190711200508_add_token_encrypted_to_deploy_tokens.rb
+++ b/db/migrate/20190711200508_add_token_encrypted_to_deploy_tokens.rb
@@ -5,7 +5,9 @@ class AddTokenEncryptedToDeployTokens < ActiveRecord::Migration[5.1]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :deploy_tokens, :token_encrypted, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190716144222_create_analytics_cycle_analytics_project_stages.rb b/db/migrate/20190716144222_create_analytics_cycle_analytics_project_stages.rb
index 5c005377b00..c03191013dc 100644
--- a/db/migrate/20190716144222_create_analytics_cycle_analytics_project_stages.rb
+++ b/db/migrate/20190716144222_create_analytics_cycle_analytics_project_stages.rb
@@ -26,7 +26,7 @@ class CreateAnalyticsCycleAnalyticsProjectStages < ActiveRecord::Migration[5.2]
})
t.boolean :hidden, default: false, null: false
t.boolean :custom, default: true, null: false
- t.string :name, null: false, limit: 255
+ t.string :name, null: false, limit: 255 # rubocop:disable Migration/PreventStrings
end
add_index :analytics_cycle_analytics_project_stages, [:project_id, :name], unique: true, name: INDEX_PREFIX + 'on_project_id_and_name'
diff --git a/db/migrate/20190722104947_add_static_object_token_to_users.rb b/db/migrate/20190722104947_add_static_object_token_to_users.rb
index 180e6a30b04..3983f076b3f 100644
--- a/db/migrate/20190722104947_add_static_object_token_to_users.rb
+++ b/db/migrate/20190722104947_add_static_object_token_to_users.rb
@@ -8,9 +8,13 @@ class AddStaticObjectTokenToUsers < ActiveRecord::Migration[5.2]
disable_ddl_transaction!
+ # rubocop:disable Migration/AddColumnsToWideTables
+ # rubocop:disable Migration/PreventStrings
def up
- add_column :users, :static_object_token, :string, limit: 255 # rubocop:disable Migration/AddColumnsToWideTables
+ add_column :users, :static_object_token, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
+ # rubocop:enable Migration/AddColumnsToWideTables
def down
remove_column :users, :static_object_token
diff --git a/db/migrate/20190722132830_add_static_objects_external_storage_columns_to_application_settings.rb b/db/migrate/20190722132830_add_static_objects_external_storage_columns_to_application_settings.rb
index a23e6ed66cd..f493eae26a8 100644
--- a/db/migrate/20190722132830_add_static_objects_external_storage_columns_to_application_settings.rb
+++ b/db/migrate/20190722132830_add_static_objects_external_storage_columns_to_application_settings.rb
@@ -7,8 +7,10 @@ class AddStaticObjectsExternalStorageColumnsToApplicationSettings < ActiveRecord
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :application_settings, :static_objects_external_storage_url, :string, limit: 255
add_column :application_settings, :static_objects_external_storage_auth_token, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190723153247_create_allowed_email_domains_for_groups.rb b/db/migrate/20190723153247_create_allowed_email_domains_for_groups.rb
index c6c5b56ed8b..71af7434f9d 100644
--- a/db/migrate/20190723153247_create_allowed_email_domains_for_groups.rb
+++ b/db/migrate/20190723153247_create_allowed_email_domains_for_groups.rb
@@ -16,7 +16,7 @@ class CreateAllowedEmailDomainsForGroups < ActiveRecord::Migration[5.2]
null: false,
index: true
t.foreign_key :namespaces, column: :group_id, on_delete: :cascade
- t.string :domain, null: false, limit: 255
+ t.string :domain, null: false, limit: 255 # rubocop:disable Migration/PreventStrings
end
end
end
diff --git a/db/migrate/20190729062536_create_analytics_cycle_analytics_group_stages.rb b/db/migrate/20190729062536_create_analytics_cycle_analytics_group_stages.rb
index 5b327dc5332..4753a7684e7 100644
--- a/db/migrate/20190729062536_create_analytics_cycle_analytics_group_stages.rb
+++ b/db/migrate/20190729062536_create_analytics_cycle_analytics_group_stages.rb
@@ -26,7 +26,7 @@ class CreateAnalyticsCycleAnalyticsGroupStages < ActiveRecord::Migration[5.2]
})
t.boolean :hidden, default: false, null: false
t.boolean :custom, default: true, null: false
- t.string :name, null: false, limit: 255
+ t.string :name, null: false, limit: 255 # rubocop:disable Migration/PreventStrings
end
add_index :analytics_cycle_analytics_group_stages, [:group_id, :name], unique: true, name: INDEX_PREFIX + 'on_group_id_and_name'
diff --git a/db/migrate/20190731084415_add_build_need.rb b/db/migrate/20190731084415_add_build_need.rb
index 45b8abb480d..ba044260db2 100644
--- a/db/migrate/20190731084415_add_build_need.rb
+++ b/db/migrate/20190731084415_add_build_need.rb
@@ -11,7 +11,7 @@ class AddBuildNeed < ActiveRecord::Migration[5.2]
def change
create_table :ci_build_needs, id: :serial do |t|
t.integer :build_id, null: false
- t.text :name, null: false
+ t.text :name, null: false # rubocop:disable Migration/AddLimitToTextColumns
t.index [:build_id, :name], unique: true
t.foreign_key :ci_builds, column: :build_id, on_delete: :cascade
diff --git a/db/migrate/20190801142441_add_throttle_protected_path_columns.rb b/db/migrate/20190801142441_add_throttle_protected_path_columns.rb
index bb6d54f3b7b..f9e0922ad66 100644
--- a/db/migrate/20190801142441_add_throttle_protected_path_columns.rb
+++ b/db/migrate/20190801142441_add_throttle_protected_path_columns.rb
@@ -16,10 +16,12 @@ class AddThrottleProtectedPathColumns < ActiveRecord::Migration[5.2]
'/import/github/personal_access_token'
]
+ # rubocop:disable Migration/PreventStrings
def change
add_column :application_settings, :throttle_protected_paths_enabled, :boolean, default: true, null: false
add_column :application_settings, :throttle_protected_paths_requests_per_period, :integer, default: 10, null: false
add_column :application_settings, :throttle_protected_paths_period_in_seconds, :integer, default: 60, null: false
add_column :application_settings, :protected_paths, :string, array: true, limit: 255, default: DEFAULT_PROTECTED_PATHS
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190808152507_add_projects_sorting_field_to_user_preferences.rb b/db/migrate/20190808152507_add_projects_sorting_field_to_user_preferences.rb
index 941fead655e..5022ae843e7 100644
--- a/db/migrate/20190808152507_add_projects_sorting_field_to_user_preferences.rb
+++ b/db/migrate/20190808152507_add_projects_sorting_field_to_user_preferences.rb
@@ -3,9 +3,11 @@
class AddProjectsSortingFieldToUserPreferences < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
add_column :user_preferences, :projects_sort, :string, limit: 64
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column :user_preferences, :projects_sort
diff --git a/db/migrate/20190820163320_add_first_last_name_to_user.rb b/db/migrate/20190820163320_add_first_last_name_to_user.rb
index 62bd1443b9d..908f55fa821 100644
--- a/db/migrate/20190820163320_add_first_last_name_to_user.rb
+++ b/db/migrate/20190820163320_add_first_last_name_to_user.rb
@@ -8,9 +8,11 @@ class AddFirstLastNameToUser < ActiveRecord::Migration[5.2]
DOWNTIME = false
# rubocop:disable Migration/AddColumnsToWideTables
+ # rubocop:disable Migration/PreventStrings
def change
add_column(:users, :first_name, :string, null: true, limit: 255)
add_column(:users, :last_name, :string, null: true, limit: 255)
end
+ # rubocop:enable Migration/PreventStrings
# rubocop:enable Migration/AddColumnsToWideTables
end
diff --git a/db/migrate/20190821040941_create_cluster_providers_aws.rb b/db/migrate/20190821040941_create_cluster_providers_aws.rb
index f80559861c4..666c33759a2 100644
--- a/db/migrate/20190821040941_create_cluster_providers_aws.rb
+++ b/db/migrate/20190821040941_create_cluster_providers_aws.rb
@@ -3,6 +3,8 @@
class CreateClusterProvidersAws < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
create_table :cluster_providers_aws do |t|
t.references :cluster, null: false, type: :bigint, index: { unique: true }, foreign_key: { on_delete: :cascade }
@@ -30,4 +32,6 @@ class CreateClusterProvidersAws < ActiveRecord::Migration[5.2]
t.index [:cluster_id, :status]
end
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190827222124_add_sourcegraph_configuration_to_application_settings.rb b/db/migrate/20190827222124_add_sourcegraph_configuration_to_application_settings.rb
index e624642c2fc..1059f73db8a 100644
--- a/db/migrate/20190827222124_add_sourcegraph_configuration_to_application_settings.rb
+++ b/db/migrate/20190827222124_add_sourcegraph_configuration_to_application_settings.rb
@@ -9,10 +9,12 @@ class AddSourcegraphConfigurationToApplicationSettings < ActiveRecord::Migration
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
add_column(:application_settings, :sourcegraph_enabled, :boolean, default: false, null: false)
add_column(:application_settings, :sourcegraph_url, :string, null: true, limit: 255)
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column(:application_settings, :sourcegraph_enabled)
diff --git a/db/migrate/20190828172831_create_package_tag.rb b/db/migrate/20190828172831_create_package_tag.rb
index baf0a5cf11b..3d26b7ce602 100644
--- a/db/migrate/20190828172831_create_package_tag.rb
+++ b/db/migrate/20190828172831_create_package_tag.rb
@@ -8,7 +8,7 @@ class CreatePackageTag < ActiveRecord::Migration[5.2]
def change
create_table :packages_package_tags do |t|
t.references :package, index: true, null: false, foreign_key: { to_table: :packages_packages, on_delete: :cascade }, type: :integer
- t.string :name, limit: 255, null: false
+ t.string :name, limit: 255, null: false # rubocop:disable Migration/PreventStrings
end
end
end
diff --git a/db/migrate/20190829131130_create_external_pull_requests.rb b/db/migrate/20190829131130_create_external_pull_requests.rb
index 0c3168807ec..817f84017e2 100644
--- a/db/migrate/20190829131130_create_external_pull_requests.rb
+++ b/db/migrate/20190829131130_create_external_pull_requests.rb
@@ -6,6 +6,7 @@ class CreateExternalPullRequests < ActiveRecord::Migration[5.2]
DOWNTIME = false
INDEX = 'index_external_pull_requests_on_project_and_branches'
+ # rubocop:disable Migration/PreventStrings
def change
create_table :external_pull_requests do |t|
t.timestamps_with_timezone null: false
@@ -22,4 +23,5 @@ class CreateExternalPullRequests < ActiveRecord::Migration[5.2]
t.index [:project_id, :source_branch, :target_branch], unique: true, name: INDEX
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190903150358_create_analytics_repository_files_table.rb b/db/migrate/20190903150358_create_analytics_repository_files_table.rb
index e7c30a149f9..69c9cd504f4 100644
--- a/db/migrate/20190903150358_create_analytics_repository_files_table.rb
+++ b/db/migrate/20190903150358_create_analytics_repository_files_table.rb
@@ -5,6 +5,7 @@ class CreateAnalyticsRepositoryFilesTable < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :analytics_repository_files do |t|
t.references :project,
@@ -18,4 +19,5 @@ class CreateAnalyticsRepositoryFilesTable < ActiveRecord::Migration[5.2]
add_index :analytics_repository_files, [:project_id, :file_path], unique: true
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190906104555_create_alerts_service_data.rb b/db/migrate/20190906104555_create_alerts_service_data.rb
index 8ce447a67d1..9388a205978 100644
--- a/db/migrate/20190906104555_create_alerts_service_data.rb
+++ b/db/migrate/20190906104555_create_alerts_service_data.rb
@@ -3,6 +3,7 @@
class CreateAlertsServiceData < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :alerts_service_data do |t|
t.references :service, type: :integer, index: true, null: false,
@@ -12,4 +13,5 @@ class CreateAlertsServiceData < ActiveRecord::Migration[5.2]
t.string :encrypted_token_iv, limit: 255
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190910211526_create_packages_conan_file_metadata.rb b/db/migrate/20190910211526_create_packages_conan_file_metadata.rb
index 0f8dacb72de..a6830a93cbc 100644
--- a/db/migrate/20190910211526_create_packages_conan_file_metadata.rb
+++ b/db/migrate/20190910211526_create_packages_conan_file_metadata.rb
@@ -5,6 +5,7 @@ class CreatePackagesConanFileMetadata < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :packages_conan_file_metadata do |t|
t.references :package_file, index: { unique: true }, null: false, foreign_key: { to_table: :packages_package_files, on_delete: :cascade }, type: :bigint
@@ -15,4 +16,5 @@ class CreatePackagesConanFileMetadata < ActiveRecord::Migration[5.2]
t.integer "conan_file_type", limit: 2, null: false
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190913174707_add_spdx_id_to_software_licenses.rb b/db/migrate/20190913174707_add_spdx_id_to_software_licenses.rb
index 66cd450895c..46e1400c394 100644
--- a/db/migrate/20190913174707_add_spdx_id_to_software_licenses.rb
+++ b/db/migrate/20190913174707_add_spdx_id_to_software_licenses.rb
@@ -3,9 +3,11 @@
class AddSpdxIdToSoftwareLicenses < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
add_column :software_licenses, :spdx_identifier, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column :software_licenses, :spdx_identifier
diff --git a/db/migrate/20190918102042_create_grafana_integrations.rb b/db/migrate/20190918102042_create_grafana_integrations.rb
index aac27d129db..d48aaaf45bc 100644
--- a/db/migrate/20190918102042_create_grafana_integrations.rb
+++ b/db/migrate/20190918102042_create_grafana_integrations.rb
@@ -3,6 +3,7 @@
class CreateGrafanaIntegrations < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :grafana_integrations do |t|
t.references :project, index: true, foreign_key: { on_delete: :cascade }, unique: true, null: false
@@ -12,4 +13,5 @@ class CreateGrafanaIntegrations < ActiveRecord::Migration[5.2]
t.string :grafana_url, null: false, limit: 1024
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190918121135_add_cleanup_status_reason_to_cluster.rb b/db/migrate/20190918121135_add_cleanup_status_reason_to_cluster.rb
index 4e71905e3a3..85293ebbe86 100644
--- a/db/migrate/20190918121135_add_cleanup_status_reason_to_cluster.rb
+++ b/db/migrate/20190918121135_add_cleanup_status_reason_to_cluster.rb
@@ -7,6 +7,6 @@ class AddCleanupStatusReasonToCluster < ActiveRecord::Migration[5.2]
DOWNTIME = false
def change
- add_column :clusters, :cleanup_status_reason, :text
+ add_column :clusters, :cleanup_status_reason, :text # rubocop:disable Migration/AddLimitToTextColumns
end
end
diff --git a/db/migrate/20190920224341_create_merge_request_context_commits_and_diffs.rb b/db/migrate/20190920224341_create_merge_request_context_commits_and_diffs.rb
index dcc9da670f7..bd97d3d3183 100644
--- a/db/migrate/20190920224341_create_merge_request_context_commits_and_diffs.rb
+++ b/db/migrate/20190920224341_create_merge_request_context_commits_and_diffs.rb
@@ -6,6 +6,8 @@
class CreateMergeRequestContextCommitsAndDiffs < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
create_table :merge_request_context_commits do |t|
t.references :merge_request, foreign_key: { on_delete: :cascade }
@@ -38,4 +40,6 @@ class CreateMergeRequestContextCommitsAndDiffs < ActiveRecord::Migration[5.2]
t.index [:merge_request_context_commit_id, :sha], name: 'idx_mr_cc_diff_files_on_mr_cc_id_and_sha'
end
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190924124627_add_pull_mirror_branch_prefix_to_projects.rb b/db/migrate/20190924124627_add_pull_mirror_branch_prefix_to_projects.rb
index f1af925c421..2750468834f 100644
--- a/db/migrate/20190924124627_add_pull_mirror_branch_prefix_to_projects.rb
+++ b/db/migrate/20190924124627_add_pull_mirror_branch_prefix_to_projects.rb
@@ -3,7 +3,11 @@
class AddPullMirrorBranchPrefixToProjects < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/AddColumnsToWideTables
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :projects, :pull_mirror_branch_prefix, :string, limit: 50 # rubocop:disable Migration/AddColumnsToWideTables
+ add_column :projects, :pull_mirror_branch_prefix, :string, limit: 50
end
+ # rubocop:enable Migration/PreventStrings
+ # rubocop:enable Migration/AddColumnsToWideTables
end
diff --git a/db/migrate/20190926225633_create_x509_signatures.rb b/db/migrate/20190926225633_create_x509_signatures.rb
index 88f6b03afba..40d2c351524 100644
--- a/db/migrate/20190926225633_create_x509_signatures.rb
+++ b/db/migrate/20190926225633_create_x509_signatures.rb
@@ -6,6 +6,7 @@
class CreateX509Signatures < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :x509_issuers do |t|
t.timestamps_with_timezone null: false
@@ -38,4 +39,5 @@ class CreateX509Signatures < ActiveRecord::Migration[5.2]
t.integer :verification_status, limit: 2, default: 0, null: false
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20190927055500_create_description_versions.rb b/db/migrate/20190927055500_create_description_versions.rb
index 6ad34d4a89e..b3082533a6f 100644
--- a/db/migrate/20190927055500_create_description_versions.rb
+++ b/db/migrate/20190927055500_create_description_versions.rb
@@ -11,7 +11,7 @@ class CreateDescriptionVersions < ActiveRecord::Migration[5.2]
t.references :issue, index: false, foreign_key: { on_delete: :cascade }, type: :integer
t.references :merge_request, index: false, foreign_key: { on_delete: :cascade }, type: :integer
t.references :epic, index: false, foreign_key: { on_delete: :cascade }, type: :integer
- t.text :description
+ t.text :description # rubocop:disable Migration/AddLimitToTextColumns
end
add_index :description_versions, :issue_id, where: 'issue_id IS NOT NULL'
diff --git a/db/migrate/20190929180751_create_vulnerabilities.rb b/db/migrate/20190929180751_create_vulnerabilities.rb
index aea018c5979..e4c53b1063a 100644
--- a/db/migrate/20190929180751_create_vulnerabilities.rb
+++ b/db/migrate/20190929180751_create_vulnerabilities.rb
@@ -8,6 +8,7 @@ class CreateVulnerabilities < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
create_table :vulnerabilities do |t|
t.bigint "milestone_id"
@@ -30,10 +31,11 @@ class CreateVulnerabilities < ActiveRecord::Migration[5.2]
t.integer "confidence", limit: 2, null: false # auto-calculated as lowest-confidence finding, but overrideable
t.boolean "severity_overridden", default: false
t.boolean "confidence_overridden", default: false
- t.string "title", limit: 255, null: false
+ t.string "title", limit: 255, null: false # rubocop:disable Migration/PreventStrings
t.text "title_html", null: false
t.text "description"
t.text "description_html"
end
end
+ # rubocop:enable Migration/AddLimitToTextColumns
end
diff --git a/db/migrate/20190930153535_create_zoom_meetings.rb b/db/migrate/20190930153535_create_zoom_meetings.rb
index 6b92c53da79..8bc9f0e89de 100644
--- a/db/migrate/20190930153535_create_zoom_meetings.rb
+++ b/db/migrate/20190930153535_create_zoom_meetings.rb
@@ -15,7 +15,7 @@ class CreateZoomMeetings < ActiveRecord::Migration[5.2]
null: false
t.timestamps_with_timezone null: false
t.integer :issue_status, limit: 2, default: 1, null: false
- t.string :url, limit: 255
+ t.string :url, limit: 255 # rubocop:disable Migration/PreventStrings
t.index [:issue_id, :issue_status], unique: true,
where: "issue_status = #{ZOOM_MEETING_STATUS_ADDED}"
diff --git a/db/migrate/20191001170300_create_ci_ref.rb b/db/migrate/20191001170300_create_ci_ref.rb
index af25e67430b..feeb8517e6e 100644
--- a/db/migrate/20191001170300_create_ci_ref.rb
+++ b/db/migrate/20191001170300_create_ci_ref.rb
@@ -3,6 +3,7 @@
class CreateCiRef < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :ci_refs do |t|
t.references :project, null: false, index: false, foreign_key: { on_delete: :cascade }, type: :integer
@@ -16,4 +17,5 @@ class CreateCiRef < ActiveRecord::Migration[5.2]
t.index [:last_updated_by_pipeline_id]
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191002123516_create_clusters_applications_elastic_stack.rb b/db/migrate/20191002123516_create_clusters_applications_elastic_stack.rb
index 8910dc0d9fb..e1236423672 100644
--- a/db/migrate/20191002123516_create_clusters_applications_elastic_stack.rb
+++ b/db/migrate/20191002123516_create_clusters_applications_elastic_stack.rb
@@ -8,6 +8,7 @@ class CreateClustersApplicationsElasticStack < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :clusters_applications_elastic_stacks do |t|
t.timestamps_with_timezone null: false
@@ -15,8 +16,9 @@ class CreateClustersApplicationsElasticStack < ActiveRecord::Migration[5.2]
t.integer :status, null: false
t.string :version, null: false, limit: 255
t.string :kibana_hostname, limit: 255
- t.text :status_reason
+ t.text :status_reason # rubocop:disable Migration/AddLimitToTextColumns
t.index :cluster_id, unique: true
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191003015155_add_self_managed_prometheus_alerts.rb b/db/migrate/20191003015155_add_self_managed_prometheus_alerts.rb
index 71d10153422..eec6f518257 100644
--- a/db/migrate/20191003015155_add_self_managed_prometheus_alerts.rb
+++ b/db/migrate/20191003015155_add_self_managed_prometheus_alerts.rb
@@ -3,6 +3,7 @@
class AddSelfManagedPrometheusAlerts < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :self_managed_prometheus_alert_events do |t|
t.references :project, index: false, foreign_key: { on_delete: :cascade }, null: false
@@ -17,4 +18,5 @@ class AddSelfManagedPrometheusAlerts < ActiveRecord::Migration[5.2]
t.index [:project_id, :payload_key], unique: true, name: 'idx_project_id_payload_key_self_managed_prometheus_alert_events'
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191003064615_create_aws_roles.rb b/db/migrate/20191003064615_create_aws_roles.rb
index ee35953f558..960e9b28053 100644
--- a/db/migrate/20191003064615_create_aws_roles.rb
+++ b/db/migrate/20191003064615_create_aws_roles.rb
@@ -6,6 +6,7 @@
class CreateAwsRoles < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :aws_roles, id: false do |t|
t.references :user, primary_key: true, default: nil, type: :integer, index: { unique: true }, foreign_key: { on_delete: :cascade }
@@ -18,4 +19,5 @@ class CreateAwsRoles < ActiveRecord::Migration[5.2]
t.index :role_external_id, unique: true
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191003195620_add_pendo_url_to_application_settings.rb b/db/migrate/20191003195620_add_pendo_url_to_application_settings.rb
index cc0895f8bee..6763cb5544c 100644
--- a/db/migrate/20191003195620_add_pendo_url_to_application_settings.rb
+++ b/db/migrate/20191003195620_add_pendo_url_to_application_settings.rb
@@ -3,7 +3,9 @@ class AddPendoUrlToApplicationSettings < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :application_settings, :pendo_url, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191009222222_add_custom_http_clone_url_root_to_application_settings.rb b/db/migrate/20191009222222_add_custom_http_clone_url_root_to_application_settings.rb
index 0fa8ff449f7..41876ee2cdf 100644
--- a/db/migrate/20191009222222_add_custom_http_clone_url_root_to_application_settings.rb
+++ b/db/migrate/20191009222222_add_custom_http_clone_url_root_to_application_settings.rb
@@ -7,7 +7,9 @@ class AddCustomHttpCloneUrlRootToApplicationSettings < ActiveRecord::Migration[5
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :application_settings, :custom_http_clone_url_root, :string, limit: 511
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191010174846_add_snowplow_iglu_registry_url_to_application_settings.rb b/db/migrate/20191010174846_add_snowplow_iglu_registry_url_to_application_settings.rb
index a40ce8dbee5..8f882bcaa50 100644
--- a/db/migrate/20191010174846_add_snowplow_iglu_registry_url_to_application_settings.rb
+++ b/db/migrate/20191010174846_add_snowplow_iglu_registry_url_to_application_settings.rb
@@ -3,7 +3,9 @@
class AddSnowplowIgluRegistryUrlToApplicationSettings < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :application_settings, :snowplow_iglu_registry_url, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191017191341_create_clusters_applications_crossplane.rb b/db/migrate/20191017191341_create_clusters_applications_crossplane.rb
index 8dc25c56116..42f980ed99d 100644
--- a/db/migrate/20191017191341_create_clusters_applications_crossplane.rb
+++ b/db/migrate/20191017191341_create_clusters_applications_crossplane.rb
@@ -5,6 +5,7 @@ class CreateClustersApplicationsCrossplane < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :clusters_applications_crossplane do |t|
t.timestamps_with_timezone null: false
@@ -12,8 +13,9 @@ class CreateClustersApplicationsCrossplane < ActiveRecord::Migration[5.2]
t.integer :status, null: false
t.string :version, null: false, limit: 255
t.string :stack, null: false, limit: 255
- t.text :status_reason
+ t.text :status_reason # rubocop:disable Migration/AddLimitToTextColumns
t.index :cluster_id, unique: true
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191025092748_add_secret_token_to_snippet.rb b/db/migrate/20191025092748_add_secret_token_to_snippet.rb
index 0649f58d23e..c43c1fbe2b7 100644
--- a/db/migrate/20191025092748_add_secret_token_to_snippet.rb
+++ b/db/migrate/20191025092748_add_secret_token_to_snippet.rb
@@ -3,8 +3,10 @@
class AddSecretTokenToSnippet < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :snippets, :encrypted_secret_token, :string, limit: 255
add_column :snippets, :encrypted_secret_token_iv, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191029125305_create_packages_conan_metadata.rb b/db/migrate/20191029125305_create_packages_conan_metadata.rb
index c6abc509e41..fa14b73e19b 100644
--- a/db/migrate/20191029125305_create_packages_conan_metadata.rb
+++ b/db/migrate/20191029125305_create_packages_conan_metadata.rb
@@ -5,6 +5,7 @@ class CreatePackagesConanMetadata < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :packages_conan_metadata do |t|
t.references :package, index: { unique: true }, null: false, foreign_key: { to_table: :packages_packages, on_delete: :cascade }, type: :bigint
@@ -13,4 +14,5 @@ class CreatePackagesConanMetadata < ActiveRecord::Migration[5.2]
t.string "package_channel", null: false, limit: 255
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191103202505_add_eks_credentials_to_application_settings.rb b/db/migrate/20191103202505_add_eks_credentials_to_application_settings.rb
index 3a167b4c67f..5ed3e7edb3c 100644
--- a/db/migrate/20191103202505_add_eks_credentials_to_application_settings.rb
+++ b/db/migrate/20191103202505_add_eks_credentials_to_application_settings.rb
@@ -4,6 +4,8 @@ class AddEksCredentialsToApplicationSettings < ActiveRecord::Migration[5.2]
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
add_column :application_settings, :eks_integration_enabled, :boolean, null: false, default: false
add_column :application_settings, :eks_account_id, :string, limit: 128
@@ -11,4 +13,6 @@ class AddEksCredentialsToApplicationSettings < ActiveRecord::Migration[5.2]
add_column :application_settings, :encrypted_eks_secret_access_key_iv, :string, limit: 255
add_column :application_settings, :encrypted_eks_secret_access_key, :text
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191105134413_create_service_desk_settings.rb b/db/migrate/20191105134413_create_service_desk_settings.rb
index ee026b6f26d..dc8268f1c90 100644
--- a/db/migrate/20191105134413_create_service_desk_settings.rb
+++ b/db/migrate/20191105134413_create_service_desk_settings.rb
@@ -3,6 +3,7 @@
class CreateServiceDeskSettings < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :service_desk_settings, id: false do |t|
t.references :project,
@@ -15,4 +16,5 @@ class CreateServiceDeskSettings < ActiveRecord::Migration[5.2]
t.string :issue_template_key, limit: 255
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191111121500_default_ci_config_path.rb b/db/migrate/20191111121500_default_ci_config_path.rb
index f391f5ffe99..3914058d35b 100644
--- a/db/migrate/20191111121500_default_ci_config_path.rb
+++ b/db/migrate/20191111121500_default_ci_config_path.rb
@@ -3,9 +3,11 @@
class DefaultCiConfigPath < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
add_column :application_settings, :default_ci_config_path, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column :application_settings, :default_ci_config_path
diff --git a/db/migrate/20191119231621_create_container_expiration_policies.rb b/db/migrate/20191119231621_create_container_expiration_policies.rb
index d7108870cf1..d06ae659f41 100644
--- a/db/migrate/20191119231621_create_container_expiration_policies.rb
+++ b/db/migrate/20191119231621_create_container_expiration_policies.rb
@@ -3,6 +3,7 @@
class CreateContainerExpirationPolicies < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :container_expiration_policies, id: false, primary_key: :project_id do |t|
t.timestamps_with_timezone null: false
@@ -18,4 +19,5 @@ class CreateContainerExpirationPolicies < ActiveRecord::Migration[5.2]
add_index :container_expiration_policies, [:next_run_at, :enabled],
name: 'index_container_expiration_policies_on_next_run_at_and_enabled'
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191120084627_add_encrypted_fields_to_application_settings.rb b/db/migrate/20191120084627_add_encrypted_fields_to_application_settings.rb
index 4e0886a5121..7bb2d9c6301 100644
--- a/db/migrate/20191120084627_add_encrypted_fields_to_application_settings.rb
+++ b/db/migrate/20191120084627_add_encrypted_fields_to_application_settings.rb
@@ -14,12 +14,16 @@ class AddEncryptedFieldsToApplicationSettings < ActiveRecord::Migration[5.2]
slack_app_verification_token
].freeze
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def up
PLAINTEXT_ATTRIBUTES.each do |plaintext_attribute|
add_column :application_settings, "encrypted_#{plaintext_attribute}", :text
add_column :application_settings, "encrypted_#{plaintext_attribute}_iv", :string, limit: 255
end
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
def down
PLAINTEXT_ATTRIBUTES.each do |plaintext_attribute|
diff --git a/db/migrate/20191121111621_create_packages_dependencies.rb b/db/migrate/20191121111621_create_packages_dependencies.rb
index 61e52627b05..29a8434514e 100644
--- a/db/migrate/20191121111621_create_packages_dependencies.rb
+++ b/db/migrate/20191121111621_create_packages_dependencies.rb
@@ -3,6 +3,7 @@
class CreatePackagesDependencies < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :packages_dependencies do |t|
t.string :name, null: false, limit: 255
@@ -11,4 +12,5 @@ class CreatePackagesDependencies < ActiveRecord::Migration[5.2]
add_index :packages_dependencies, [:name, :version_pattern], unique: true
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191125133353_add_target_path_to_broadcast_message.rb b/db/migrate/20191125133353_add_target_path_to_broadcast_message.rb
index 65aa758e502..8597cce5b19 100644
--- a/db/migrate/20191125133353_add_target_path_to_broadcast_message.rb
+++ b/db/migrate/20191125133353_add_target_path_to_broadcast_message.rb
@@ -3,7 +3,9 @@
class AddTargetPathToBroadcastMessage < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :broadcast_messages, :target_path, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191125140458_create_import_failures.rb b/db/migrate/20191125140458_create_import_failures.rb
index 43e8efe90a4..e5dbcf5d41d 100644
--- a/db/migrate/20191125140458_create_import_failures.rb
+++ b/db/migrate/20191125140458_create_import_failures.rb
@@ -3,6 +3,7 @@
class CreateImportFailures < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :import_failures do |t|
t.integer :relation_index
@@ -14,4 +15,5 @@ class CreateImportFailures < ActiveRecord::Migration[5.2]
t.string :exception_message, limit: 255
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191127030005_create_serverless_domain_cluster.rb b/db/migrate/20191127030005_create_serverless_domain_cluster.rb
index 7fb24400b0d..c65301bf133 100644
--- a/db/migrate/20191127030005_create_serverless_domain_cluster.rb
+++ b/db/migrate/20191127030005_create_serverless_domain_cluster.rb
@@ -3,6 +3,7 @@
class CreateServerlessDomainCluster < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :serverless_domain_cluster, id: false, primary_key: :uuid do |t|
t.references :pages_domain, null: false, foreign_key: { on_delete: :cascade }
@@ -14,4 +15,5 @@ class CreateServerlessDomainCluster < ActiveRecord::Migration[5.2]
t.string :uuid, null: false, limit: 14, primary_key: true
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191128145231_add_ci_resource_groups.rb b/db/migrate/20191128145231_add_ci_resource_groups.rb
index 8bde0254701..77975120f72 100644
--- a/db/migrate/20191128145231_add_ci_resource_groups.rb
+++ b/db/migrate/20191128145231_add_ci_resource_groups.rb
@@ -7,7 +7,7 @@ class AddCiResourceGroups < ActiveRecord::Migration[5.2]
create_table :ci_resource_groups do |t|
t.timestamps_with_timezone
t.bigint :project_id, null: false
- t.string :key, null: false, limit: 255
+ t.string :key, null: false, limit: 255 # rubocop:disable Migration/PreventStrings
t.index %i[project_id key], unique: true
end
diff --git a/db/migrate/20191202181924_add_environment_auto_stop_in_to_ci_builds_metadata.rb b/db/migrate/20191202181924_add_environment_auto_stop_in_to_ci_builds_metadata.rb
index bce191a7ec0..c09196da91b 100644
--- a/db/migrate/20191202181924_add_environment_auto_stop_in_to_ci_builds_metadata.rb
+++ b/db/migrate/20191202181924_add_environment_auto_stop_in_to_ci_builds_metadata.rb
@@ -3,9 +3,11 @@
class AddEnvironmentAutoStopInToCiBuildsMetadata < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
add_column :ci_builds_metadata, :environment_auto_stop_in, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column :ci_builds_metadata, :environment_auto_stop_in
diff --git a/db/migrate/20191204192726_add_design_disk_path_to_geo_hashed_storage_migrated_events.rb b/db/migrate/20191204192726_add_design_disk_path_to_geo_hashed_storage_migrated_events.rb
index 39b5d5c7e97..8631502ded8 100644
--- a/db/migrate/20191204192726_add_design_disk_path_to_geo_hashed_storage_migrated_events.rb
+++ b/db/migrate/20191204192726_add_design_disk_path_to_geo_hashed_storage_migrated_events.rb
@@ -5,8 +5,10 @@ class AddDesignDiskPathToGeoHashedStorageMigratedEvents < ActiveRecord::Migratio
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
add_column :geo_hashed_storage_migrated_events, :old_design_disk_path, :text
add_column :geo_hashed_storage_migrated_events, :new_design_disk_path, :text
end
+ # rubocop:enable Migration/AddLimitToTextColumns
end
diff --git a/db/migrate/20191206014412_add_image_to_design_management_designs_versions.rb b/db/migrate/20191206014412_add_image_to_design_management_designs_versions.rb
index d8e2269d21a..54ef9b74f29 100644
--- a/db/migrate/20191206014412_add_image_to_design_management_designs_versions.rb
+++ b/db/migrate/20191206014412_add_image_to_design_management_designs_versions.rb
@@ -3,7 +3,9 @@
class AddImageToDesignManagementDesignsVersions < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :design_management_designs_versions, :image_v432x230, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191208110214_add_suggestion_commit_message_to_projects.rb b/db/migrate/20191208110214_add_suggestion_commit_message_to_projects.rb
index cb897edde8e..3c96a1737c2 100644
--- a/db/migrate/20191208110214_add_suggestion_commit_message_to_projects.rb
+++ b/db/migrate/20191208110214_add_suggestion_commit_message_to_projects.rb
@@ -3,7 +3,11 @@
class AddSuggestionCommitMessageToProjects < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/AddColumnsToWideTables
+ # rubocop:disable Migration/PreventStrings
def change
- add_column :projects, :suggestion_commit_message, :string, limit: 255 # rubocop:disable Migration/AddColumnsToWideTables
+ add_column :projects, :suggestion_commit_message, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
+ # rubocop:enable Migration/AddColumnsToWideTables
end
diff --git a/db/migrate/20191212140117_change_commit_user_mentions_commit_id_column_type.rb b/db/migrate/20191212140117_change_commit_user_mentions_commit_id_column_type.rb
index f30cdab3441..f205de3587e 100644
--- a/db/migrate/20191212140117_change_commit_user_mentions_commit_id_column_type.rb
+++ b/db/migrate/20191212140117_change_commit_user_mentions_commit_id_column_type.rb
@@ -12,6 +12,7 @@ class ChangeCommitUserMentionsCommitIdColumnType < ActiveRecord::Migration[5.2]
NEW_TMP_INDEX = 'temp_commit_id_for_type_change_and_note_id_index'
NEW_INDEX = 'commit_id_and_note_id_index'
+ # rubocop:disable Migration/PreventStrings
def up
# the initial index name is too long and fails during migration. Renaming the index first.
add_concurrent_index :commit_user_mentions, [:commit_id, :note_id], name: OLD_TMP_INDEX
@@ -29,6 +30,7 @@ class ChangeCommitUserMentionsCommitIdColumnType < ActiveRecord::Migration[5.2]
add_concurrent_index :commit_user_mentions, [:commit_id_for_type_change, :note_id], name: NEW_INDEX
remove_concurrent_index_by_name :commit_user_mentions, NEW_TMP_INDEX
end
+ # rubocop:enable Migration/PreventStrings
def down
cleanup_concurrent_column_type_change :commit_user_mentions, :commit_id
diff --git a/db/migrate/20191213104838_add_service_desk_username.rb b/db/migrate/20191213104838_add_service_desk_username.rb
index 945bdb67fa1..d50de4c362c 100644
--- a/db/migrate/20191213104838_add_service_desk_username.rb
+++ b/db/migrate/20191213104838_add_service_desk_username.rb
@@ -3,7 +3,9 @@
class AddServiceDeskUsername < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :service_desk_settings, :outgoing_name, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20191213143656_create_ci_pipelines_config.rb b/db/migrate/20191213143656_create_ci_pipelines_config.rb
index 92636f35d01..a1821ee9f66 100644
--- a/db/migrate/20191213143656_create_ci_pipelines_config.rb
+++ b/db/migrate/20191213143656_create_ci_pipelines_config.rb
@@ -8,7 +8,7 @@ class CreateCiPipelinesConfig < ActiveRecord::Migration[5.2]
t.references :pipeline,
primary_key: true,
foreign_key: { to_table: :ci_pipelines, on_delete: :cascade }
- t.text :content, null: false
+ t.text :content, null: false # rubocop:disable Migration/AddLimitToTextColumns
end
end
end
diff --git a/db/migrate/20191218124915_add_repository_storage_to_snippets.rb b/db/migrate/20191218124915_add_repository_storage_to_snippets.rb
index ff391c04062..d1b1d7369f0 100644
--- a/db/migrate/20191218124915_add_repository_storage_to_snippets.rb
+++ b/db/migrate/20191218124915_add_repository_storage_to_snippets.rb
@@ -7,6 +7,7 @@ class AddRepositoryStorageToSnippets < ActiveRecord::Migration[5.2]
disable_ddl_transaction!
+ # rubocop:disable Migration/PreventStrings
def up
add_column_with_default(
:snippets,
@@ -17,6 +18,7 @@ class AddRepositoryStorageToSnippets < ActiveRecord::Migration[5.2]
allow_null: false
)
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column(:snippets, :repository_storage)
diff --git a/db/migrate/20200102140148_add_expanded_environment_name_to_ci_build_metadata.rb b/db/migrate/20200102140148_add_expanded_environment_name_to_ci_build_metadata.rb
index e76806c5d3f..21520f86bf8 100644
--- a/db/migrate/20200102140148_add_expanded_environment_name_to_ci_build_metadata.rb
+++ b/db/migrate/20200102140148_add_expanded_environment_name_to_ci_build_metadata.rb
@@ -3,9 +3,11 @@
class AddExpandedEnvironmentNameToCiBuildMetadata < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
add_column :ci_builds_metadata, :expanded_environment_name, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column :ci_builds_metadata, :expanded_environment_name
diff --git a/db/migrate/20200121192942_create_geo_events.rb b/db/migrate/20200121192942_create_geo_events.rb
index 6dbe131051f..0c885e8524c 100644
--- a/db/migrate/20200121192942_create_geo_events.rb
+++ b/db/migrate/20200121192942_create_geo_events.rb
@@ -3,6 +3,7 @@
class CreateGeoEvents < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :geo_events do |t|
t.string :replicable_name, limit: 255, null: false
@@ -11,4 +12,5 @@ class CreateGeoEvents < ActiveRecord::Migration[5.2]
t.datetime_with_timezone :created_at, null: false
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200124053531_add_source_to_import_failures.rb b/db/migrate/20200124053531_add_source_to_import_failures.rb
index 532d5803c74..2ca0bcba09f 100644
--- a/db/migrate/20200124053531_add_source_to_import_failures.rb
+++ b/db/migrate/20200124053531_add_source_to_import_failures.rb
@@ -3,7 +3,9 @@
class AddSourceToImportFailures < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :import_failures, :source, :string, limit: 128
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200129133716_add_resource_milestone_events_table.rb b/db/migrate/20200129133716_add_resource_milestone_events_table.rb
index 0ead21820c2..681190a8744 100644
--- a/db/migrate/20200129133716_add_resource_milestone_events_table.rb
+++ b/db/migrate/20200129133716_add_resource_milestone_events_table.rb
@@ -3,6 +3,7 @@
class AddResourceMilestoneEventsTable < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
create_table :resource_milestone_events, id: :bigserial do |t|
t.references :user, null: false, foreign_key: { on_delete: :nullify },
@@ -22,4 +23,5 @@ class AddResourceMilestoneEventsTable < ActiveRecord::Migration[5.2]
t.datetime_with_timezone :created_at, null: false
end
end
+ # rubocop:enable Migration/AddLimitToTextColumns
end
diff --git a/db/migrate/20200130134335_add_cert_and_key_to_serverless_domain_cluster.rb b/db/migrate/20200130134335_add_cert_and_key_to_serverless_domain_cluster.rb
index 39249053ee0..81764aefe7c 100644
--- a/db/migrate/20200130134335_add_cert_and_key_to_serverless_domain_cluster.rb
+++ b/db/migrate/20200130134335_add_cert_and_key_to_serverless_domain_cluster.rb
@@ -5,9 +5,13 @@ class AddCertAndKeyToServerlessDomainCluster < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
+ # rubocop:disable Migration/AddLimitToTextColumns
def change
add_column :serverless_domain_cluster, :encrypted_key, :text
add_column :serverless_domain_cluster, :encrypted_key_iv, :string, limit: 255
add_column :serverless_domain_cluster, :certificate, :text
end
+ # rubocop:enable Migration/AddLimitToTextColumns
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200202100932_add_service_desk_project_key.rb b/db/migrate/20200202100932_add_service_desk_project_key.rb
index d42ed4159e4..5095e628b42 100644
--- a/db/migrate/20200202100932_add_service_desk_project_key.rb
+++ b/db/migrate/20200202100932_add_service_desk_project_key.rb
@@ -3,7 +3,9 @@
class AddServiceDeskProjectKey < ActiveRecord::Migration[5.2]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :service_desk_settings, :project_key, :string, limit: 255
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200204131831_create_daily_report_results.rb b/db/migrate/20200204131831_create_daily_report_results.rb
index e18d4efb7fa..6992b6317e1 100644
--- a/db/migrate/20200204131831_create_daily_report_results.rb
+++ b/db/migrate/20200204131831_create_daily_report_results.rb
@@ -3,6 +3,7 @@
class CreateDailyReportResults < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :ci_daily_report_results do |t|
t.date :date, null: false
@@ -10,8 +11,8 @@ class CreateDailyReportResults < ActiveRecord::Migration[6.0]
t.bigint :last_pipeline_id, null: false
t.float :value, null: false
t.integer :param_type, limit: 8, null: false
- t.string :ref_path, null: false # rubocop:disable Migration/AddLimitToStringColumns
- t.string :title, null: false # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :ref_path, null: false
+ t.string :title, null: false
t.index :last_pipeline_id
t.index [:project_id, :ref_path, :param_type, :date, :title], name: 'index_daily_report_results_unique_columns', unique: true
@@ -19,4 +20,5 @@ class CreateDailyReportResults < ActiveRecord::Migration[6.0]
t.foreign_key :ci_pipelines, column: :last_pipeline_id, on_delete: :cascade
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200206112850_create_snippet_repository_table.rb b/db/migrate/20200206112850_create_snippet_repository_table.rb
index 0c14b37855d..b9120264bb7 100644
--- a/db/migrate/20200206112850_create_snippet_repository_table.rb
+++ b/db/migrate/20200206112850_create_snippet_repository_table.rb
@@ -3,6 +3,7 @@
class CreateSnippetRepositoryTable < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :snippet_repositories, id: false, primary_key: :snippet_id do |t|
t.references :shard, null: false, index: true, foreign_key: { on_delete: :restrict }
@@ -10,4 +11,5 @@ class CreateSnippetRepositoryTable < ActiveRecord::Migration[6.0]
t.string :disk_path, limit: 80, null: false, index: { unique: true }
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200207151640_create_deployment_clusters.rb b/db/migrate/20200207151640_create_deployment_clusters.rb
index 233e91d31b0..dd05d1730d9 100644
--- a/db/migrate/20200207151640_create_deployment_clusters.rb
+++ b/db/migrate/20200207151640_create_deployment_clusters.rb
@@ -3,6 +3,7 @@
class CreateDeploymentClusters < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :deployment_clusters, id: false, force: :cascade do |t|
t.references :deployment, foreign_key: { on_delete: :cascade }, primary_key: true, type: :integer, index: false, default: nil
@@ -13,4 +14,5 @@ class CreateDeploymentClusters < ActiveRecord::Migration[6.0]
t.index [:cluster_id, :deployment_id], unique: true
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200210184410_create_operations_strategies_table.rb b/db/migrate/20200210184410_create_operations_strategies_table.rb
index 1046bd11bc7..4d65267c1a7 100644
--- a/db/migrate/20200210184410_create_operations_strategies_table.rb
+++ b/db/migrate/20200210184410_create_operations_strategies_table.rb
@@ -3,6 +3,7 @@
class CreateOperationsStrategiesTable < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :operations_strategies do |t|
t.references :feature_flag, index: true, null: false, foreign_key: { to_table: :operations_feature_flags, on_delete: :cascade }
@@ -10,4 +11,5 @@ class CreateOperationsStrategiesTable < ActiveRecord::Migration[6.0]
t.jsonb :parameters, null: false, default: {}
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200210184420_create_operations_scopes_table.rb b/db/migrate/20200210184420_create_operations_scopes_table.rb
index 0b33882fe3d..7ce21feb865 100644
--- a/db/migrate/20200210184420_create_operations_scopes_table.rb
+++ b/db/migrate/20200210184420_create_operations_scopes_table.rb
@@ -3,6 +3,7 @@
class CreateOperationsScopesTable < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :operations_scopes do |t|
t.references :strategy, null: false, index: false, foreign_key: { to_table: :operations_strategies, on_delete: :cascade }
@@ -11,4 +12,5 @@ class CreateOperationsScopesTable < ActiveRecord::Migration[6.0]
add_index :operations_scopes, [:strategy_id, :environment_scope], unique: true
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200213093702_add_email_restrictions_to_application_settings.rb b/db/migrate/20200213093702_add_email_restrictions_to_application_settings.rb
index 22d7b9f37e0..2b8afacb6b3 100644
--- a/db/migrate/20200213093702_add_email_restrictions_to_application_settings.rb
+++ b/db/migrate/20200213093702_add_email_restrictions_to_application_settings.rb
@@ -3,10 +3,12 @@
class AddEmailRestrictionsToApplicationSettings < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
def up
add_column(:application_settings, :email_restrictions_enabled, :boolean, default: false, null: false)
add_column(:application_settings, :email_restrictions, :text, null: true)
end
+ # rubocop:enable Migration/AddLimitToTextColumns
def down
remove_column(:application_settings, :email_restrictions_enabled)
diff --git a/db/migrate/20200213100530_add_verification_columns_to_packages.rb b/db/migrate/20200213100530_add_verification_columns_to_packages.rb
index 4c4e9a88c60..b715f35fcab 100644
--- a/db/migrate/20200213100530_add_verification_columns_to_packages.rb
+++ b/db/migrate/20200213100530_add_verification_columns_to_packages.rb
@@ -3,6 +3,7 @@
class AddVerificationColumnsToPackages < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
add_column :packages_package_files, :verification_retry_at, :datetime_with_timezone
add_column :packages_package_files, :verified_at, :datetime_with_timezone
@@ -10,4 +11,5 @@ class AddVerificationColumnsToPackages < ActiveRecord::Migration[6.0]
add_column :packages_package_files, :verification_failure, :string, limit: 255
add_column :packages_package_files, :verification_retry_count, :integer
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200214025454_add_canonical_emails.rb b/db/migrate/20200214025454_add_canonical_emails.rb
index 80cf535abfa..0732d39169d 100644
--- a/db/migrate/20200214025454_add_canonical_emails.rb
+++ b/db/migrate/20200214025454_add_canonical_emails.rb
@@ -10,7 +10,7 @@ class AddCanonicalEmails < ActiveRecord::Migration[6.0]
create_table :user_canonical_emails do |t|
t.timestamps_with_timezone
t.references :user, index: false, null: false, foreign_key: { on_delete: :cascade }
- t.string :canonical_email, null: false, index: true # rubocop:disable Migration/AddLimitToStringColumns
+ t.string :canonical_email, null: false, index: true # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20200219105209_add_filepath_to_release_links.rb b/db/migrate/20200219105209_add_filepath_to_release_links.rb
index bcc204c22e8..ba69332fb70 100644
--- a/db/migrate/20200219105209_add_filepath_to_release_links.rb
+++ b/db/migrate/20200219105209_add_filepath_to_release_links.rb
@@ -3,6 +3,6 @@ class AddFilepathToReleaseLinks < ActiveRecord::Migration[6.0]
DOWNTIME = false
def change
- add_column :release_links, :filepath, :string, limit: 128
+ add_column :release_links, :filepath, :string, limit: 128 # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20200219135440_add_limit_metric_type_to_list.rb b/db/migrate/20200219135440_add_limit_metric_type_to_list.rb
index 35e36b4805b..a2b2fb25ac9 100644
--- a/db/migrate/20200219135440_add_limit_metric_type_to_list.rb
+++ b/db/migrate/20200219135440_add_limit_metric_type_to_list.rb
@@ -4,6 +4,6 @@ class AddLimitMetricTypeToList < ActiveRecord::Migration[6.0]
DOWNTIME = false
def change
- add_column :lists, :limit_metric, :string, limit: 20
+ add_column :lists, :limit_metric, :string, limit: 20 # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20200224020219_add_status_page_settings.rb b/db/migrate/20200224020219_add_status_page_settings.rb
index b960b60881e..b45dfc8ec46 100644
--- a/db/migrate/20200224020219_add_status_page_settings.rb
+++ b/db/migrate/20200224020219_add_status_page_settings.rb
@@ -3,6 +3,7 @@
class AddStatusPageSettings < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :status_page_settings, id: false do |t|
t.references :project, index: true, primary_key: true, foreign_key: { on_delete: :cascade }, unique: true, null: false
@@ -15,4 +16,5 @@ class AddStatusPageSettings < ActiveRecord::Migration[6.0]
t.string :encrypted_aws_secret_key_iv, limit: 255, null: false
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200226100614_create_requirements.rb b/db/migrate/20200226100614_create_requirements.rb
index 4ebbf38b8d1..f374e1e9581 100644
--- a/db/migrate/20200226100614_create_requirements.rb
+++ b/db/migrate/20200226100614_create_requirements.rb
@@ -5,6 +5,7 @@ class CreateRequirements < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :requirements do |t|
t.timestamps_with_timezone null: false
@@ -14,7 +15,7 @@ class CreateRequirements < ActiveRecord::Migration[6.0]
t.integer :cached_markdown_version
t.integer :state, limit: 2, default: 1, null: false
t.string :title, limit: 255, null: false
- t.text :title_html
+ t.text :title_html # rubocop:disable Migration/AddLimitToTextColumns
t.index :project_id
t.index :author_id
@@ -25,4 +26,5 @@ class CreateRequirements < ActiveRecord::Migration[6.0]
t.index %w(project_id iid), name: 'index_requirements_on_project_id_and_iid', where: 'project_id IS NOT NULL', unique: true, using: :btree
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200227164113_create_scim_identities.rb b/db/migrate/20200227164113_create_scim_identities.rb
index 1942270761b..34e119ccfe3 100644
--- a/db/migrate/20200227164113_create_scim_identities.rb
+++ b/db/migrate/20200227164113_create_scim_identities.rb
@@ -3,6 +3,7 @@
class CreateScimIdentities < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :scim_identities do |t|
t.references :group, foreign_key: { to_table: :namespaces, on_delete: :cascade }, null: false
@@ -15,4 +16,5 @@ class CreateScimIdentities < ActiveRecord::Migration[6.0]
t.index [:user_id, :group_id], unique: true
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200227165129_create_user_details.rb b/db/migrate/20200227165129_create_user_details.rb
index fe9f23fcb21..89258eadb9f 100644
--- a/db/migrate/20200227165129_create_user_details.rb
+++ b/db/migrate/20200227165129_create_user_details.rb
@@ -5,6 +5,7 @@ class CreateUserDetails < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
with_lock_retries do
create_table :user_details, id: false do |t|
@@ -15,6 +16,7 @@ class CreateUserDetails < ActiveRecord::Migration[6.0]
add_index :user_details, :user_id, unique: true
end
+ # rubocop:enable Migration/PreventStrings
def down
with_lock_retries do
diff --git a/db/migrate/20200302152516_add_wiki_slug.rb b/db/migrate/20200302152516_add_wiki_slug.rb
index dabac39aeb8..a7891427c10 100644
--- a/db/migrate/20200302152516_add_wiki_slug.rb
+++ b/db/migrate/20200302152516_add_wiki_slug.rb
@@ -3,6 +3,7 @@
class AddWikiSlug < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :wiki_page_meta, id: :serial do |t|
t.references :project, index: true, foreign_key: { on_delete: :cascade }, null: false
@@ -19,4 +20,5 @@ class AddWikiSlug < ActiveRecord::Migration[6.0]
t.index [:wiki_page_meta_id], name: 'one_canonical_wiki_page_slug_per_metadata', unique: true, where: "(canonical = true)"
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200305200641_create_terraform_states.rb b/db/migrate/20200305200641_create_terraform_states.rb
index 3e137369e33..8429d5cfeb3 100644
--- a/db/migrate/20200305200641_create_terraform_states.rb
+++ b/db/migrate/20200305200641_create_terraform_states.rb
@@ -3,6 +3,7 @@
class CreateTerraformStates < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :terraform_states do |t|
t.references :project, index: true, foreign_key: { on_delete: :cascade }, null: false
@@ -11,4 +12,5 @@ class CreateTerraformStates < ActiveRecord::Migration[6.0]
t.string :file, limit: 255
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200309162244_add_open_project_tracker_data.rb b/db/migrate/20200309162244_add_open_project_tracker_data.rb
index 672dde4d518..5906eb7ebff 100644
--- a/db/migrate/20200309162244_add_open_project_tracker_data.rb
+++ b/db/migrate/20200309162244_add_open_project_tracker_data.rb
@@ -6,6 +6,7 @@
class AddOpenProjectTrackerData < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :open_project_tracker_data do |t|
t.references :service, foreign_key: { on_delete: :cascade }, type: :integer, index: true, null: false
@@ -20,4 +21,5 @@ class AddOpenProjectTrackerData < ActiveRecord::Migration[6.0]
t.string :project_identifier_code, limit: 100
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200311154110_create_vulnerability_exports.rb b/db/migrate/20200311154110_create_vulnerability_exports.rb
index f3162f8808c..5a3355ab5be 100644
--- a/db/migrate/20200311154110_create_vulnerability_exports.rb
+++ b/db/migrate/20200311154110_create_vulnerability_exports.rb
@@ -5,6 +5,7 @@ class CreateVulnerabilityExports < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :vulnerability_exports do |t|
t.timestamps_with_timezone null: false
@@ -21,4 +22,5 @@ class CreateVulnerabilityExports < ActiveRecord::Migration[6.0]
t.index %i[author_id]
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200311165635_create_project_export_jobs.rb b/db/migrate/20200311165635_create_project_export_jobs.rb
index 026ad2cd771..21ff5f488f7 100644
--- a/db/migrate/20200311165635_create_project_export_jobs.rb
+++ b/db/migrate/20200311165635_create_project_export_jobs.rb
@@ -3,6 +3,7 @@
class CreateProjectExportJobs < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :project_export_jobs do |t|
t.references :project, index: false, null: false, foreign_key: { on_delete: :cascade }
@@ -16,4 +17,5 @@ class CreateProjectExportJobs < ActiveRecord::Migration[6.0]
t.index [:project_id, :status]
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200318162148_add_external_key_to_issues_table.rb b/db/migrate/20200318162148_add_external_key_to_issues_table.rb
index eeac6ae3155..b98937861be 100644
--- a/db/migrate/20200318162148_add_external_key_to_issues_table.rb
+++ b/db/migrate/20200318162148_add_external_key_to_issues_table.rb
@@ -7,7 +7,7 @@ class AddExternalKeyToIssuesTable < ActiveRecord::Migration[6.0]
def up
with_lock_retries do
- add_column :issues, :external_key, :string, limit: 255
+ add_column :issues, :external_key, :string, limit: 255 # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20200318164448_add_external_key_to_epics_table.rb b/db/migrate/20200318164448_add_external_key_to_epics_table.rb
index c21fb1698bc..dee2ca98f36 100644
--- a/db/migrate/20200318164448_add_external_key_to_epics_table.rb
+++ b/db/migrate/20200318164448_add_external_key_to_epics_table.rb
@@ -7,7 +7,7 @@ class AddExternalKeyToEpicsTable < ActiveRecord::Migration[6.0]
def up
with_lock_retries do
- add_column :epics, :external_key, :string, limit: 255
+ add_column :epics, :external_key, :string, limit: 255 # rubocop:disable Migration/PreventStrings
end
end
diff --git a/db/migrate/20200318183553_create_pypi_package_metadata.rb b/db/migrate/20200318183553_create_pypi_package_metadata.rb
index 3f0204d51ac..6ebe70da643 100644
--- a/db/migrate/20200318183553_create_pypi_package_metadata.rb
+++ b/db/migrate/20200318183553_create_pypi_package_metadata.rb
@@ -8,7 +8,7 @@ class CreatePypiPackageMetadata < ActiveRecord::Migration[6.0]
def change
create_table :packages_pypi_metadata, id: false do |t|
t.references :package, primary_key: true, index: false, default: nil, foreign_key: { to_table: :packages_packages, on_delete: :cascade }, type: :bigint
- t.string "required_python", null: false, limit: 50
+ t.string "required_python", null: false, limit: 50 # rubocop:disable Migration/PreventStrings
end
end
end
diff --git a/db/migrate/20200319124127_create_metrics_dashboard_annotations.rb b/db/migrate/20200319124127_create_metrics_dashboard_annotations.rb
index 4c57e38518a..9e10299b4f8 100644
--- a/db/migrate/20200319124127_create_metrics_dashboard_annotations.rb
+++ b/db/migrate/20200319124127_create_metrics_dashboard_annotations.rb
@@ -7,6 +7,7 @@ class CreateMetricsDashboardAnnotations < ActiveRecord::Migration[6.0]
# Set this constant to true if this migration requires downtime.
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :metrics_dashboard_annotations do |t|
t.datetime_with_timezone :starting_at, null: false
@@ -15,10 +16,11 @@ class CreateMetricsDashboardAnnotations < ActiveRecord::Migration[6.0]
t.references :cluster, index: false, foreign_key: { on_delete: :cascade }, null: true
t.string :dashboard_path, null: false, limit: 255
t.string :panel_xid, limit: 255
- t.text :description, null: false, limit: 255
+ t.text :description, null: false, limit: 255 # rubocop:disable Migration/AddLimitToTextColumns
t.index %i(environment_id dashboard_path starting_at ending_at), where: 'environment_id IS NOT NULL', name: "index_metrics_dashboard_annotations_on_environment_id_and_3_col"
t.index %i(cluster_id dashboard_path starting_at ending_at), where: 'cluster_id IS NOT NULL', name: "index_metrics_dashboard_annotations_on_cluster_id_and_3_columns"
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200323071918_add_bio_to_user_details.rb b/db/migrate/20200323071918_add_bio_to_user_details.rb
index 90e4b964695..b93f5107523 100644
--- a/db/migrate/20200323071918_add_bio_to_user_details.rb
+++ b/db/migrate/20200323071918_add_bio_to_user_details.rb
@@ -7,9 +7,11 @@ class AddBioToUserDetails < ActiveRecord::Migration[6.0]
disable_ddl_transaction!
+ # rubocop:disable Migration/PreventStrings
def up
add_column_with_default(:user_details, :bio, :string, default: '', allow_null: false, limit: 255, update_column_in_batches_args: { batch_column_name: :user_id })
end
+ # rubocop:enable Migration/PreventStrings
def down
remove_column(:user_details, :bio)
diff --git a/db/migrate/20200326114443_create_jira_imports_table.rb b/db/migrate/20200326114443_create_jira_imports_table.rb
index e114bd513f4..d53ccb166b0 100644
--- a/db/migrate/20200326114443_create_jira_imports_table.rb
+++ b/db/migrate/20200326114443_create_jira_imports_table.rb
@@ -7,6 +7,7 @@ class CreateJiraImportsTable < ActiveRecord::Migration[6.0]
disable_ddl_transaction!
+ # rubocop:disable Migration/PreventStrings
def change
create_table :jira_imports do |t|
t.integer :project_id, null: false, limit: 8
@@ -26,4 +27,5 @@ class CreateJiraImportsTable < ActiveRecord::Migration[6.0]
add_index :jira_imports, [:project_id, :jira_project_key], name: 'index_jira_imports_on_project_id_and_jira_project_key'
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200326122700_create_diff_note_positions.rb b/db/migrate/20200326122700_create_diff_note_positions.rb
index 87159e666b5..d37f7fef078 100644
--- a/db/migrate/20200326122700_create_diff_note_positions.rb
+++ b/db/migrate/20200326122700_create_diff_note_positions.rb
@@ -5,6 +5,8 @@ class CreateDiffNotePositions < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/AddLimitToTextColumns
+ # rubocop:disable Migration/PreventStrings
def up
with_lock_retries do
create_table :diff_note_positions do |t|
@@ -24,6 +26,8 @@ class CreateDiffNotePositions < ActiveRecord::Migration[6.0]
end
end
end
+ # rubocop:enable Migration/PreventStrings
+ # rubocop:enable Migration/AddLimitToTextColumns
def down
drop_table :diff_note_positions
diff --git a/db/migrate/20200401211005_create_operations_user_lists.rb b/db/migrate/20200401211005_create_operations_user_lists.rb
index c5b928b8350..b0b02ca8886 100644
--- a/db/migrate/20200401211005_create_operations_user_lists.rb
+++ b/db/migrate/20200401211005_create_operations_user_lists.rb
@@ -8,8 +8,8 @@ class CreateOperationsUserLists < ActiveRecord::Migration[6.0]
t.references :project, index: false, foreign_key: { on_delete: :cascade }, null: false
t.timestamps_with_timezone
t.integer :iid, null: false
- t.string :name, null: false, limit: 255
- t.text :user_xids, null: false, default: ''
+ t.string :name, null: false, limit: 255 # rubocop:disable Migration/PreventStrings
+ t.text :user_xids, null: false, default: '' # rubocop:disable Migration/AddLimitToTextColumns
t.index [:project_id, :iid], unique: true
t.index [:project_id, :name], unique: true
diff --git a/db/migrate/20200402124802_add_correlation_id_to_project_import_state.rb b/db/migrate/20200402124802_add_correlation_id_to_project_import_state.rb
index 974009b101a..97eb01529cc 100644
--- a/db/migrate/20200402124802_add_correlation_id_to_project_import_state.rb
+++ b/db/migrate/20200402124802_add_correlation_id_to_project_import_state.rb
@@ -5,11 +5,13 @@ class AddCorrelationIdToProjectImportState < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def up
with_lock_retries do
add_column :project_mirror_data, :correlation_id_value, :string, limit: 128
end
end
+ # rubocop:enable Migration/PreventStrings
def down
with_lock_retries do
diff --git a/db/migrate/20200402185044_create_clusters_applications_fluentd.rb b/db/migrate/20200402185044_create_clusters_applications_fluentd.rb
index 08f3faf80e1..2116b2ffe01 100644
--- a/db/migrate/20200402185044_create_clusters_applications_fluentd.rb
+++ b/db/migrate/20200402185044_create_clusters_applications_fluentd.rb
@@ -3,6 +3,7 @@
class CreateClustersApplicationsFluentd < ActiveRecord::Migration[6.0]
DOWNTIME = false
+ # rubocop:disable Migration/PreventStrings
def change
create_table :clusters_applications_fluentd do |t|
t.integer :protocol, null: false, limit: 2
@@ -12,7 +13,8 @@ class CreateClustersApplicationsFluentd < ActiveRecord::Migration[6.0]
t.timestamps_with_timezone null: false
t.string :version, null: false, limit: 255
t.string :host, null: false, limit: 255
- t.text :status_reason
+ t.text :status_reason # rubocop:disable Migration/AddLimitToTextColumns
end
end
+ # rubocop:enable Migration/PreventStrings
end
diff --git a/db/migrate/20200407120000_add_push_rule_id_to_groups.rb b/db/migrate/20200407120000_add_push_rule_id_to_groups.rb
new file mode 100644
index 00000000000..4b4e99052aa
--- /dev/null
+++ b/db/migrate/20200407120000_add_push_rule_id_to_groups.rb
@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class AddPushRuleIdToGroups < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ def up
+ with_lock_retries do
+ add_column :namespaces, :push_rule_id, :bigint
+ end
+ end
+
+ def down
+ with_lock_retries do
+ remove_column :namespaces, :push_rule_id
+ end
+ end
+end
diff --git a/db/migrate/20200407121321_add_push_rule_foreign_key_to_groups.rb b/db/migrate/20200407121321_add_push_rule_foreign_key_to_groups.rb
new file mode 100644
index 00000000000..acc74b43659
--- /dev/null
+++ b/db/migrate/20200407121321_add_push_rule_foreign_key_to_groups.rb
@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+class AddPushRuleForeignKeyToGroups < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+ disable_ddl_transaction!
+
+ def up
+ add_concurrent_index :namespaces, :push_rule_id, unique: true
+ add_concurrent_foreign_key :namespaces, :push_rules, column: :push_rule_id, on_delete: :nullify
+ end
+
+ def down
+ remove_foreign_key_if_exists :namespaces, column: :push_rule_id
+ remove_concurrent_index :namespaces, :push_rule_id
+ end
+end
diff --git a/db/migrate/20200407171133_add_protected_tag_create_access_levels_user_id_foreign_key.rb b/db/migrate/20200407171133_add_protected_tag_create_access_levels_user_id_foreign_key.rb
index d6d6d86a0ad..69222710026 100644
--- a/db/migrate/20200407171133_add_protected_tag_create_access_levels_user_id_foreign_key.rb
+++ b/db/migrate/20200407171133_add_protected_tag_create_access_levels_user_id_foreign_key.rb
@@ -1,12 +1,15 @@
# frozen_string_literal: true
# rubocop: disable Migration/AddConcurrentForeignKey
+# rubocop: disable Migration/WithLockRetriesWithoutDdlTransaction
class AddProtectedTagCreateAccessLevelsUserIdForeignKey < ActiveRecord::Migration[6.0]
include Gitlab::Database::MigrationHelpers
DOWNTIME = false
CONSTRAINT_NAME = 'fk_protected_tag_create_access_levels_user_id'
+ disable_ddl_transaction!
+
def up
with_lock_retries do
add_foreign_key(:protected_tag_create_access_levels, :users, on_delete: :cascade, validate: false, name: CONSTRAINT_NAME)
diff --git a/db/migrate/20200407182205_create_partitioned_foreign_keys.rb b/db/migrate/20200407182205_create_partitioned_foreign_keys.rb
new file mode 100644
index 00000000000..aca8116d2dd
--- /dev/null
+++ b/db/migrate/20200407182205_create_partitioned_foreign_keys.rb
@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+class CreatePartitionedForeignKeys < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ disable_ddl_transaction!
+
+ def up
+ create_table :partitioned_foreign_keys do |t|
+ t.boolean :cascade_delete, null: false, default: true
+ t.text :from_table, null: false
+ t.text :from_column, null: false
+ t.text :to_table, null: false
+ t.text :to_column, null: false
+ end
+
+ add_text_limit :partitioned_foreign_keys, :from_table, 63
+ add_text_limit :partitioned_foreign_keys, :from_column, 63
+ add_text_limit :partitioned_foreign_keys, :to_table, 63
+ add_text_limit :partitioned_foreign_keys, :to_column, 63
+
+ add_index :partitioned_foreign_keys, [:to_table, :from_table, :from_column], unique: true,
+ name: "index_partitioned_foreign_keys_unique_index"
+ end
+
+ def down
+ drop_table :partitioned_foreign_keys
+ end
+end
diff --git a/db/migrate/20200408154331_add_protected_branch_merge_access_levels_user_id_foreign_key.rb b/db/migrate/20200408154331_add_protected_branch_merge_access_levels_user_id_foreign_key.rb
index 0d80c095757..1b31da93fe7 100644
--- a/db/migrate/20200408154331_add_protected_branch_merge_access_levels_user_id_foreign_key.rb
+++ b/db/migrate/20200408154331_add_protected_branch_merge_access_levels_user_id_foreign_key.rb
@@ -1,12 +1,15 @@
# frozen_string_literal: true
# rubocop: disable Migration/AddConcurrentForeignKey
+# rubocop: disable Migration/WithLockRetriesWithoutDdlTransaction
class AddProtectedBranchMergeAccessLevelsUserIdForeignKey < ActiveRecord::Migration[6.0]
include Gitlab::Database::MigrationHelpers
DOWNTIME = false
CONSTRAINT_NAME = 'fk_protected_branch_merge_access_levels_user_id'
+ disable_ddl_transaction!
+
def up
with_lock_retries do
add_foreign_key(:protected_branch_merge_access_levels, :users, on_delete: :cascade, validate: false, name: CONSTRAINT_NAME)
diff --git a/db/migrate/20200408154411_add_path_locks_user_id_foreign_key.rb b/db/migrate/20200408154411_add_path_locks_user_id_foreign_key.rb
index 8fcfb2615bb..5cab846d281 100644
--- a/db/migrate/20200408154411_add_path_locks_user_id_foreign_key.rb
+++ b/db/migrate/20200408154411_add_path_locks_user_id_foreign_key.rb
@@ -1,12 +1,15 @@
# frozen_string_literal: true
# rubocop: disable Migration/AddConcurrentForeignKey
+# rubocop: disable Migration/WithLockRetriesWithoutDdlTransaction
class AddPathLocksUserIdForeignKey < ActiveRecord::Migration[6.0]
include Gitlab::Database::MigrationHelpers
DOWNTIME = false
CONSTRAINT_NAME = 'fk_path_locks_user_id'
+ disable_ddl_transaction!
+
def up
with_lock_retries do
add_foreign_key(:path_locks, :users, on_delete: :cascade, validate: false, name: CONSTRAINT_NAME)
diff --git a/db/migrate/20200408154455_add_protected_branch_push_access_levels_user_id_foreign_key.rb b/db/migrate/20200408154455_add_protected_branch_push_access_levels_user_id_foreign_key.rb
index 9127e5dea7f..c0c844b8853 100644
--- a/db/migrate/20200408154455_add_protected_branch_push_access_levels_user_id_foreign_key.rb
+++ b/db/migrate/20200408154455_add_protected_branch_push_access_levels_user_id_foreign_key.rb
@@ -1,12 +1,15 @@
# frozen_string_literal: true
# rubocop: disable Migration/AddConcurrentForeignKey
+# rubocop: disable Migration/WithLockRetriesWithoutDdlTransaction
class AddProtectedBranchPushAccessLevelsUserIdForeignKey < ActiveRecord::Migration[6.0]
include Gitlab::Database::MigrationHelpers
DOWNTIME = false
CONSTRAINT_NAME = 'fk_protected_branch_push_access_levels_user_id'
+ disable_ddl_transaction!
+
def up
with_lock_retries do
add_foreign_key(:protected_branch_push_access_levels, :users, on_delete: :cascade, validate: false, name: CONSTRAINT_NAME)
diff --git a/db/migrate/20200408154604_add_u2f_registrations_user_id_foreign_key.rb b/db/migrate/20200408154604_add_u2f_registrations_user_id_foreign_key.rb
index 92aded750e5..0dc8a967955 100644
--- a/db/migrate/20200408154604_add_u2f_registrations_user_id_foreign_key.rb
+++ b/db/migrate/20200408154604_add_u2f_registrations_user_id_foreign_key.rb
@@ -1,12 +1,15 @@
# frozen_string_literal: true
# rubocop: disable Migration/AddConcurrentForeignKey
+# rubocop: disable Migration/WithLockRetriesWithoutDdlTransaction
class AddU2fRegistrationsUserIdForeignKey < ActiveRecord::Migration[6.0]
include Gitlab::Database::MigrationHelpers
DOWNTIME = false
CONSTRAINT_NAME = 'fk_u2f_registrations_user_id'
+ disable_ddl_transaction!
+
def up
with_lock_retries do
add_foreign_key(:u2f_registrations, :users, on_delete: :cascade, validate: false, name: CONSTRAINT_NAME)
diff --git a/db/migrate/20200408212219_add_status_page_url_to_status_page_settings.rb b/db/migrate/20200408212219_add_status_page_url_to_status_page_settings.rb
new file mode 100644
index 00000000000..3b3849c109c
--- /dev/null
+++ b/db/migrate/20200408212219_add_status_page_url_to_status_page_settings.rb
@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+class AddStatusPageUrlToStatusPageSettings < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ disable_ddl_transaction!
+
+ def up
+ add_column :status_page_settings, :status_page_url, :text
+ add_text_limit :status_page_settings, :status_page_url, 1024
+ end
+
+ def down
+ remove_column :status_page_settings, :status_page_url
+ end
+end
diff --git a/db/migrate/20200409085956_add_partial_index_on_import_failures_retry_count.rb b/db/migrate/20200409085956_add_partial_index_on_import_failures_retry_count.rb
new file mode 100644
index 00000000000..0999f7b4c95
--- /dev/null
+++ b/db/migrate/20200409085956_add_partial_index_on_import_failures_retry_count.rb
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class AddPartialIndexOnImportFailuresRetryCount < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ disable_ddl_transaction!
+
+ def up
+ add_concurrent_index :import_failures, [:project_id, :correlation_id_value], where: 'retry_count = 0'
+ end
+
+ def down
+ remove_concurrent_index :import_failures, [:project_id, :correlation_id_value]
+ end
+end
diff --git a/db/migrate/20200410104828_add_comment_detail_to_services.rb b/db/migrate/20200410104828_add_comment_detail_to_services.rb
new file mode 100644
index 00000000000..61d993cce32
--- /dev/null
+++ b/db/migrate/20200410104828_add_comment_detail_to_services.rb
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class AddCommentDetailToServices < ActiveRecord::Migration[6.0]
+ DOWNTIME = false
+
+ def up
+ add_column :services, :comment_detail, :smallint
+ end
+
+ def down
+ remove_column :services, :comment_detail
+ end
+end
diff --git a/db/migrate/20200410232012_add_metrics_dashboard_access_level_to_project_feature.rb b/db/migrate/20200410232012_add_metrics_dashboard_access_level_to_project_feature.rb
new file mode 100644
index 00000000000..2953cdf3429
--- /dev/null
+++ b/db/migrate/20200410232012_add_metrics_dashboard_access_level_to_project_feature.rb
@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class AddMetricsDashboardAccessLevelToProjectFeature < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ def up
+ with_lock_retries do
+ add_column :project_features, :metrics_dashboard_access_level, :integer
+ end
+ end
+
+ def down
+ with_lock_retries do
+ remove_column :project_features, :metrics_dashboard_access_level, :integer
+ end
+ end
+end
diff --git a/db/migrate/20200413072059_add_group_owners_can_manage_default_branch_protection_to_application_settings.rb b/db/migrate/20200413072059_add_group_owners_can_manage_default_branch_protection_to_application_settings.rb
new file mode 100644
index 00000000000..eea564d00f4
--- /dev/null
+++ b/db/migrate/20200413072059_add_group_owners_can_manage_default_branch_protection_to_application_settings.rb
@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class AddGroupOwnersCanManageDefaultBranchProtectionToApplicationSettings < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+ disable_ddl_transaction!
+
+ def up
+ add_column_with_default(:application_settings,
+ :group_owners_can_manage_default_branch_protection,
+ :boolean,
+ default: true)
+ end
+
+ def down
+ remove_column :application_settings, :group_owners_can_manage_default_branch_protection
+ end
+end
diff --git a/db/migrate/20200413230056_add_waf_and_cilium_logs_to_applications_fluentd.rb b/db/migrate/20200413230056_add_waf_and_cilium_logs_to_applications_fluentd.rb
new file mode 100644
index 00000000000..46047b74f84
--- /dev/null
+++ b/db/migrate/20200413230056_add_waf_and_cilium_logs_to_applications_fluentd.rb
@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+class AddWafAndCiliumLogsToApplicationsFluentd < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ disable_ddl_transaction!
+
+ def up
+ add_column_with_default(:clusters_applications_fluentd,
+ :waf_log_enabled,
+ :boolean,
+ default: true,
+ allow_null: false)
+ add_column_with_default(:clusters_applications_fluentd,
+ :cilium_log_enabled,
+ :boolean,
+ default: true,
+ allow_null: false)
+ end
+
+ def down
+ remove_column(:clusters_applications_fluentd,
+ :waf_log_enabled)
+ remove_column(:clusters_applications_fluentd,
+ :cilium_log_enabled)
+ end
+end
diff --git a/db/migrate/20200414144547_remove_index_projects_on_creator_id_and_created_at_from_projects.rb b/db/migrate/20200414144547_remove_index_projects_on_creator_id_and_created_at_from_projects.rb
new file mode 100644
index 00000000000..c4409fcc55d
--- /dev/null
+++ b/db/migrate/20200414144547_remove_index_projects_on_creator_id_and_created_at_from_projects.rb
@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+class RemoveIndexProjectsOnCreatorIdAndCreatedAtFromProjects < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+ INDEX_NAME = 'index_projects_on_creator_id_and_created_at'
+
+ disable_ddl_transaction!
+
+ def up
+ remove_concurrent_index_by_name :projects, INDEX_NAME
+ end
+
+ def down
+ add_concurrent_index :projects, [:creator_id, :created_at], name: INDEX_NAME
+ end
+end
diff --git a/db/migrate/20200415192656_add_name_regex_keep_to_container_expiration_policies.rb b/db/migrate/20200415192656_add_name_regex_keep_to_container_expiration_policies.rb
new file mode 100644
index 00000000000..e223d94caf7
--- /dev/null
+++ b/db/migrate/20200415192656_add_name_regex_keep_to_container_expiration_policies.rb
@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+class AddNameRegexKeepToContainerExpirationPolicies < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ disable_ddl_transaction!
+
+ CONSTRAINT_NAME = 'container_expiration_policies_name_regex_keep'
+
+ def up
+ add_column(:container_expiration_policies, :name_regex_keep, :text)
+ add_text_limit(:container_expiration_policies, :name_regex_keep, 255, constraint_name: CONSTRAINT_NAME)
+ end
+
+ def down
+ remove_check_constraint(:container_expiration_policies, CONSTRAINT_NAME)
+ remove_column(:container_expiration_policies, :name_regex_keep)
+ end
+end
diff --git a/db/migrate/20200416120128_add_columns_to_terraform_state.rb b/db/migrate/20200416120128_add_columns_to_terraform_state.rb
new file mode 100644
index 00000000000..65d25d842e5
--- /dev/null
+++ b/db/migrate/20200416120128_add_columns_to_terraform_state.rb
@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class AddColumnsToTerraformState < ActiveRecord::Migration[6.0]
+ DOWNTIME = false
+
+ # rubocop:disable Migration/PreventStrings
+ def change
+ add_column :terraform_states, :lock_xid, :string, limit: 255
+ add_column :terraform_states, :locked_at, :datetime_with_timezone
+ add_column :terraform_states, :locked_by_user_id, :bigint
+ add_column :terraform_states, :uuid, :string, limit: 32, null: false # rubocop:disable Rails/NotNullColumn (table not used yet)
+ add_column :terraform_states, :name, :string, limit: 255
+ add_index :terraform_states, :locked_by_user_id # rubocop:disable Migration/AddIndex (table not used yet)
+ add_index :terraform_states, :uuid, unique: true # rubocop:disable Migration/AddIndex (table not used yet)
+ add_index :terraform_states, [:project_id, :name], unique: true # rubocop:disable Migration/AddIndex (table not used yet)
+ remove_index :terraform_states, :project_id # rubocop:disable Migration/RemoveIndex (table not used yet)
+ end
+ # rubocop:enable Migration/PreventStrings
+end
diff --git a/db/migrate/20200416120354_add_locked_by_user_id_foreign_key_to_terraform_state.rb b/db/migrate/20200416120354_add_locked_by_user_id_foreign_key_to_terraform_state.rb
new file mode 100644
index 00000000000..ecee028351a
--- /dev/null
+++ b/db/migrate/20200416120354_add_locked_by_user_id_foreign_key_to_terraform_state.rb
@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class AddLockedByUserIdForeignKeyToTerraformState < ActiveRecord::Migration[6.0]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ def up
+ with_lock_retries do
+ add_foreign_key :terraform_states, :users, column: :locked_by_user_id # rubocop:disable Migration/AddConcurrentForeignKey
+ end
+ end
+
+ def down
+ with_lock_retries do
+ remove_foreign_key :terraform_states, column: :locked_by_user_id
+ end
+ end
+end
diff --git a/db/post_migrate/20181013005024_remove_koding_from_application_settings.rb b/db/post_migrate/20181013005024_remove_koding_from_application_settings.rb
index b6e5473e896..550ad94f4ab 100644
--- a/db/post_migrate/20181013005024_remove_koding_from_application_settings.rb
+++ b/db/post_migrate/20181013005024_remove_koding_from_application_settings.rb
@@ -12,6 +12,6 @@ class RemoveKodingFromApplicationSettings < ActiveRecord::Migration[4.2]
def down
add_column :application_settings, :koding_enabled, :boolean # rubocop:disable Migration/SaferBooleanColumn
- add_column :application_settings, :koding_url, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :application_settings, :koding_url, :string
end
end
diff --git a/db/post_migrate/20190404231137_remove_alternate_url_from_geo_nodes.rb b/db/post_migrate/20190404231137_remove_alternate_url_from_geo_nodes.rb
index 8e7ef0ec54f..785ceb2fb28 100644
--- a/db/post_migrate/20190404231137_remove_alternate_url_from_geo_nodes.rb
+++ b/db/post_migrate/20190404231137_remove_alternate_url_from_geo_nodes.rb
@@ -16,6 +16,6 @@ class RemoveAlternateUrlFromGeoNodes < ActiveRecord::Migration[5.0]
end
def down
- add_column :geo_nodes, :alternate_url, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :geo_nodes, :alternate_url, :string
end
end
diff --git a/db/post_migrate/20190625184066_remove_sentry_from_application_settings.rb b/db/post_migrate/20190625184066_remove_sentry_from_application_settings.rb
index 9d71bfafffb..427df343193 100644
--- a/db/post_migrate/20190625184066_remove_sentry_from_application_settings.rb
+++ b/db/post_migrate/20190625184066_remove_sentry_from_application_settings.rb
@@ -32,7 +32,7 @@ class RemoveSentryFromApplicationSettings < ActiveRecord::Migration[5.0]
end
SENTRY_DSN_COLUMNS.each do |column|
- add_column(:application_settings, column, :string) unless column_exists?(:application_settings, column) # rubocop:disable Migration/AddLimitToStringColumns
+ add_column(:application_settings, column, :string) unless column_exists?(:application_settings, column)
end
end
end
diff --git a/db/post_migrate/20191202031812_drop_operations_feature_flags_clients_token.rb b/db/post_migrate/20191202031812_drop_operations_feature_flags_clients_token.rb
index bda461af7bc..93cef322f02 100644
--- a/db/post_migrate/20191202031812_drop_operations_feature_flags_clients_token.rb
+++ b/db/post_migrate/20191202031812_drop_operations_feature_flags_clients_token.rb
@@ -14,7 +14,7 @@ class DropOperationsFeatureFlagsClientsToken < ActiveRecord::Migration[5.2]
def down
unless column_exists?(:operations_feature_flags_clients, :token)
- add_column :operations_feature_flags_clients, :token, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :operations_feature_flags_clients, :token, :string
end
add_concurrent_index :operations_feature_flags_clients, [:project_id, :token], unique: true,
diff --git a/db/post_migrate/20200128210353_cleanup_optimistic_locking_nulls.rb b/db/post_migrate/20200128210353_cleanup_optimistic_locking_nulls.rb
index 8bc037c7333..5c172159561 100644
--- a/db/post_migrate/20200128210353_cleanup_optimistic_locking_nulls.rb
+++ b/db/post_migrate/20200128210353_cleanup_optimistic_locking_nulls.rb
@@ -31,7 +31,7 @@ class CleanupOptimisticLockingNulls < ActiveRecord::Migration[5.2]
'CleanupOptimisticLockingNulls',
2.minutes,
batch_size: BATCH_SIZE,
- other_arguments: [table]
+ other_job_arguments: [table]
)
end
end
diff --git a/db/post_migrate/20200217210353_cleanup_optimistic_locking_nulls_pt2.rb b/db/post_migrate/20200217210353_cleanup_optimistic_locking_nulls_pt2.rb
new file mode 100644
index 00000000000..62031d6dc8c
--- /dev/null
+++ b/db/post_migrate/20200217210353_cleanup_optimistic_locking_nulls_pt2.rb
@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+# See http://doc.gitlab.com/ce/development/migration_style_guide.html
+# for more information on how to write migrations for GitLab.
+
+class CleanupOptimisticLockingNullsPt2 < ActiveRecord::Migration[5.2]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ disable_ddl_transaction!
+
+ TABLES = %w(ci_stages ci_builds ci_pipelines).freeze
+ BATCH_SIZE = 10_000
+
+ def declare_class(table)
+ Class.new(ActiveRecord::Base) do
+ include EachBatch
+
+ self.table_name = table
+ self.inheritance_column = :_type_disabled # Disable STI
+ end
+ end
+
+ def up
+ last_table_final_delay = 0
+
+ TABLES.each do |table|
+ add_concurrent_index table.to_sym, :lock_version, where: "lock_version IS NULL"
+
+ last_table_final_delay = queue_background_migration_jobs_by_range_at_intervals(
+ declare_class(table).where(lock_version: nil),
+ 'CleanupOptimisticLockingNulls',
+ 2.minutes,
+ batch_size: BATCH_SIZE,
+ other_job_arguments: [table],
+ initial_delay: last_table_final_delay
+ )
+ end
+ end
+
+ def down
+ TABLES.each do |table|
+ remove_concurrent_index table.to_sym, :lock_version, where: "lock_version IS NULL"
+ end
+ end
+end
diff --git a/db/post_migrate/20200219193058_remove_state_from_issues.rb b/db/post_migrate/20200219193058_remove_state_from_issues.rb
index ac27a9a9b69..007ba600ce7 100644
--- a/db/post_migrate/20200219193058_remove_state_from_issues.rb
+++ b/db/post_migrate/20200219193058_remove_state_from_issues.rb
@@ -18,7 +18,7 @@ class RemoveStateFromIssues < ActiveRecord::Migration[6.0]
return if issue_state_column_exists?
with_lock_retries do
- add_column :issues, :state, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :issues, :state, :string
end
end
diff --git a/db/post_migrate/20200219193117_remove_state_from_merge_requests.rb b/db/post_migrate/20200219193117_remove_state_from_merge_requests.rb
index c99a732f37b..384a694b549 100644
--- a/db/post_migrate/20200219193117_remove_state_from_merge_requests.rb
+++ b/db/post_migrate/20200219193117_remove_state_from_merge_requests.rb
@@ -18,7 +18,7 @@ class RemoveStateFromMergeRequests < ActiveRecord::Migration[6.0]
return if merge_requests_state_column_exists?
with_lock_retries do
- add_column :merge_requests, :state, :string # rubocop:disable Migration/AddLimitToStringColumns
+ add_column :merge_requests, :state, :string
end
end
diff --git a/db/post_migrate/20200325162730_schedule_backfill_push_rules_id_in_projects.rb b/db/post_migrate/20200325162730_schedule_backfill_push_rules_id_in_projects.rb
index b25b3365e12..8ff3ab6aa0c 100644
--- a/db/post_migrate/20200325162730_schedule_backfill_push_rules_id_in_projects.rb
+++ b/db/post_migrate/20200325162730_schedule_backfill_push_rules_id_in_projects.rb
@@ -18,7 +18,10 @@ class ScheduleBackfillPushRulesIdInProjects < ActiveRecord::Migration[6.0]
# Update one record that is connected to the instance
value_to_be_updated_to = ScheduleBackfillPushRulesIdInProjects::PushRules.find_by(is_sample: true)&.id
- execute "UPDATE application_settings SET push_rule_id = #{value_to_be_updated_to}" if value_to_be_updated_to
+ if value_to_be_updated_to
+ execute "UPDATE application_settings SET push_rule_id = #{value_to_be_updated_to}
+ WHERE id IN (SELECT MAX(id) FROM application_settings);"
+ end
ApplicationSetting.expire
diff --git a/db/structure.sql b/db/structure.sql
index 83b01662530..89f0ab9c15d 100644
--- a/db/structure.sql
+++ b/db/structure.sql
@@ -400,7 +400,8 @@ CREATE TABLE public.application_settings (
seat_link_enabled boolean DEFAULT true NOT NULL,
container_expiration_policies_enable_historic_entries boolean DEFAULT false NOT NULL,
issues_create_limit integer DEFAULT 300 NOT NULL,
- push_rule_id bigint
+ push_rule_id bigint,
+ group_owners_can_manage_default_branch_protection boolean DEFAULT true NOT NULL
);
CREATE SEQUENCE public.application_settings_id_seq
@@ -1662,7 +1663,9 @@ CREATE TABLE public.clusters_applications_fluentd (
updated_at timestamp with time zone NOT NULL,
version character varying(255) NOT NULL,
host character varying(255) NOT NULL,
- status_reason text
+ status_reason text,
+ waf_log_enabled boolean DEFAULT true NOT NULL,
+ cilium_log_enabled boolean DEFAULT true NOT NULL
);
CREATE SEQUENCE public.clusters_applications_fluentd_id_seq
@@ -1867,7 +1870,9 @@ CREATE TABLE public.container_expiration_policies (
cadence character varying(12) DEFAULT '7d'::character varying NOT NULL,
older_than character varying(12),
keep_n integer,
- enabled boolean DEFAULT true NOT NULL
+ enabled boolean DEFAULT true NOT NULL,
+ name_regex_keep text,
+ CONSTRAINT container_expiration_policies_name_regex_keep CHECK ((char_length(name_regex_keep) <= 255))
);
CREATE TABLE public.container_repositories (
@@ -4051,7 +4056,8 @@ CREATE TABLE public.namespaces (
mentions_disabled boolean,
default_branch_protection smallint,
unlock_membership_to_ldap boolean,
- max_personal_access_token_lifetime integer
+ max_personal_access_token_lifetime integer,
+ push_rule_id bigint
);
CREATE SEQUENCE public.namespaces_id_seq
@@ -4596,6 +4602,28 @@ CREATE SEQUENCE public.pages_domains_id_seq
ALTER SEQUENCE public.pages_domains_id_seq OWNED BY public.pages_domains.id;
+CREATE TABLE public.partitioned_foreign_keys (
+ id bigint NOT NULL,
+ cascade_delete boolean DEFAULT true NOT NULL,
+ from_table text NOT NULL,
+ from_column text NOT NULL,
+ to_table text NOT NULL,
+ to_column text NOT NULL,
+ CONSTRAINT check_2c2e02a62b CHECK ((char_length(from_column) <= 63)),
+ CONSTRAINT check_40738efb57 CHECK ((char_length(to_table) <= 63)),
+ CONSTRAINT check_741676d405 CHECK ((char_length(from_table) <= 63)),
+ CONSTRAINT check_7e98be694f CHECK ((char_length(to_column) <= 63))
+);
+
+CREATE SEQUENCE public.partitioned_foreign_keys_id_seq
+ START WITH 1
+ INCREMENT BY 1
+ NO MINVALUE
+ NO MAXVALUE
+ CACHE 1;
+
+ALTER SEQUENCE public.partitioned_foreign_keys_id_seq OWNED BY public.partitioned_foreign_keys.id;
+
CREATE TABLE public.path_locks (
id integer NOT NULL,
path character varying NOT NULL,
@@ -4884,7 +4912,8 @@ CREATE TABLE public.project_features (
updated_at timestamp without time zone,
repository_access_level integer DEFAULT 20 NOT NULL,
pages_access_level integer NOT NULL,
- forking_access_level integer
+ forking_access_level integer,
+ metrics_dashboard_access_level integer
);
CREATE SEQUENCE public.project_features_id_seq
@@ -5816,7 +5845,8 @@ CREATE TABLE public.services (
description character varying(500),
comment_on_event_enabled boolean DEFAULT true NOT NULL,
template boolean DEFAULT false,
- instance boolean DEFAULT false NOT NULL
+ instance boolean DEFAULT false NOT NULL,
+ comment_detail smallint
);
CREATE SEQUENCE public.services_id_seq
@@ -5998,7 +6028,9 @@ CREATE TABLE public.status_page_settings (
aws_region character varying(255) NOT NULL,
aws_access_key character varying(255) NOT NULL,
encrypted_aws_secret_key character varying(255) NOT NULL,
- encrypted_aws_secret_key_iv character varying(255) NOT NULL
+ encrypted_aws_secret_key_iv character varying(255) NOT NULL,
+ status_page_url text,
+ CONSTRAINT check_75a79cd992 CHECK ((char_length(status_page_url) <= 1024))
);
CREATE SEQUENCE public.status_page_settings_project_id_seq
@@ -6130,7 +6162,12 @@ CREATE TABLE public.terraform_states (
created_at timestamp with time zone NOT NULL,
updated_at timestamp with time zone NOT NULL,
file_store smallint,
- file character varying(255)
+ file character varying(255),
+ lock_xid character varying(255),
+ locked_at timestamp with time zone,
+ locked_by_user_id bigint,
+ uuid character varying(32) NOT NULL,
+ name character varying(255)
);
CREATE SEQUENCE public.terraform_states_id_seq
@@ -7369,6 +7406,8 @@ ALTER TABLE ONLY public.pages_domain_acme_orders ALTER COLUMN id SET DEFAULT nex
ALTER TABLE ONLY public.pages_domains ALTER COLUMN id SET DEFAULT nextval('public.pages_domains_id_seq'::regclass);
+ALTER TABLE ONLY public.partitioned_foreign_keys ALTER COLUMN id SET DEFAULT nextval('public.partitioned_foreign_keys_id_seq'::regclass);
+
ALTER TABLE ONLY public.path_locks ALTER COLUMN id SET DEFAULT nextval('public.path_locks_id_seq'::regclass);
ALTER TABLE ONLY public.personal_access_tokens ALTER COLUMN id SET DEFAULT nextval('public.personal_access_tokens_id_seq'::regclass);
@@ -8197,6 +8236,9 @@ ALTER TABLE ONLY public.pages_domain_acme_orders
ALTER TABLE ONLY public.pages_domains
ADD CONSTRAINT pages_domains_pkey PRIMARY KEY (id);
+ALTER TABLE ONLY public.partitioned_foreign_keys
+ ADD CONSTRAINT partitioned_foreign_keys_pkey PRIMARY KEY (id);
+
ALTER TABLE ONLY public.path_locks
ADD CONSTRAINT path_locks_pkey PRIMARY KEY (id);
@@ -8818,6 +8860,8 @@ CREATE INDEX index_ci_builds_on_commit_id_and_type_and_name_and_ref ON public.ci
CREATE INDEX index_ci_builds_on_commit_id_and_type_and_ref ON public.ci_builds USING btree (commit_id, type, ref);
+CREATE INDEX index_ci_builds_on_lock_version ON public.ci_builds USING btree (lock_version) WHERE (lock_version IS NULL);
+
CREATE INDEX index_ci_builds_on_name_and_security_type_eq_ci_build ON public.ci_builds USING btree (name, id) WHERE (((name)::text = ANY (ARRAY[('container_scanning'::character varying)::text, ('dast'::character varying)::text, ('dependency_scanning'::character varying)::text, ('license_management'::character varying)::text, ('sast'::character varying)::text, ('license_scanning'::character varying)::text])) AND ((type)::text = 'Ci::Build'::text));
CREATE INDEX index_ci_builds_on_project_id_and_id ON public.ci_builds USING btree (project_id, id);
@@ -8894,6 +8938,8 @@ CREATE INDEX index_ci_pipelines_on_auto_canceled_by_id ON public.ci_pipelines US
CREATE INDEX index_ci_pipelines_on_external_pull_request_id ON public.ci_pipelines USING btree (external_pull_request_id) WHERE (external_pull_request_id IS NOT NULL);
+CREATE INDEX index_ci_pipelines_on_lock_version ON public.ci_pipelines USING btree (lock_version) WHERE (lock_version IS NULL);
+
CREATE INDEX index_ci_pipelines_on_merge_request_id ON public.ci_pipelines USING btree (merge_request_id) WHERE (merge_request_id IS NOT NULL);
CREATE INDEX index_ci_pipelines_on_pipeline_schedule_id ON public.ci_pipelines USING btree (pipeline_schedule_id);
@@ -8962,6 +9008,8 @@ CREATE INDEX index_ci_sources_projects_on_pipeline_id ON public.ci_sources_proje
CREATE UNIQUE INDEX index_ci_sources_projects_on_source_project_id_and_pipeline_id ON public.ci_sources_projects USING btree (source_project_id, pipeline_id);
+CREATE INDEX index_ci_stages_on_lock_version ON public.ci_stages USING btree (lock_version) WHERE (lock_version IS NULL);
+
CREATE INDEX index_ci_stages_on_pipeline_id ON public.ci_stages USING btree (pipeline_id);
CREATE UNIQUE INDEX index_ci_stages_on_pipeline_id_and_name ON public.ci_stages USING btree (pipeline_id, name);
@@ -9364,6 +9412,8 @@ CREATE INDEX index_import_failures_on_correlation_id_value ON public.import_fail
CREATE INDEX index_import_failures_on_group_id_not_null ON public.import_failures USING btree (group_id) WHERE (group_id IS NOT NULL);
+CREATE INDEX index_import_failures_on_project_id_and_correlation_id_value ON public.import_failures USING btree (project_id, correlation_id_value) WHERE (retry_count = 0);
+
CREATE INDEX index_import_failures_on_project_id_not_null ON public.import_failures USING btree (project_id) WHERE (project_id IS NOT NULL);
CREATE UNIQUE INDEX index_index_statuses_on_project_id ON public.index_statuses USING btree (project_id);
@@ -9666,6 +9716,8 @@ CREATE INDEX index_namespaces_on_path_trigram ON public.namespaces USING gin (pa
CREATE INDEX index_namespaces_on_plan_id ON public.namespaces USING btree (plan_id);
+CREATE UNIQUE INDEX index_namespaces_on_push_rule_id ON public.namespaces USING btree (push_rule_id);
+
CREATE INDEX index_namespaces_on_require_two_factor_authentication ON public.namespaces USING btree (require_two_factor_authentication);
CREATE UNIQUE INDEX index_namespaces_on_runners_token ON public.namespaces USING btree (runners_token);
@@ -9800,6 +9852,8 @@ CREATE INDEX index_pages_domains_on_verified_at_and_enabled_until ON public.page
CREATE INDEX index_pages_domains_on_wildcard ON public.pages_domains USING btree (wildcard);
+CREATE UNIQUE INDEX index_partitioned_foreign_keys_unique_index ON public.partitioned_foreign_keys USING btree (to_table, from_table, from_column);
+
CREATE INDEX index_pat_on_user_id_and_expires_at ON public.personal_access_tokens USING btree (user_id, expires_at);
CREATE INDEX index_path_locks_on_path ON public.path_locks USING btree (path);
@@ -9926,8 +9980,6 @@ CREATE INDEX index_projects_api_vis20_updated_at ON public.projects USING btree
CREATE INDEX index_projects_on_created_at_and_id ON public.projects USING btree (created_at, id);
-CREATE INDEX index_projects_on_creator_id_and_created_at ON public.projects USING btree (creator_id, created_at);
-
CREATE INDEX index_projects_on_creator_id_and_created_at_and_id ON public.projects USING btree (creator_id, created_at, id);
CREATE INDEX index_projects_on_creator_id_and_id ON public.projects USING btree (creator_id, id);
@@ -10228,7 +10280,11 @@ CREATE INDEX index_term_agreements_on_term_id ON public.term_agreements USING bt
CREATE INDEX index_term_agreements_on_user_id ON public.term_agreements USING btree (user_id);
-CREATE INDEX index_terraform_states_on_project_id ON public.terraform_states USING btree (project_id);
+CREATE INDEX index_terraform_states_on_locked_by_user_id ON public.terraform_states USING btree (locked_by_user_id);
+
+CREATE UNIQUE INDEX index_terraform_states_on_project_id_and_name ON public.terraform_states USING btree (project_id, name);
+
+CREATE UNIQUE INDEX index_terraform_states_on_uuid ON public.terraform_states USING btree (uuid);
CREATE INDEX index_timelogs_on_issue_id ON public.timelogs USING btree (issue_id);
@@ -10624,6 +10680,9 @@ ALTER TABLE ONLY public.merge_requests
ALTER TABLE ONLY public.ci_group_variables
ADD CONSTRAINT fk_33ae4d58d8 FOREIGN KEY (group_id) REFERENCES public.namespaces(id) ON DELETE CASCADE;
+ALTER TABLE ONLY public.namespaces
+ ADD CONSTRAINT fk_3448c97865 FOREIGN KEY (push_rule_id) REFERENCES public.push_rules(id) ON DELETE SET NULL;
+
ALTER TABLE ONLY public.epics
ADD CONSTRAINT fk_3654b61b03 FOREIGN KEY (author_id) REFERENCES public.users(id) ON DELETE CASCADE;
@@ -11404,6 +11463,9 @@ ALTER TABLE ONLY public.geo_node_namespace_links
ALTER TABLE ONLY public.clusters_applications_knative
ADD CONSTRAINT fk_rails_54fc91e0a0 FOREIGN KEY (cluster_id) REFERENCES public.clusters(id) ON DELETE CASCADE;
+ALTER TABLE ONLY public.terraform_states
+ ADD CONSTRAINT fk_rails_558901b030 FOREIGN KEY (locked_by_user_id) REFERENCES public.users(id);
+
ALTER TABLE ONLY public.issue_user_mentions
ADD CONSTRAINT fk_rails_57581fda73 FOREIGN KEY (issue_id) REFERENCES public.issues(id) ON DELETE CASCADE;
@@ -12998,6 +13060,7 @@ COPY "schema_migrations" (version) FROM STDIN;
20200214214934
20200215222507
20200215225103
+20200217210353
20200217223651
20200217225719
20200219105209
@@ -13161,8 +13224,11 @@ COPY "schema_migrations" (version) FROM STDIN;
20200406193427
20200407094005
20200407094923
+20200407120000
+20200407121321
20200407171133
20200407171417
+20200407182205
20200408110856
20200408133211
20200408153842
@@ -13175,9 +13241,19 @@ COPY "schema_migrations" (version) FROM STDIN;
20200408154604
20200408154624
20200408175424
+20200408212219
+20200409085956
20200409211607
+20200410104828
+20200410232012
+20200413072059
+20200413230056
+20200414144547
20200415160722
20200415161021
20200415161206
+20200415192656
+20200416120128
+20200416120354
\.