diff options
| author | Toon Claes <toon@gitlab.com> | 2019-07-19 20:33:48 +0300 |
|---|---|---|
| committer | Nick Thomas <nick@gitlab.com> | 2019-07-19 20:33:48 +0300 |
| commit | 34a5f77e770765f278ade00a33ef846e2e1ce3d3 (patch) | |
| tree | 11f08d25e84c62a2c0f42247f71f76f1ab016012 /doc/development/code_review.md | |
| parent | 325360444253cf630ae3bfb6cae47a1e6e612c79 (diff) | |
Document database review process
See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index a9a46c62d38..709cd0c806b 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -62,6 +62,7 @@ from teams other than your own. **approved by a [backend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_backend)**. 1. If your merge request includes database migrations or changes to expensive queries [^2], it must be **approved by a [database maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_database)**. + Read the [database review guidelines](database_review.md) for more details. 1. If your merge request includes frontend changes [^1], it must be **approved by a [frontend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab-ce_maintainers_frontend)**. 1. If your merge request includes UX changes [^1], it must be |