diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-08-20 03:12:08 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-08-20 03:12:08 +0300 |
| commit | b0e1e54ce9918a83ad41de7e2a1f57cad687e654 (patch) | |
| tree | f7a2dc0a4a091e7cfbc39aaab7a54618c376f787 /doc/development/code_review.md | |
| parent | ce5c259086445d71b405833c60ca71cd8c33de63 (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 49235bef2fe..ec3e8220845 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -326,15 +326,23 @@ Because a maintainer's job only depends on their knowledge of the overall GitLab codebase, and not that of any specific domain, they can review, approve, and merge merge requests from any team and in any product area. +Maintainers are the DRI of assuring that the acceptance criteria of a merge request are reasonably met. +In general, [quality is everyone’s responsibility](https://about.gitlab.com/handbook/engineering/quality/), +but maintainers of an MR are held responsible for **ensuring** that an MR meets those general quality standards. + +If a maintainer feels that an MR is substantial enough, or requires a [domain expert](#domain-experts), +maintainers have the discretion to request a review from another reviewer, or maintainer. Here are some +examples of maintainers proactively doing this during review: + +- <https://gitlab.com/gitlab-org/gitlab/-/merge_requests/82708#note_872325561> +- <https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38003#note_387981596> +- <https://gitlab.com/gitlab-org/gitlab/-/merge_requests/14017#note_178828088> + Maintainers do their best to also review the specifics of the chosen solution before merging, but as they are not necessarily [domain experts](#domain-experts), they may be poorly placed to do so without an unreasonable investment of time. In those cases, they defer to the judgment of the author and earlier reviewers, in favor of focusing on their primary responsibilities. -If a maintainer feels that an MR is substantial enough that it warrants a review from a [domain expert](#domain-experts), -and it is unclear whether a domain expert have been involved in the reviews to date, -they may request a [domain expert's](#domain-experts) review before merging the MR. - If a developer who happens to also be a maintainer was involved in a merge request as a reviewer, it is recommended that they are not also picked as the maintainer to ultimately approve and merge it. |