diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-01-17 15:08:29 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-01-17 15:08:29 +0300 |
| commit | b17a559378235d37f5168d8d18818043cdaaf90b (patch) | |
| tree | 97fb81f73917e4b0b48947cd730187506d5e891c /doc/development/code_review.md | |
| parent | 5d54cf276e236fbb46540f1c6ffbe13fbdbbfd12 (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 4d7815b474b..e194453565a 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -197,6 +197,7 @@ See the [test engineering process](https://about.gitlab.com/handbook/engineering 1. You have properly separated EE content from FOSS, or this MR is FOSS only. - [Where should EE code go?](ee_features.md) 1. You have considered that existing data may be surprisingly varied. For example, a new model validation can break existing records. Consider making validation on existing data optional rather than required if you haven't confirmed that existing data will pass validation. +1. If a test passes with warnings and the failed job includes the text `Flaky test '<path/to/test>' was found in the list of files changed by this MR.`, you have fixed this test, or provided evidence explaining why this flaky test can be ignored. ##### Performance, reliability, and availability |