diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-27 09:11:02 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-27 09:11:02 +0300 |
| commit | e75ebe6f6e08c3137a330e579dbd96dceb0561f9 (patch) | |
| tree | 3f123f0443f767c016e96569669259e74ea1b8d4 /doc/development/code_review.md | |
| parent | 21c8f4814b6e48e21c9c5bbe1abfaa6bfc45fe2d (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 00922995562..d0569b9ca6c 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -518,6 +518,9 @@ settings to ensure MRs get an approval from a top-level CODEOWNERS maintainer: - [Prevent editing approval rules in merge requests](../user/project/merge_requests/approvals/settings.md#prevent-editing-approval-rules-in-merge-requests). - [Remove all approvals when commits are added to the source branch](../user/project/merge_requests/approvals/settings.md#remove-all-approvals-when-commits-are-added-to-the-source-branch) +To update the code owners in the `CODEOWNERS` file for `gitlab-org/gitlab`, follow +the process explained in the [code owners approvals handbook section](https://about.gitlab.com/handbook/engineering/workflow/code-review/#code-owner-approvals). + There are scenarios such as rebasing locally or applying suggestions that are considered the same as adding a commit and could reset existing approvals. Approvals are not removed when rebasing from the UI or with the [`/rebase` quick action](../user/project/quick_actions.md). |